From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78D22CA0EC4 for ; Mon, 11 Aug 2025 18:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2HmgB4i0ef6G9gBd9c3iPtpa4z8Vmw9rM+uJkjjYMMg=; b=j8plKtRfqNWOHZ8PX/P/jW4NMs XRZNMYQz+7AHQ8JU0SlES3pWoN6cqQJkt8gwIH8/qGQpGhC6XjWAgma2HvOR+fAtfU5lxmKe8+GG2 1/0mLtAD/qNRnKy6Mbrnk9kOaX6iEirpfaU0i8/5tKrxSJ1eNPlr98WZen8pJJ8cjpYlFkNuFZ8LF PwKe7Dxwts6gEIyZr4gsJAycDgbTWWpqeNTj84xCNewgArXh1Ag4PSQAWySHLE+ymkMeIOwdCJXUP S1CrsZawXijGG/K8gAfjOP48P2fIoALTQkvn435pA454ILbDJy4asBShXAQrcRQVXZrT38Gfv4TeY tjZPww5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulXNU-00000008npP-2a5I; Mon, 11 Aug 2025 18:36:12 +0000 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ulUb6-00000008E09-0fPO; Mon, 11 Aug 2025 15:38:05 +0000 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-af9a25f091fso603819666b.0; Mon, 11 Aug 2025 08:38:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754926683; x=1755531483; darn=lists.infradead.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=2HmgB4i0ef6G9gBd9c3iPtpa4z8Vmw9rM+uJkjjYMMg=; b=m1hZ6leXpACCmUxqIu4P8B9d9f/0pktLEvqQUWWBzVvp9n343KZU3w8pBG7+D4OECg Ji4TPlLBHifgdp/kJziMolq8rASbKqpvcoTGxXn+lBe21fnbUYGRZkauD8uYm2ksHQRE zQnzG9EDNSj5qd3XQRkh7uXcwF1CSEKVMNOhjvYGXHOgidG9xaJr1h1y0lzwl6ND7smn KFhdrntKu3G1HUC/WFSJx68A5Zc0wzo83uNqHSmI4lqO7kS6Ul+KGmJ8/eZzS3wOokTS d9+m0+lFoRn5oHvWHt2E47D6WPF+8e5nYaxwkfzqpRJ39aynKCfEukScUJrW2yjsl67d UGwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754926683; x=1755531483; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=2HmgB4i0ef6G9gBd9c3iPtpa4z8Vmw9rM+uJkjjYMMg=; b=ioYMuV0DMzhuMuAZNT27BNb+lWS90cs2DzNIppvB9tT/VQhV1bcn6gpAmHo6K28GSr w++++Y6TKpz5wA2sOLO5/nLqwApyzYPwKvE7ekzyEgEHyMUr2/Kh84HTskX75r1IRu5K 8wViPqIWjt0uh2Nh9y26OcmqRO8dCzWZukzwtm8uEkn3Lekh9MUVIOXR5Pm0qTGjENh5 OZH7ZqHSQGAqeBlNQ2uUQ2CMRihemn6hwLs6VqiWmBn8BDgItqUJb+8qum0VsKokIlMA 3z0SB/wYD1ckIyty9P+tz6OdAf+TB4L+0xHCeL31Brxu83TlwViHkVRjeT6TYJFMuJi6 ofgw== X-Forwarded-Encrypted: i=1; AJvYcCUkeO+NayxBPrMFRv4XAAv2zjKfXqEnQvTsycNGbzAZdm5nt/LvGMvtlEWTm/JFrgMidnTvObpC1vcPIro=@lists.infradead.org, AJvYcCUn7Cj8pDpb18us7UzWjkymz1t/9zqs+t8qtBcvZnWJLzior4PGgV+fn0939bFYq7/LNYVBiwi7YXeeNoqBMUo=@lists.infradead.org, AJvYcCVfiHzDdRK/+fpNobhC0MaFqHJK7UEDBksex0QQR1vhi2bP5ikLZS2GdztfiX5Kj/rYWdb09vSLaX2A9BGiscVVyQ==@lists.infradead.org, AJvYcCWhrX7vqZ/zxb1m2IZ3so6OOi/yo0zFetyOD8ssTd0/gnrwIIdcUqjkbxBE3nV4dxbmRAMS8RvZ/jwId8vucqI=@lists.infradead.org, AJvYcCXlOzYV9iLtQXGiHdUMs9NI0K9KzMPspnzUySnfBuTL4EJlM/+ipAZPk+dtXrT2YTRVP4s5C9sBRnSFHq6N@lists.infradead.org X-Gm-Message-State: AOJu0Yy29rh+CEEtNxNN1lmQMiOD4+d96/TzazPsfNgIHIrgOCS/XfKk KjG7Tr1GjNQmkViKna/tv9tSgyOVc7n+r5zDhuXodaAJA53/4hPsK8f/ X-Gm-Gg: ASbGncvsiua9U4FoBmwypiJHN1Zy6ruXkPcIiGe4BD4BWq8gYQJWPKfQYjsNfR17e8R bjR8EQkI+y2/vrWaS4KF6N1uHaM5WS+PNknjz8V7MzH+9YIYUF9NNyjElJGwQ415rTWzOgB8P4K AHCt3lC9kEPfB9UDcBElqNCuRbZ+qEQsBTXrIIvLXPHHsUzM1sWXM3przH+iUGgWjv4dR4JH484 6qLG9G0zdFZIB4Bm4NCVEMr+oU6/3fiLAefr/LoTCCVMefJlA818MLhaOUlF8B9S+W/DMicn8qQ TZS2ykIK3t/zccBb116ioZIySlom5iTd1KAaJrv36WKoSJSM36Yy8PKbCEQwz4zevPzOiJLXUB/ ON7QnY/Wh1wcCGV5HJWFzrg29MSkV79wuDpsNULA= X-Google-Smtp-Source: AGHT+IHSK7yv3/D8orY0Pvy2Zzp8DcIZ6EslOLXmLH2atPhWs8y14U6F2aebL6rKGw4mDoY3DumHmw== X-Received: by 2002:a17:907:7ea8:b0:af9:8c1c:b9be with SMTP id a640c23a62f3a-af9c645d565mr1274686466b.14.1754926682117; Mon, 11 Aug 2025 08:38:02 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a21c0afsm2032301266b.117.2025.08.11.08.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Aug 2025 08:38:01 -0700 (PDT) Message-ID: <84788b3be1d340f7a085c0d2a5903fd1032dd9eb.camel@gmail.com> Subject: Re: [PATCH 114/114] clk: fixed-factor: drop round_rate() clk ops From: Alexander Sverdlin To: bmasney@redhat.com, Michael Turquette , Stephen Boyd , Sudeep Holla , Cristian Marussi , Chen Wang , Inochi Amaoto , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Paul Cercueil , Keguang Zhang , Taichi Sugaya , Takao Orito , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Huang , Shan-Chun Hung , Vladimir Zapolskiy , Piotr Wojtaszczyk , Paul Walmsley , Samuel Holland , Yixun Lan , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Orson Zhai , Baolin Wang , Chunyan Zhang , Maxime Coquelin , Alexandre Torgue , Michal Simek , Maxime Ripard , Andreas =?ISO-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , Sven Peter , Janne Grunau , Alyssa Rosenzweig , Neal Gompa , Eugeniy Paltsev , Ray Jui , Scott Branden , Broadcom internal kernel review list , Max Filippov , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Palmer , Romain Perier , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Bjorn Andersson , Geert Uytterhoeven , Heiko Stuebner , Andrea della Porta , Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Qin Jian , Viresh Kumar , Ulf Hansson , Luca Ceresoli , Alex Helms , Linus Walleij , Liviu Dudau , Lorenzo Pieralisi , Nobuhiro Iwamatsu Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, sophgo@lists.linux.dev, linux-mips@vger.kernel.org, imx@lists.linux.dev, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, patches@opensource.cirrus.com, linux-actions@lists.infradead.org, asahi@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, soc@lists.linux.dev Date: Mon, 11 Aug 2025 17:37:58 +0200 In-Reply-To: <20250811-clk-for-stephen-round-rate-v1-114-b3bf97b038dc@redhat.com> References: <20250811-clk-for-stephen-round-rate-v1-0-b3bf97b038dc@redhat.com> <20250811-clk-for-stephen-round-rate-v1-114-b3bf97b038dc@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250811_083804_198763_CE7F4187 X-CRM114-Status: GOOD ( 17.47 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Brian! On Mon, 2025-08-11 at 11:19 -0400, Brian Masney via B4 Relay wrote: > From: Brian Masney >=20 > This driver implements both the determine_rate() and round_rate() clk > ops, and the round_rate() clk ops is deprecated. When both are defined, > clk_core_determine_round_nolock() from the clk core will only use the > determine_rate() clk ops. Also all clk drivers that directly calls > fixed-factor's round_rate() have been migrated over to determine_rate(). > So let's remove the round_rate() clk ops. >=20 > Signed-off-by: Brian Masney Reviewed-by: Alexander Sverdlin > --- > =C2=A0drivers/clk/clk-fixed-factor.c | 16 ---------------- > =C2=A01 file changed, 16 deletions(-) >=20 > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-facto= r.c > index 79b9a8c57d4b84be990955d8bc3159b818f38d50..de658c9e4c5386a7a8d220743= 22577e0e9efd2b8 100644 > --- a/drivers/clk/clk-fixed-factor.c > +++ b/drivers/clk/clk-fixed-factor.c > @@ -47,21 +47,6 @@ static int clk_factor_determine_rate(struct clk_hw *hw= , > =C2=A0 return 0; > =C2=A0} > =C2=A0 > -static long clk_factor_round_rate(struct clk_hw *hw, unsigned long rate, > - unsigned long *prate) > -{ > - struct clk_fixed_factor *fix =3D to_clk_fixed_factor(hw); > - > - if (clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT) { > - unsigned long best_parent; > - > - best_parent =3D (rate / fix->mult) * fix->div; > - *prate =3D clk_hw_round_rate(clk_hw_get_parent(hw), best_parent); > - } > - > - return (*prate / fix->div) * fix->mult; > -} > - > =C2=A0static int clk_factor_set_rate(struct clk_hw *hw, unsigned long rat= e, > =C2=A0 unsigned long parent_rate) > =C2=A0{ > @@ -87,7 +72,6 @@ static unsigned long clk_factor_recalc_accuracy(struct = clk_hw *hw, > =C2=A0 > =C2=A0const struct clk_ops clk_fixed_factor_ops =3D { > =C2=A0 .determine_rate =3D clk_factor_determine_rate, > - .round_rate =3D clk_factor_round_rate, > =C2=A0 .set_rate =3D clk_factor_set_rate, > =C2=A0 .recalc_rate =3D clk_factor_recalc_rate, > =C2=A0 .recalc_accuracy =3D clk_factor_recalc_accuracy, --=20 Alexander Sverdlin.