From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA923C433FE for ; Wed, 23 Nov 2022 16:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ay8A75HoyxvplujOTHQyxz8M6JvUh8cGnz8gaZT2i2g=; b=sg3LwbF+NISD5PengsWQ0g8uX/ 4f7a0QYUQkYw77axEhY6X2YF7WyhYl5c/xNvl4Y4XLQ2h0ePSbu05A8mswTMzGRTInfV0S9gMP7yr ezTath/tWTm3oyUpucDoM9hnhb41uB8JCH1YgXBitKfTOanFLocSGJlAyKDGO9V+7uTf9CtfyABmb +T3sB86RE1mHtH5Q9sNUdmHVxDm18XVFx26UV37+YXR9Iv7UFO0vnQIwzHbtjnZf9qxUKe7hNrQ51 g0mi0aa08kVlzIoKqMuLDnv/GJ0XWGVOEbDWolIwrdo/ZiSTT6LhNxPT++7Mvgs7m4/P6fZosRo4g AnCWbEOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxsc5-000rF2-59; Wed, 23 Nov 2022 16:28:41 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxsbd-000r9n-PP; Wed, 23 Nov 2022 16:28:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 745EDB82102; Wed, 23 Nov 2022 16:28:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F6C2C433C1; Wed, 23 Nov 2022 16:28:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669220891; bh=dzyLXMtXy6cZx8prGfrgAfjTZ0RmbKIX+ZoSI6qBS64=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TeKWyCsb0x1vF39wYLZlLwM1ixgeT9Lc+UFTMLHCRbYi1iEX8CJ2cAtesLH7YwQRH W3cwmGxh7O3jVnag4/VBgrfUs7zNaQ2UxORA/1eUpvm+xhCWG+z2c1xVVMAsNuBGfP EA+S+OyTpggjyn3MOt0fGvKSSDnOfwXdcBAQD/Hdiz77iifLk94jZmC/uQi+TndxN5 vUDzHhJ+Aje6QGm38V4QKDMAEhrOooTxEH8sgPVL78KAMYk/IY43abnYGHB9r+NofI ZkRz9P54Xfsf6w51qsyxhviU8drf83DY7lwxEuHRo6d/EQOQ5km179S14YEf2BI+in 4VVe28o60E4jQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oxsbY-008BGI-QG; Wed, 23 Nov 2022 16:28:08 +0000 Date: Wed, 23 Nov 2022 16:28:08 +0000 Message-ID: <86cz9doctj.wl-maz@kernel.org> From: Marc Zyngier To: AngeloGioacchino Del Regno Cc: tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, youlin.pei@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 3/4] irqchip: irq-mtk-cirq: Move register offsets to const array In-Reply-To: References: <20221123112249.98281-1-angelogioacchino.delregno@collabora.com> <20221123112249.98281-4-angelogioacchino.delregno@collabora.com> <86fse9ok3y.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: angelogioacchino.delregno@collabora.com, tglx@linutronix.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, youlin.pei@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221123_082813_988625_183A5D17 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 23 Nov 2022 14:57:02 +0000, AngeloGioacchino Del Regno wrote: > > >> + enum mtk_cirq_reg_index idx, > >> + unsigned int cirq_num) > > > > What does cirq_num mean for registers that are not relative to an > > interrupt? Create a separate helper for those. > > > Means literally nothing, so yes I agree, but... > > ... mtk_cirq_irq_reg(), mtk_cirq_reg() feels too similar and may lead to > confusion while reading the code. > > Any advice about a possibly clear-er name? I think the names are OK. Passing an interrupt number as a parameter is a good discriminant anyway. Please wait for a few days before posting the next version though. M. -- Without deviation from the norm, progress is not possible.