From: Loys Ollivier <lollivier@baylibre.com>
To: Johan Hovold <johan@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
Loys Ollivier <lollivier@baylibre.com>,
devicetree@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Kevin Hilman <khilman@baylibre.com>,
linux-amlogic@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding
Date: Mon, 11 Feb 2019 15:06:50 +0100 [thread overview]
Message-ID: <86o97iv2px.fsf@baylibre.com> (raw)
In-Reply-To: <20190211092251.GV4686@localhost>
On Mon 11 Feb 2019 at 09:22, Johan Hovold <johan@kernel.org> wrote:
> On Wed, Jan 30, 2019 at 09:50:16AM -0600, Rob Herring wrote:
>> On Mon, Jan 28, 2019 at 05:37:59PM +0100, Loys Ollivier wrote:
>> > Add binding for Mediatek-based GNSS receivers.
>> >
>> > Signed-off-by: Loys Ollivier <lollivier@baylibre.com>
>> > ---
>> >
>> > v3:
>> > Removed the I2C and SPI interfaces references.
>> > Removed the "mediatek,mt3339" compatible line.
>> > Added the optional propertied (reset, fix)
>> > Added the pin names for the optional properties.
>> >
>> > v2:
>> > Renamed bindings from Globaltop/gtop to Mediatek/mtk.
>> > Moved current-speed as an optional propertie.
>> > Removed the status line in the example.
>> > Added "mediatek,mt3339" compatible.
>> >
>> > .../devicetree/bindings/gnss/mediatek.txt | 37 ++++++++++++++++++++++
>> > 1 file changed, 37 insertions(+)
>> > create mode 100644 Documentation/devicetree/bindings/gnss/mediatek.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/gnss/mediatek.txt b/Documentation/devicetree/bindings/gnss/mediatek.txt
>> > new file mode 100644
>> > index 000000000000..00650d81c5c8
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/gnss/mediatek.txt
>> > @@ -0,0 +1,37 @@
>> > +Mediatek-based GNSS Receiver DT binding
>> > +
>> > +Mediatek chipsets are used in GNSS-receiver modules produced by several
>> > +vendors and can use an UART interface.
>
> s/an/a/
>
ok
>> > +
>> > +Please see Documentation/devicetree/bindings/gnss/gnss.txt for generic
>> > +properties.
>> > +
>> > +Required properties:
>> > +
>> > +- compatible : Must be
>> > +
>> > + "globaltop,pa6h"
>> > +
>> > +- vcc-supply : Main voltage regulator (pin name: VCC)
>> > +
>> > +Optional properties:
>> > +
>> > +- gtop,reset-gpios : GPIO used to reset the device
>> > + (pin name: RESET, NRESET)
>>
>> reset-gpios is the standard name.
>>
>> > +- gtop,fix-gpios : GPIO used to determine device position fix state
>> > + (pin name: FIX, 3D_FIX)
>
> I'm thinking we might need a standard name for fix-gpios as well. This
> isn't a feature that is globaltop (or mediatek) specific, and other
> manufacturers provide similar functionality through pins named UI_FIX,
> or even LCKIND (lock indicator).
>
> The pin is typically used to drive an indicator LED AFAIU, but the
> characteristics of the signal varies from device to device (fw to fw),
> for example, pulse when no lock and low otherwise, or pulse when a 2d or
> 3d-fix is acquired, etc.
>
Yes most GNSS recevivers provide a similar feature even if behavior of
the line differs.
> I'm not sure how useful the pulsing would be for software, but someone
> might find a use for it in some form.
>
Well it is useful to know when you start acquiring "valid" positionning
data. I'm using this as a trigger to start recording position.
> Rob, is this something we want to keep in the binding, and if so, how
> about using a generic name such as "gnss-fix-gpios"?
>
Name "gnss-fix-gpios" sounds good to me.
Loys
> Johan
--
-L
next prev parent reply other threads:[~2019-02-11 14:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 16:37 [PATCH v3 0/4] Add driver for Mediatek-based GNSS receivers Loys Ollivier
2019-01-28 16:37 ` [PATCH v3 1/4] dt-bindings: Add vendor prefix for "GlobalTop Technology, Inc." Loys Ollivier
2019-01-30 15:48 ` Rob Herring
2019-02-01 8:17 ` Loys Ollivier
2019-01-28 16:37 ` [PATCH v3 2/4] dt-bindings: gnss: add mediatek binding Loys Ollivier
2019-01-30 15:50 ` Rob Herring
2019-02-11 9:22 ` Johan Hovold
2019-02-11 14:06 ` Loys Ollivier [this message]
2019-02-13 9:34 ` Johan Hovold
2019-02-12 21:18 ` Rob Herring
2019-02-13 9:31 ` Johan Hovold
2019-01-28 16:38 ` [PATCH v3 3/4] gnss: add mtk receiver type support Loys Ollivier
2019-01-28 16:38 ` [PATCH v3 4/4] gnss: add driver for mediatek receivers Loys Ollivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o97iv2px.fsf@baylibre.com \
--to=lollivier@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).