* [PATCH v2 0/4] Add support for MediaTek MT8195 demo board @ 2022-03-27 20:03 Fabien Parent 2022-03-27 20:03 ` [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board Fabien Parent 2022-03-27 20:03 ` [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board Fabien Parent 0 siblings, 2 replies; 9+ messages in thread From: Fabien Parent @ 2022-03-27 20:03 UTC (permalink / raw) To: Matthias Brugger; +Cc: Fabien Parent, linux-arm-kernel, linux-mediatek This patch serie adds basic support for the MediaTek MT8195 demo board. For now the support is pretty basic and allow just to boot, use USB, and the SD card. When more IO support will be added for MT8195, new changes will be pushed to the device-tree of the MT8195 demo board to support these IOs as well. This serie depends on the following patches: [0] https://patchwork.kernel.org/project/linux-mediatek/patch/1622011927-359-9-git-send-email-hsin-hsiung.wang@mediatek.com/ [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220216113131.13145-4-tinghan.shen@mediatek.com/ Fabien Parent (4): dt-bindings: arm64: dts: mediatek: Add mt8195-demo board arm64: dts: mediatek: Add device-tree for MT8195 Demo board arm64: defconfig: enable MT6359 regulator driver arm64: defconfig: enable some mt6360 PMIC drivers .../devicetree/bindings/arm/mediatek.yaml | 1 + arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 ++++++++++++++++++ arch/arm64/configs/defconfig | 4 + 4 files changed, 453 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board 2022-03-27 20:03 [PATCH v2 0/4] Add support for MediaTek MT8195 demo board Fabien Parent @ 2022-03-27 20:03 ` Fabien Parent 2022-03-28 14:57 ` Krzysztof Kozlowski 2022-03-27 20:03 ` [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board Fabien Parent 1 sibling, 1 reply; 9+ messages in thread From: Fabien Parent @ 2022-03-27 20:03 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Sean Wang Cc: Fabien Parent, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek Add bindings for the MediaTek mt8195-demo board. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- v2: * move compatible next to the MT8195-EVB compatible Documentation/devicetree/bindings/arm/mediatek.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index ab0593c77321..024a45300da5 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -133,6 +133,7 @@ properties: - const: mediatek,mt8183 - items: - enum: + - mediatek,mt8195-demo - mediatek,mt8195-evb - const: mediatek,mt8195 - description: Google Burnet (HP Chromebook x360 11MK G3 EE) -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board 2022-03-27 20:03 ` [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board Fabien Parent @ 2022-03-28 14:57 ` Krzysztof Kozlowski 0 siblings, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2022-03-28 14:57 UTC (permalink / raw) To: Fabien Parent, Rob Herring, Krzysztof Kozlowski, Matthias Brugger, Sean Wang Cc: devicetree, linux-kernel, linux-arm-kernel, linux-mediatek On 27/03/2022 22:03, Fabien Parent wrote: > Add bindings for the MediaTek mt8195-demo board. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > v2: > * move compatible next to the MT8195-EVB compatible > > Documentation/devicetree/bindings/arm/mediatek.yaml | 1 + > 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-27 20:03 [PATCH v2 0/4] Add support for MediaTek MT8195 demo board Fabien Parent 2022-03-27 20:03 ` [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board Fabien Parent @ 2022-03-27 20:03 ` Fabien Parent 2022-03-28 13:47 ` AngeloGioacchino Del Regno 1 sibling, 1 reply; 9+ messages in thread From: Fabien Parent @ 2022-03-27 20:03 UTC (permalink / raw) To: Matthias Brugger, Rob Herring, Krzysztof Kozlowski Cc: Fabien Parent, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel Add basic device-tree for the MT8195 Demo board. The Demo board is made by MediaTek and has a MT8195 SoC, associated with the MT6359 and MT6360 PMICs, and the MT7921 connectivity chip. The IOs available on that board are: * 1 USB Type-C connector with DP aux mode support * 1 USB Type-A connector * 1 full size HDMI RX and 1 full size HDMI TX connector * 1 uSD slot * 40 pins header * SPI interface header * 1 M.2 slot * 1 audio jack * 1 micro-USB port for serial debug * 2 connectors for DSI displays * 3 connectors for CSI cameras * 1 connector for a eDP panel * 1 MMC storage This commit adds basic support in order to be able to boot. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- v2: * remove empty i2c nodes * remove empty spi node * remove unused pcie pinctrls * fixup node nodes to not contains underscore * rename mt6360 pmic node * move mmc1 node right after mmc0 node * use generic node name for gpio-keys * uniformize pinctrl node names arch/arm64/boot/dts/mediatek/Makefile | 1 + arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ 2 files changed, 448 insertions(+) create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile index 5da29e7223e4..c7d4636a2cb7 100644 --- a/arch/arm64/boot/dts/mediatek/Makefile +++ b/arch/arm64/boot/dts/mediatek/Makefile @@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8192-evb.dtb +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-demo.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8195-evb.dtb dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts new file mode 100644 index 000000000000..d94b4e01159a --- /dev/null +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts @@ -0,0 +1,447 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* + * Copyright (C) 2022 BayLibre, SAS. + * Author: Fabien Parent <fparent@baylibre.com> + */ +/dts-v1/; + +#include "mt8195.dtsi" +#include "mt6359.dtsi" + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/pinctrl/mt8195-pinfunc.h> +#include <dt-bindings/regulator/mediatek,mt6360-regulator.h> + +/ { + model = "MediaTek MT8195 demo board"; + compatible = "mediatek,mt8195-demo", "mediatek,mt8195"; + + aliases { + serial0 = &uart0; + }; + + chosen { + stdout-path = "serial0:921600n8"; + }; + + memory@40000000 { + device_type = "memory"; + reg = <0 0x40000000 0 0x80000000>; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + + /* 12 MiB reserved for OP-TEE (BL32) + * +-----------------------+ 0x43e0_0000 + * | SHMEM 2MiB | + * +-----------------------+ 0x43c0_0000 + * | | TA_RAM 8MiB | + * + TZDRAM +--------------+ 0x4340_0000 + * | | TEE_RAM 2MiB | + * +-----------------------+ 0x4320_0000 + */ + optee_reserved: optee@43200000 { + no-map; + reg = <0 0x43200000 0 0x00c00000>; + }; + + /* 192 KiB reserved for ARM Trusted Firmware (BL31) */ + bl31_secmon_reserved: secmon@54600000 { + no-map; + reg = <0 0x54600000 0x0 0x30000>; + }; + }; + + firmware { + optee { + compatible = "linaro,optee-tz"; + method = "smc"; + }; + }; + + gpio-keys { + compatible = "gpio-keys"; + input-name = "gpio-keys"; + pinctrl-names = "default"; + pinctrl-0 = <&gpio_keys_pins>; + + key-0 { + gpios = <&pio 106 GPIO_ACTIVE_LOW>; + label = "volume_up"; + linux,code = <KEY_VOLUMEUP>; + wakeup-source; + debounce-interval = <15>; + }; + }; +}; + +&uart0 { + pinctrl-names = "default"; + pinctrl-0 = <&uart0_pins>; + status = "okay"; +}; + +&mmc0 { + status = "okay"; + pinctrl-names = "default", "state_uhs"; + pinctrl-0 = <&mmc0_default_pins>; + pinctrl-1 = <&mmc0_uhs_pins>; + bus-width = <8>; + max-frequency = <200000000>; + cap-mmc-highspeed; + mmc-hs200-1_8v; + mmc-hs400-1_8v; + cap-mmc-hw-reset; + no-sdio; + no-sd; + hs400-ds-delay = <0x14c11>; + vmmc-supply = <&mt6359_vemc_1_ldo_reg>; + vqmmc-supply = <&mt6359_vufs_ldo_reg>; + non-removable; +}; + +&mmc1 { + pinctrl-names = "default", "state_uhs"; + pinctrl-0 = <&mmc1_default_pins>; + pinctrl-1 = <&mmc1_uhs_pins>; + cd-gpios = <&pio 129 GPIO_ACTIVE_LOW>; + bus-width = <4>; + max-frequency = <200000000>; + cap-sd-highspeed; + sd-uhs-sdr50; + sd-uhs-sdr104; + vmmc-supply = <&mt6360_ldo5>; + vqmmc-supply = <&mt6360_ldo3>; + status = "okay"; +}; + +&pmic { + interrupt-parent = <&pio>; + interrupts = <222 IRQ_TYPE_LEVEL_HIGH>; +}; + +&i2c6 { + clock-frequency = <400000>; + pinctrl-0 = <&i2c6_pins>; + pinctrl-names = "default"; + status = "okay"; + + mt6360: pmic@34 { + compatible = "mediatek,mt6360"; + reg = <0x34>; + interrupt-controller; + interrupt-parent = <&pio>; + interrupts = <101 IRQ_TYPE_EDGE_FALLING>; + interrupt-names = "IRQB"; + + charger { + compatible = "mediatek,mt6360-chg"; + richtek,vinovp-microvolt = <14500000>; + + otg_vbus_regulator: usb-otg-vbus-regulator { + regulator-compatible = "usb-otg-vbus"; + regulator-name = "usb-otg-vbus"; + regulator-min-microvolt = <4425000>; + regulator-max-microvolt = <5825000>; + }; + }; + + regulator { + compatible = "mediatek,mt6360-regulator"; + LDO_VIN3-supply = <&mt6360_buck2>; + + mt6360_buck1: buck1 { + regulator-compatible = "BUCK1"; + regulator-name = "mt6360,buck1"; + regulator-min-microvolt = <300000>; + regulator-max-microvolt = <1300000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP + MT6360_OPMODE_ULP>; + regulator-always-on; + }; + + mt6360_buck2: buck2 { + regulator-compatible = "BUCK2"; + regulator-name = "mt6360,buck2"; + regulator-min-microvolt = <300000>; + regulator-max-microvolt = <1300000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP + MT6360_OPMODE_ULP>; + regulator-always-on; + }; + + mt6360_ldo1: ldo1 { + regulator-compatible = "LDO1"; + regulator-name = "mt6360,ldo1"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <3600000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + }; + + mt6360_ldo2: ldo2 { + regulator-compatible = "LDO2"; + regulator-name = "mt6360,ldo2"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <3600000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + }; + + mt6360_ldo3: ldo3 { + regulator-compatible = "LDO3"; + regulator-name = "mt6360,ldo3"; + regulator-min-microvolt = <1200000>; + regulator-max-microvolt = <3600000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + }; + + mt6360_ldo5: ldo5 { + regulator-compatible = "LDO5"; + regulator-name = "mt6360,ldo5"; + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <3600000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + }; + + mt6360_ldo6: ldo6 { + regulator-compatible = "LDO6"; + regulator-name = "mt6360,ldo6"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <2100000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + }; + + mt6360_ldo7: ldo7 { + regulator-compatible = "LDO7"; + regulator-name = "mt6360,ldo7"; + regulator-min-microvolt = <500000>; + regulator-max-microvolt = <2100000>; + regulator-allowed-modes = <MT6360_OPMODE_NORMAL + MT6360_OPMODE_LP>; + regulator-always-on; + }; + }; + }; +}; + +&mt6359_vgpu11_buck_reg { + regulator-always-on; +}; + +&mt6359_vsram_others_ldo_reg { + regulator-always-on; +}; + +&mt6359_vpu_buck_reg { + regulator-always-on; +}; + +&mt6359_vcore_buck_reg { + regulator-always-on; +}; + +&mt6359_vproc1_buck_reg { + regulator-always-on; +}; + +&mt6359_vproc2_buck_reg { + regulator-always-on; +}; + +&mt6359_vsram_md_ldo_reg { + regulator-always-on; +}; + +&mt6359_vbbck_ldo_reg { + regulator-always-on; +}; + +&mt6359_vrf12_ldo_reg { + regulator-always-on; +}; + +&xhci0 { + vusb33-supply = <&mt6359_vusb_ldo_reg>; + vbus-supply = <&otg_vbus_regulator>; + status = "okay"; +}; + +&xhci1 { + vusb33-supply = <&mt6359_vusb_ldo_reg>; + status = "okay"; +}; + +&xhci2 { + vusb33-supply = <&mt6359_vusb_ldo_reg>; + status = "okay"; +}; + +&xhci3 { + vusb33-supply = <&mt6359_vusb_ldo_reg>; + status = "okay"; +}; + +&u3phy0 { + status = "okay"; +}; + +&u3phy1 { + status = "okay"; +}; + +&u3phy2 { + status = "okay"; +}; + +&u3phy3 { + status = "okay"; +}; + +&pio { + mmc0_default_pins: mmc0-default-pins { + pins-cmd-dat { + pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>, + <PINMUX_GPIO125__FUNC_MSDC0_DAT1>, + <PINMUX_GPIO124__FUNC_MSDC0_DAT2>, + <PINMUX_GPIO123__FUNC_MSDC0_DAT3>, + <PINMUX_GPIO119__FUNC_MSDC0_DAT4>, + <PINMUX_GPIO118__FUNC_MSDC0_DAT5>, + <PINMUX_GPIO117__FUNC_MSDC0_DAT6>, + <PINMUX_GPIO116__FUNC_MSDC0_DAT7>, + <PINMUX_GPIO121__FUNC_MSDC0_CMD>; + input-enable; + drive-strength = <MTK_DRIVE_6mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + + pin-clk { + pinmux = <PINMUX_GPIO122__FUNC_MSDC0_CLK>; + drive-strength = <MTK_DRIVE_6mA>; + bias-pull-down = <MTK_PUPD_SET_R1R0_10>; + }; + + pin-rst { + pinmux = <PINMUX_GPIO120__FUNC_MSDC0_RSTB>; + drive-strength = <MTK_DRIVE_6mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + }; + + mmc0_uhs_pins: mmc0-uhs-pins { + pins-cmd-dat { + pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>, + <PINMUX_GPIO125__FUNC_MSDC0_DAT1>, + <PINMUX_GPIO124__FUNC_MSDC0_DAT2>, + <PINMUX_GPIO123__FUNC_MSDC0_DAT3>, + <PINMUX_GPIO119__FUNC_MSDC0_DAT4>, + <PINMUX_GPIO118__FUNC_MSDC0_DAT5>, + <PINMUX_GPIO117__FUNC_MSDC0_DAT6>, + <PINMUX_GPIO116__FUNC_MSDC0_DAT7>, + <PINMUX_GPIO121__FUNC_MSDC0_CMD>; + input-enable; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + + pin-clk { + pinmux = <PINMUX_GPIO122__FUNC_MSDC0_CLK>; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-down = <MTK_PUPD_SET_R1R0_10>; + }; + + pin-ds { + pinmux = <PINMUX_GPIO127__FUNC_MSDC0_DSL>; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-down = <MTK_PUPD_SET_R1R0_10>; + }; + + pins-rst { + pinmux = <PINMUX_GPIO120__FUNC_MSDC0_RSTB>; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + }; + + mmc1_default_pins: mmc1-default-pins { + pins-cmd-dat { + pinmux = <PINMUX_GPIO110__FUNC_MSDC1_CMD>, + <PINMUX_GPIO112__FUNC_MSDC1_DAT0>, + <PINMUX_GPIO113__FUNC_MSDC1_DAT1>, + <PINMUX_GPIO114__FUNC_MSDC1_DAT2>, + <PINMUX_GPIO115__FUNC_MSDC1_DAT3>; + input-enable; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + + pins-clk { + pinmux = <PINMUX_GPIO111__FUNC_MSDC1_CLK>; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-down = <MTK_PUPD_SET_R1R0_10>; + }; + + pins-insert { + pinmux = <PINMUX_GPIO129__FUNC_GPIO129>; + bias-pull-up; + }; + }; + + mmc1_uhs_pins: mmc1-uhs-pins { + pins-cmd-dat { + pinmux = <PINMUX_GPIO110__FUNC_MSDC1_CMD>, + <PINMUX_GPIO112__FUNC_MSDC1_DAT0>, + <PINMUX_GPIO113__FUNC_MSDC1_DAT1>, + <PINMUX_GPIO114__FUNC_MSDC1_DAT2>, + <PINMUX_GPIO115__FUNC_MSDC1_DAT3>; + input-enable; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; + }; + + pins-clk { + pinmux = <PINMUX_GPIO111__FUNC_MSDC1_CLK>; + drive-strength = <MTK_DRIVE_8mA>; + bias-pull-down = <MTK_PUPD_SET_R1R0_10>; + }; + }; + + i2c6_pins: i2c6-pins { + pins { + pinmux = <PINMUX_GPIO25__FUNC_SDA6>, + <PINMUX_GPIO26__FUNC_SCL6>; + bias-pull-up; + mediatek,rsel = <MTK_PULL_SET_RSEL_111>; + }; + }; + + gpio_keys_pins: gpio-keys-pins { + pins { + pinmux = <PINMUX_GPIO106__FUNC_GPIO106>; + input-enable; + }; + }; + + uart0_pins: uart0-pins { + pins { + pinmux = <PINMUX_GPIO98__FUNC_UTXD0>, + <PINMUX_GPIO99__FUNC_URXD0>; + }; + }; + + uart1_pins: uart1-pins { + pins { + pinmux = <PINMUX_GPIO102__FUNC_UTXD1>, + <PINMUX_GPIO103__FUNC_URXD1>; + }; + }; +}; -- 2.35.1 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-27 20:03 ` [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board Fabien Parent @ 2022-03-28 13:47 ` AngeloGioacchino Del Regno 2022-03-28 14:41 ` Fabien Parent 0 siblings, 1 reply; 9+ messages in thread From: AngeloGioacchino Del Regno @ 2022-03-28 13:47 UTC (permalink / raw) To: Fabien Parent, Matthias Brugger, Rob Herring, Krzysztof Kozlowski Cc: linux-arm-kernel, linux-mediatek, devicetree, linux-kernel Il 27/03/22 22:03, Fabien Parent ha scritto: > Add basic device-tree for the MT8195 Demo board. The > Demo board is made by MediaTek and has a MT8195 SoC, > associated with the MT6359 and MT6360 PMICs, and > the MT7921 connectivity chip. > > The IOs available on that board are: > * 1 USB Type-C connector with DP aux mode support > * 1 USB Type-A connector > * 1 full size HDMI RX and 1 full size HDMI TX connector > * 1 uSD slot > * 40 pins header > * SPI interface header > * 1 M.2 slot > * 1 audio jack > * 1 micro-USB port for serial debug > * 2 connectors for DSI displays > * 3 connectors for CSI cameras > * 1 connector for a eDP panel > * 1 MMC storage > > This commit adds basic support in order to be able to boot. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > v2: > * remove empty i2c nodes > * remove empty spi node > * remove unused pcie pinctrls > * fixup node nodes to not contains underscore > * rename mt6360 pmic node > * move mmc1 node right after mmc0 node > * use generic node name for gpio-keys > * uniformize pinctrl node names > > arch/arm64/boot/dts/mediatek/Makefile | 1 + > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ > 2 files changed, 448 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts > ..snip.. > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > new file mode 100644 > index 000000000000..d94b4e01159a > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > @@ -0,0 +1,447 @@ ..snip.. > + > + gpio-keys { > + compatible = "gpio-keys"; > + input-name = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys_pins>; > + > + key-0 { key-volup is more descriptive, can you please change that? > + gpios = <&pio 106 GPIO_ACTIVE_LOW>; > + label = "volume_up"; > + linux,code = <KEY_VOLUMEUP>; > + wakeup-source; > + debounce-interval = <15>; > + }; > + }; > +}; > + ..snip.. > + > +&pmic { > + interrupt-parent = <&pio>; > + interrupts = <222 IRQ_TYPE_LEVEL_HIGH>; I would instead use interrupts-extended here: interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>; > +}; > + > +&i2c6 { > + clock-frequency = <400000>; > + pinctrl-0 = <&i2c6_pins>; > + pinctrl-names = "default"; > + status = "okay"; > + > + mt6360: pmic@34 { > + compatible = "mediatek,mt6360"; > + reg = <0x34>; > + interrupt-controller; > + interrupt-parent = <&pio>; > + interrupts = <101 IRQ_TYPE_EDGE_FALLING>; Same here > + interrupt-names = "IRQB"; > + ...snip... > + > +&pio { > + mmc0_default_pins: mmc0-default-pins { > + pins-cmd-dat { > + pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>, > + <PINMUX_GPIO125__FUNC_MSDC0_DAT1>, > + <PINMUX_GPIO124__FUNC_MSDC0_DAT2>, > + <PINMUX_GPIO123__FUNC_MSDC0_DAT3>, > + <PINMUX_GPIO119__FUNC_MSDC0_DAT4>, > + <PINMUX_GPIO118__FUNC_MSDC0_DAT5>, > + <PINMUX_GPIO117__FUNC_MSDC0_DAT6>, > + <PINMUX_GPIO116__FUNC_MSDC0_DAT7>, > + <PINMUX_GPIO121__FUNC_MSDC0_CMD>; > + input-enable; > + drive-strength = <MTK_DRIVE_6mA>; > + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; > + }; > + > + pin-clk { This is supposed to be "pins-clk", not "pin-clk"... same for all the other instances of the "pin-". Before pushing patches upstream, please run dtbs_check, as these are all mistakes that will be pointed out by that. Regards, Angelo _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-28 13:47 ` AngeloGioacchino Del Regno @ 2022-03-28 14:41 ` Fabien Parent 2022-03-28 14:50 ` AngeloGioacchino Del Regno 0 siblings, 1 reply; 9+ messages in thread From: Fabien Parent @ 2022-03-28 14:41 UTC (permalink / raw) To: AngeloGioacchino Del Regno Cc: Matthias Brugger, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 4180 bytes --] On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote: > Il 27/03/22 22:03, Fabien Parent ha scritto: > > Add basic device-tree for the MT8195 Demo board. The > > Demo board is made by MediaTek and has a MT8195 SoC, > > associated with the MT6359 and MT6360 PMICs, and > > the MT7921 connectivity chip. > > > > The IOs available on that board are: > > * 1 USB Type-C connector with DP aux mode support > > * 1 USB Type-A connector > > * 1 full size HDMI RX and 1 full size HDMI TX connector > > * 1 uSD slot > > * 40 pins header > > * SPI interface header > > * 1 M.2 slot > > * 1 audio jack > > * 1 micro-USB port for serial debug > > * 2 connectors for DSI displays > > * 3 connectors for CSI cameras > > * 1 connector for a eDP panel > > * 1 MMC storage > > > > This commit adds basic support in order to be able to boot. > > > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > > --- > > v2: > > * remove empty i2c nodes > > * remove empty spi node > > * remove unused pcie pinctrls > > * fixup node nodes to not contains underscore > > * rename mt6360 pmic node > > * move mmc1 node right after mmc0 node > > * use generic node name for gpio-keys > > * uniformize pinctrl node names > > > > arch/arm64/boot/dts/mediatek/Makefile | 1 + > > arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ > > 2 files changed, 448 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > > > ..snip.. > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > new file mode 100644 > > index 000000000000..d94b4e01159a > > --- /dev/null > > +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts > > @@ -0,0 +1,447 @@ > > ..snip.. > > > + > > + gpio-keys { > > + compatible = "gpio-keys"; > > + input-name = "gpio-keys"; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&gpio_keys_pins>; > > + > > + key-0 { > > key-volup is more descriptive, can you please change that? Which review should I follow, yours or the one from Krzysztof? Because both reviews are contradictory > > > + gpios = <&pio 106 GPIO_ACTIVE_LOW>; > > + label = "volume_up"; > > + linux,code = <KEY_VOLUMEUP>; > > + wakeup-source; > > + debounce-interval = <15>; > > + }; > > + }; > > +}; > > + > > ..snip.. > > > + > > +&pmic { > > + interrupt-parent = <&pio>; > > + interrupts = <222 IRQ_TYPE_LEVEL_HIGH>; > > I would instead use interrupts-extended here: > > interrupts-extended = <&pio 222 IRQ_TYPE_LEVEL_HIGH>; Thanks, it will be fixed in v3. > > > +}; > > + > > +&i2c6 { > > + clock-frequency = <400000>; > > + pinctrl-0 = <&i2c6_pins>; > > + pinctrl-names = "default"; > > + status = "okay"; > > + > > + mt6360: pmic@34 { > > + compatible = "mediatek,mt6360"; > > + reg = <0x34>; > > + interrupt-controller; > > + interrupt-parent = <&pio>; > > + interrupts = <101 IRQ_TYPE_EDGE_FALLING>; > > Same here Thanks, it will be fixed in v3. > > > + interrupt-names = "IRQB"; > > + > > ...snip... > > > + > > +&pio { > > + mmc0_default_pins: mmc0-default-pins { > > + pins-cmd-dat { > > + pinmux = <PINMUX_GPIO126__FUNC_MSDC0_DAT0>, > > + <PINMUX_GPIO125__FUNC_MSDC0_DAT1>, > > + <PINMUX_GPIO124__FUNC_MSDC0_DAT2>, > > + <PINMUX_GPIO123__FUNC_MSDC0_DAT3>, > > + <PINMUX_GPIO119__FUNC_MSDC0_DAT4>, > > + <PINMUX_GPIO118__FUNC_MSDC0_DAT5>, > > + <PINMUX_GPIO117__FUNC_MSDC0_DAT6>, > > + <PINMUX_GPIO116__FUNC_MSDC0_DAT7>, > > + <PINMUX_GPIO121__FUNC_MSDC0_CMD>; > > + input-enable; > > + drive-strength = <MTK_DRIVE_6mA>; > > + bias-pull-up = <MTK_PUPD_SET_R1R0_01>; > > + }; > > + > > + pin-clk { > > This is supposed to be "pins-clk", not "pin-clk"... same for all the other > instances of the "pin-". There is only one pin in that node, so it should be singular, no? > > Before pushing patches upstream, please run dtbs_check, as these are all > mistakes that will be pointed out by that. > > Regards, > Angelo > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 170 bytes --] _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-28 14:41 ` Fabien Parent @ 2022-03-28 14:50 ` AngeloGioacchino Del Regno 2022-03-28 15:02 ` Krzysztof Kozlowski 2022-04-01 14:13 ` Mattijs Korpershoek 0 siblings, 2 replies; 9+ messages in thread From: AngeloGioacchino Del Regno @ 2022-03-28 14:50 UTC (permalink / raw) To: Fabien Parent Cc: Matthias Brugger, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel Il 28/03/22 16:41, Fabien Parent ha scritto: > On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote: >> Il 27/03/22 22:03, Fabien Parent ha scritto: >>> Add basic device-tree for the MT8195 Demo board. The >>> Demo board is made by MediaTek and has a MT8195 SoC, >>> associated with the MT6359 and MT6360 PMICs, and >>> the MT7921 connectivity chip. >>> >>> The IOs available on that board are: >>> * 1 USB Type-C connector with DP aux mode support >>> * 1 USB Type-A connector >>> * 1 full size HDMI RX and 1 full size HDMI TX connector >>> * 1 uSD slot >>> * 40 pins header >>> * SPI interface header >>> * 1 M.2 slot >>> * 1 audio jack >>> * 1 micro-USB port for serial debug >>> * 2 connectors for DSI displays >>> * 3 connectors for CSI cameras >>> * 1 connector for a eDP panel >>> * 1 MMC storage >>> >>> This commit adds basic support in order to be able to boot. >>> >>> Signed-off-by: Fabien Parent <fparent@baylibre.com> >>> --- >>> v2: >>> * remove empty i2c nodes >>> * remove empty spi node >>> * remove unused pcie pinctrls >>> * fixup node nodes to not contains underscore >>> * rename mt6360 pmic node >>> * move mmc1 node right after mmc0 node >>> * use generic node name for gpio-keys >>> * uniformize pinctrl node names >>> >>> arch/arm64/boot/dts/mediatek/Makefile | 1 + >>> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ >>> 2 files changed, 448 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> >> >> ..snip.. >> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> new file mode 100644 >>> index 000000000000..d94b4e01159a >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>> @@ -0,0 +1,447 @@ >> >> ..snip.. >> >>> + >>> + gpio-keys { >>> + compatible = "gpio-keys"; >>> + input-name = "gpio-keys"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&gpio_keys_pins>; >>> + >>> + key-0 { >> >> key-volup is more descriptive, can you please change that? > > Which review should I follow, yours or the one from Krzysztof? Because both reviews are contradictory > There are a lot of "vol-down", "vol-up" (etc) instances, lots of which are on Qualcomm device-trees... so I guess this is just about personal preference... Honestly, before sending my review I forgot to check Krzysztof's one (sorry!!), but I think that this kind of node names is highly subjective... at least, I am not aware of any rule about having to use "generic" names. Check Documentation/devicetree/bindings/input/gpio-keys.yaml - in the example, you can find "specific" node names, like: up { label = "GPIO Key UP"; In any case, as I said, it's my personal preference to have it named as something like "key-volup" or "vol-up" or .. a name that is describing the key, but, as a personal preference, it is nothing mandatory, not even from my side. If anyone else has reasons to disagree, shrug, it's fine :)) >> >>> + gpios = <&pio 106 GPIO_ACTIVE_LOW>; >>> + label = "volume_up"; >>> + linux,code = <KEY_VOLUMEUP>; >>> + wakeup-source; >>> + debounce-interval = <15>; >>> + }; >>> + }; >>> +}; _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-28 14:50 ` AngeloGioacchino Del Regno @ 2022-03-28 15:02 ` Krzysztof Kozlowski 2022-04-01 14:13 ` Mattijs Korpershoek 1 sibling, 0 replies; 9+ messages in thread From: Krzysztof Kozlowski @ 2022-03-28 15:02 UTC (permalink / raw) To: AngeloGioacchino Del Regno, Fabien Parent Cc: Matthias Brugger, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel On 28/03/2022 16:50, AngeloGioacchino Del Regno wrote: > Il 28/03/22 16:41, Fabien Parent ha scritto: >> On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote: >>> Il 27/03/22 22:03, Fabien Parent ha scritto: >>>> Add basic device-tree for the MT8195 Demo board. The >>>> Demo board is made by MediaTek and has a MT8195 SoC, >>>> associated with the MT6359 and MT6360 PMICs, and >>>> the MT7921 connectivity chip. >>>> >>>> The IOs available on that board are: >>>> * 1 USB Type-C connector with DP aux mode support >>>> * 1 USB Type-A connector >>>> * 1 full size HDMI RX and 1 full size HDMI TX connector >>>> * 1 uSD slot >>>> * 40 pins header >>>> * SPI interface header >>>> * 1 M.2 slot >>>> * 1 audio jack >>>> * 1 micro-USB port for serial debug >>>> * 2 connectors for DSI displays >>>> * 3 connectors for CSI cameras >>>> * 1 connector for a eDP panel >>>> * 1 MMC storage >>>> >>>> This commit adds basic support in order to be able to boot. >>>> >>>> Signed-off-by: Fabien Parent <fparent@baylibre.com> >>>> --- >>>> v2: >>>> * remove empty i2c nodes >>>> * remove empty spi node >>>> * remove unused pcie pinctrls >>>> * fixup node nodes to not contains underscore >>>> * rename mt6360 pmic node >>>> * move mmc1 node right after mmc0 node >>>> * use generic node name for gpio-keys >>>> * uniformize pinctrl node names >>>> >>>> arch/arm64/boot/dts/mediatek/Makefile | 1 + >>>> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ >>>> 2 files changed, 448 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>>> >>> >>> ..snip.. >>> >>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-demo.dts b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>>> new file mode 100644 >>>> index 000000000000..d94b4e01159a >>>> --- /dev/null >>>> +++ b/arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>>> @@ -0,0 +1,447 @@ >>> >>> ..snip.. >>> >>>> + >>>> + gpio-keys { >>>> + compatible = "gpio-keys"; >>>> + input-name = "gpio-keys"; >>>> + pinctrl-names = "default"; >>>> + pinctrl-0 = <&gpio_keys_pins>; >>>> + >>>> + key-0 { >>> >>> key-volup is more descriptive, can you please change that? >> >> Which review should I follow, yours or the one from Krzysztof? Because both reviews are contradictory >> > > There are a lot of "vol-down", "vol-up" (etc) instances, lots of which are on > Qualcomm device-trees... so I guess this is just about personal preference... > > Honestly, before sending my review I forgot to check Krzysztof's one (sorry!!), > but I think that this kind of node names is highly subjective... at least, I am > not aware of any rule about having to use "generic" names. Node names should be generic, not descriptive. See Devicetree specification: "The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model. If appropriate, the name should be one of the following choices: ... - keyboard - key - keys " I prefer key-0 but "volup-key" or "key-volup" could work too (but these are still specific, not generic). Using other DTS as examples is wrong, because most of submissions are wrong and almost half of my bindings and DTS reviews include that comment - generic node names. To be fair, most of my DTS contributions also contained specific node names till I learnt that rule... Anyway, it's not that important. :) Thanks for other changes in the DTS. > > Check Documentation/devicetree/bindings/input/gpio-keys.yaml - in the example, > you can find "specific" node names, like: > > up { > > label = "GPIO Key UP"; > > In any case, as I said, it's my personal preference to have it named as something > like "key-volup" or "vol-up" or .. a name that is describing the key, but, as a > personal preference, it is nothing mandatory, not even from my side. > > If anyone else has reasons to disagree, shrug, it's fine :)) Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board 2022-03-28 14:50 ` AngeloGioacchino Del Regno 2022-03-28 15:02 ` Krzysztof Kozlowski @ 2022-04-01 14:13 ` Mattijs Korpershoek 1 sibling, 0 replies; 9+ messages in thread From: Mattijs Korpershoek @ 2022-04-01 14:13 UTC (permalink / raw) To: Fabien Parent Cc: AngeloGioacchino Del Regno, Matthias Brugger, Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, linux-mediatek, devicetree, linux-kernel On lun., mars 28, 2022 at 16:50, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > Il 28/03/22 16:41, Fabien Parent ha scritto: >> On Mon, Mar 28, 2022 at 03:47:09PM +0200, AngeloGioacchino Del Regno wrote: >>> Il 27/03/22 22:03, Fabien Parent ha scritto: >>>> Add basic device-tree for the MT8195 Demo board. The >>>> Demo board is made by MediaTek and has a MT8195 SoC, >>>> associated with the MT6359 and MT6360 PMICs, and >>>> the MT7921 connectivity chip. >>>> >>>> The IOs available on that board are: >>>> * 1 USB Type-C connector with DP aux mode support >>>> * 1 USB Type-A connector >>>> * 1 full size HDMI RX and 1 full size HDMI TX connector >>>> * 1 uSD slot >>>> * 40 pins header >>>> * SPI interface header >>>> * 1 M.2 slot >>>> * 1 audio jack >>>> * 1 micro-USB port for serial debug >>>> * 2 connectors for DSI displays >>>> * 3 connectors for CSI cameras >>>> * 1 connector for a eDP panel >>>> * 1 MMC storage >>>> >>>> This commit adds basic support in order to be able to boot. >>>> >>>> Signed-off-by: Fabien Parent <fparent@baylibre.com> >>>> --- >>>> v2: >>>> * remove empty i2c nodes >>>> * remove empty spi node >>>> * remove unused pcie pinctrls >>>> * fixup node nodes to not contains underscore >>>> * rename mt6360 pmic node >>>> * move mmc1 node right after mmc0 node >>>> * use generic node name for gpio-keys >>>> * uniformize pinctrl node names >>>> >>>> arch/arm64/boot/dts/mediatek/Makefile | 1 + >>>> arch/arm64/boot/dts/mediatek/mt8195-demo.dts | 447 +++++++++++++++++++ >>>> 2 files changed, 448 insertions(+) >>>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-demo.dts >>>> Boot-tested to console on i1200-demo board. Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-04-01 14:15 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-03-27 20:03 [PATCH v2 0/4] Add support for MediaTek MT8195 demo board Fabien Parent 2022-03-27 20:03 ` [PATCH v2 1/4] dt-bindings: arm64: dts: mediatek: Add mt8195-demo board Fabien Parent 2022-03-28 14:57 ` Krzysztof Kozlowski 2022-03-27 20:03 ` [PATCH v2 2/4] arm64: dts: mediatek: Add device-tree for MT8195 Demo board Fabien Parent 2022-03-28 13:47 ` AngeloGioacchino Del Regno 2022-03-28 14:41 ` Fabien Parent 2022-03-28 14:50 ` AngeloGioacchino Del Regno 2022-03-28 15:02 ` Krzysztof Kozlowski 2022-04-01 14:13 ` Mattijs Korpershoek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).