From: Kalle Valo <kvalo@codeaurora.org>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
Roy Luo <royluo@google.com>, YF Luo <yf.luo@mediatek.com>,
Yiwei Chung <yiwei.chung@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
linux-wireless@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values
Date: Sun, 21 Jul 2019 13:28:18 +0300 [thread overview]
Message-ID: <877e8bsmv1.fsf@purkki.adurom.net> (raw)
In-Reply-To: <c83e14787bc86f8f8062e0aa44e03ef80c3fd38a.1563518381.git.ryder.lee@mediatek.com> (Ryder Lee's message of "Fri, 19 Jul 2019 14:55:36 +0800")
Ryder Lee <ryder.lee@mediatek.com> writes:
> Add initial values in mt7615_mcu_set_wmm() to cleanup setup flow.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
[...]
> -#define WMM_AIFS_SET BIT(0)
> -#define WMM_CW_MIN_SET BIT(1)
> -#define WMM_CW_MAX_SET BIT(2)
> -#define WMM_TXOP_SET BIT(3)
> +#define WMM_PARAM_SET GENMASK(3, 0)
I don't see how this is any better? IMHO you just hide what is the
meaning of each bit.
--
Kalle Valo
next prev parent reply other threads:[~2019-07-21 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee@mediatek.com>
[not found] ` <50d28c9b0f9e7d6b277d36fc93f55142d7535259.1563518381.git.ryder.lee-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-07-19 6:55 ` [PATCH 2/3] mt76: mt7615: add 4 WMM sets support Ryder Lee
[not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ@mail.gmail.com>
[not found] ` <CA+zupgwyz2hdVRmnGr+4vzeEfvTfxYkLmu6jD_jFNjrPAdbvCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-19 7:27 ` Ryder Lee
2019-07-19 6:55 ` [PATCH 3/3] mt76: mt7615: add cwmin/cwmax initial values Ryder Lee
2019-07-19 10:17 ` Ryder Lee
2019-07-21 10:28 ` Kalle Valo [this message]
2019-07-21 10:26 ` [PATCH 1/3] mt76: fix checkpatch warnings and errors Kalle Valo
2019-07-21 16:56 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e8bsmv1.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=yf.luo@mediatek.com \
--cc=yiwei.chung@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox