From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0BB1C2BA12 for ; Sat, 16 Sep 2023 19:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/zPwTVnbIqykq0xrJwLN9r6avPOKHnWBnlaBD7Ntd/o=; b=b/X6YN9Dq9c/GQ9y4h7lHaHgRy 3OYmNG4BRGDNBs5slQSSqp/ohMb4ytx+8OwI8t7Mv4SN1J8uETiNYj3P3uj+Ah8ovsszbVv5yQ7fn uVm7+HE8S+MOUa1VhOcv+YuJXhd1+YYb3x2v8ckQKU3JRiAU8KAGv0P6x4yFQV6SXclu381W+0Ljm cBLhfTKXtE7jNRGeiQIWE2LCf3zQKxr8ciGrKpPjMNW7tE+AuLzRz3LbX8Nm+Xfzfh17H7tQMWCAE WnerzRa9TBrzgtay5JazA2JrTL4nEWV5AouT6Ov5CJnWgkIAoJyV5TYCKGy2YZwrS3ACRxARPYipd n7U0DvZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qhbBb-00Cm6p-1Q; Sat, 16 Sep 2023 19:42:35 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qhbBX-00Cm4z-0f; Sat, 16 Sep 2023 19:42:32 +0000 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1694893343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zPwTVnbIqykq0xrJwLN9r6avPOKHnWBnlaBD7Ntd/o=; b=CUQAEeiOCW0UB0mZHKKbATmxrT7v104AXTk8BgIS3LnhJdkwcK31VIKNUWTyr5NJ5FDSAZ 1rUmkomzu0i8ra8Pr7MuVj6uXx2bx2AvsuHAsgoTtNXk1SlphGsF2Tko1c6bGtCosz+5D3 3LvB5+XWrTyiZslCvN25C026vuzPMwe37ifQkKb5hvuaQ1IXWgjVHVi1QG1ERhp6yVLoCG KEjXv3lRy4sKTNf9zIytvVhfEZiamkJbj8QmGaOgd3j5PMU/plPNL9TqQlN3PM7t/8qtdr r8HTYvNQEPG5ZOF1NNpsGWfBpFE4WC9xOJQFYPlGWWvKaI1nzHahesMl0GR2sw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1694893343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/zPwTVnbIqykq0xrJwLN9r6avPOKHnWBnlaBD7Ntd/o=; b=/s+j74ZDjoLeO5pQcnU/VyXRmqc0m+3/h/bRCXztbsATbbfdFH/5imwYhMMMSk+geHP+hf BWo+CyCuYQ4k1qBQ== To: Ilpo =?utf-8?Q?J=C3=A4rvinen?= Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial , Petr Mladek , Thomas Gleixner , LKML , Tobias Klauser , Thierry Reding , Joel Stanley , Andrew Jeffery , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, Al Cooper , Broadcom internal kernel review list , Tony Lindgren , Andy Shevchenko , Ilpo =?utf-8?Q?J=C3=A4rvinen?= , Florian Fainelli , Andrew Davis , Matthew Howell , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Johan Hovold , Matthias Brugger , AngeloGioacchino Del Regno , Chen-Yu Tsai , linux-mediatek@lists.infradead.org, Lukas Wunner , Matthias Schiffer , Arnd Bergmann , Kumaravel Thiagarajan , Tharun Kumar P , Russell King , "Maciej W. Rozycki" , Hongyu Xie , Jiamei Xie , Rob Herring , delisun , Lino Sanfilippo , Yangtao Li , Vineet Gupta , linux-snps-arc@lists.infradead.org, Richard Genoud , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Arend van Spriel , Christophe Leroy , Baruch Siach , Sherry Sun , Shenwei Wang , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Sergey Organov , Tom Rix , Marek Vasut , Karol Gugala , Mateusz Holenko , Gabriel Somlo , Vladimir Zapolskiy , Jacky Huang , Shan-Chun Hung , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Dmitry Rokosov , Lucas Tanure , linux-amlogic@lists.infradead.org, Taichi Sugaya , Takao Orito , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Morton , Andreas =?utf-8?Q?F=C3=A4rber?= , Manivannan Sadhasivam , linux-actions@lists.infradead.org, Xiongfeng Wang , Yuan Can , Michael Ellerman , Nicholas Piggin , linuxppc-dev@lists.ozlabs.org, linux-unisoc@lists.infradead.org, Kevin Cernekee , Krzysztof Kozlowski , Alim Akhtar , linux-samsung-soc@vger.kernel.org, Lukas Bulwahn , Lech Perczak , Hugo Villeneuve , Andy Shevchenko , Isaac True , Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org, Biju Das , Geert Uytterhoeven , Palmer Dabbelt , Paul Walmsley , Nick Hu , Ruan Jinjie , Samuel Holland , linux-riscv@lists.infradead.org, Orson Zhai , Baolin Wang , Chunyan Zhang , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , Valentin Caron , Sebastian Andrzej Siewior , linux-stm32@st-md-mailman.stormreply.com, "David S. Miller" , sparclinux@vger.kernel.org, Hammer Hsieh , Peter Korsgaard , Timur Tabi , Mukesh Ojha , Jonathan =?utf-8?Q?Neusch=C3=A4fer?= , Michal Simek Subject: Re: [PATCH tty v1 00/74] serial: wrappers for uart port lock In-Reply-To: <1446dc6-5ab0-629-45c8-3b7d8c76367d@linux.intel.com> References: <20230914183831.587273-1-john.ogness@linutronix.de> <1446dc6-5ab0-629-45c8-3b7d8c76367d@linux.intel.com> Date: Sat, 16 Sep 2023 21:48:14 +0206 Message-ID: <878r95nbvt.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230916_124231_535235_188833AA X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 2023-09-15, Ilpo J=C3=A4rvinen wrote: > Would this also be useful to enable printing to console while under > port's lock (by postponing the output until the lock is released)? > > E.g., 8250_dw.c has had this commented out since the dawn on time: > /* > * FIXME: this deadlocks if port->lock is already held > * dev_err(p->dev, "Couldn't set LCR to %d\n", value); > */ Yes, this will fix such issues. However, only for consoles that are converted to the new NBCON console type. Good news, the 8250 driver will be the flagship driver that is converted as part of the rework. So this particular issue will be solved then. I will try to remember this so that I can remove the FIXME in the series. Thanks for mentioning it. John