* [PATCH v4 00/20] remove I2C_CLASS_DDC support
@ 2023-11-20 21:46 Heiner Kallweit
2023-11-20 21:46 ` [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Heiner Kallweit @ 2023-11-20 21:46 UTC (permalink / raw)
To: Wolfram Sang, intel-gfx
Cc: linux-i2c, Heiner Kallweit, Jernej Skrabec, Jonas Karlman,
Laurent Pinchart, linux-fbdev, amd-gfx, linux-rockchip,
linux-arm-kernel, dri-devel, linux-kernel, Thomas Zimmermann,
Jocelyn Falempe, linux-sunxi, linux-mediatek, Sean Paul,
Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
v2:
- change tag in commit subject of patch 03
- add ack tags
v3:
- fix a compile error in patch 5
v4:
- more ack and review tags
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
drivers/gpu/drm/ast/ast_i2c.c | 1 -
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
drivers/gpu/drm/display/drm_dp_helper.c | 1 -
drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
drivers/video/fbdev/core/fb_ddc.c | 1 -
drivers/video/fbdev/cyber2000fb.c | 1 -
drivers/video/fbdev/i740fb.c | 1 -
drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
drivers/video/fbdev/s3fb.c | 1 -
drivers/video/fbdev/tdfxfb.c | 1 -
drivers/video/fbdev/tridentfb.c | 1 -
drivers/video/fbdev/via/via_i2c.c | 1 -
include/linux/i2c.h | 1 -
31 files changed, 9 insertions(+), 47 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support
2023-11-20 21:46 [PATCH v4 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
@ 2023-11-20 21:46 ` Heiner Kallweit
2023-11-21 8:58 ` [Intel-gfx] [PATCH v4 00/20] " Jani Nikula
2023-11-23 6:56 ` Thomas Zimmermann
2 siblings, 0 replies; 9+ messages in thread
From: Heiner Kallweit @ 2023-11-20 21:46 UTC (permalink / raw)
To: Wolfram Sang, Chun-Kuang Hu
Cc: linux-i2c, Heiner Kallweit, Philipp Zabel, David Airlie,
Daniel Vetter, Matthias Brugger, AngeloGioacchino Del Regno,
dri-devel, linux-mediatek, linux-kernel, linux-arm-kernel
After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
Class-based device auto-detection is a legacy mechanism and shouldn't
be used in new code. So we can remove this class completely now.
Preferably this series should be applied via the i2c tree.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index d675c954b..54e46e440 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name));
ddc->adap.owner = THIS_MODULE;
- ddc->adap.class = I2C_CLASS_DDC;
ddc->adap.algo = &mtk_hdmi_ddc_algorithm;
ddc->adap.retries = 3;
ddc->adap.dev.of_node = dev->of_node;
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-20 21:46 [PATCH v4 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-20 21:46 ` [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
@ 2023-11-21 8:58 ` Jani Nikula
2023-11-21 12:25 ` Heiner Kallweit
2023-11-23 6:56 ` Thomas Zimmermann
2 siblings, 1 reply; 9+ messages in thread
From: Jani Nikula @ 2023-11-21 8:58 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-fbdev, dri-devel, Yongqin Liu, Jernej Skrabec,
Marijn Suijten, Sumit Semwal, amd-gfx, linux-rockchip,
Xinwei Kong, linux-sunxi, Jonas Karlman, linux-arm-msm,
linux-mediatek, linux-arm-kernel, Jocelyn Falempe, linux-kernel,
linux-i2c, Thomas Zimmermann, John Stultz, Heiner Kallweit,
freedreno, Laurent Pinchart
On Mon, 20 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote:
> v4:
> - more ack and review tags
Please do not send new versions just to record the acks and
reviews. They should be added while applying the patches.
Thanks,
Jani.
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-21 8:58 ` [Intel-gfx] [PATCH v4 00/20] " Jani Nikula
@ 2023-11-21 12:25 ` Heiner Kallweit
0 siblings, 0 replies; 9+ messages in thread
From: Heiner Kallweit @ 2023-11-21 12:25 UTC (permalink / raw)
To: Jani Nikula, Wolfram Sang, intel-gfx
Cc: linux-fbdev, dri-devel, Yongqin Liu, Jernej Skrabec,
Marijn Suijten, Sumit Semwal, amd-gfx, linux-rockchip,
Xinwei Kong, linux-sunxi, Jonas Karlman, linux-arm-msm,
linux-mediatek, linux-arm-kernel, Jocelyn Falempe, linux-kernel,
linux-i2c, Thomas Zimmermann, John Stultz, freedreno,
Laurent Pinchart
On 21.11.2023 09:58, Jani Nikula wrote:
> On Mon, 20 Nov 2023, Heiner Kallweit <hkallweit1@gmail.com> wrote:
>> v4:
>> - more ack and review tags
>
> Please do not send new versions just to record the acks and
> reviews. They should be added while applying the patches.
>
Right, typically also patchwork interprets and shows A-b and R-b when
sent as a reply to a patch of the series. I sent a new version because
an A-b covered multiple patches and was sent as reply to the cover letter.
> Thanks,
> Jani.
>
Heiner
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-20 21:46 [PATCH v4 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-20 21:46 ` [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-21 8:58 ` [Intel-gfx] [PATCH v4 00/20] " Jani Nikula
@ 2023-11-23 6:56 ` Thomas Zimmermann
2023-11-23 7:16 ` Heiner Kallweit
2 siblings, 1 reply; 9+ messages in thread
From: Thomas Zimmermann @ 2023-11-23 6:56 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Jocelyn Falempe, linux-sunxi, linux-mediatek,
Sean Paul, Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
[-- Attachment #1.1: Type: text/plain, Size: 3059 bytes --]
Hi
Am 20.11.23 um 22:46 schrieb Heiner Kallweit:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> v2:
> - change tag in commit subject of patch 03
> - add ack tags
> v3:
> - fix a compile error in patch 5
> v4:
> - more ack and review tags
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
for the patches that don't already have my r-b.
Best regards
Thomas
>
> ---
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
> drivers/gpu/drm/ast/ast_i2c.c | 1 -
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
> drivers/video/fbdev/core/fb_ddc.c | 1 -
> drivers/video/fbdev/cyber2000fb.c | 1 -
> drivers/video/fbdev/i740fb.c | 1 -
> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
> drivers/video/fbdev/s3fb.c | 1 -
> drivers/video/fbdev/tdfxfb.c | 1 -
> drivers/video/fbdev/tridentfb.c | 1 -
> drivers/video/fbdev/via/via_i2c.c | 1 -
> include/linux/i2c.h | 1 -
> 31 files changed, 9 insertions(+), 47 deletions(-)
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-23 6:56 ` Thomas Zimmermann
@ 2023-11-23 7:16 ` Heiner Kallweit
2023-11-23 8:19 ` Thomas Zimmermann
0 siblings, 1 reply; 9+ messages in thread
From: Heiner Kallweit @ 2023-11-23 7:16 UTC (permalink / raw)
To: Thomas Zimmermann, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Jocelyn Falempe, linux-sunxi, linux-mediatek,
Sean Paul, Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
On 23.11.2023 07:56, Thomas Zimmermann wrote:
> Hi
>
> Am 20.11.23 um 22:46 schrieb Heiner Kallweit:
>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>> Class-based device auto-detection is a legacy mechanism and shouldn't
>> be used in new code. So we can remove this class completely now.
>>
>> Preferably this series should be applied via the i2c tree.
>>
>> v2:
>> - change tag in commit subject of patch 03
>> - add ack tags
>> v3:
>> - fix a compile error in patch 5
>> v4:
>> - more ack and review tags
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> for the patches that don't already have my r-b.
>
This refers to which patches of the series?
Patches 8, 16, 18 are the remaining ones w/o A-b or R-b.
> Best regards
> Thomas
>
Thanks, Heiner
>>
>> ---
>>
>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>> drivers/video/fbdev/cyber2000fb.c | 1 -
>> drivers/video/fbdev/i740fb.c | 1 -
>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>> drivers/video/fbdev/s3fb.c | 1 -
>> drivers/video/fbdev/tdfxfb.c | 1 -
>> drivers/video/fbdev/tridentfb.c | 1 -
>> drivers/video/fbdev/via/via_i2c.c | 1 -
>> include/linux/i2c.h | 1 -
>> 31 files changed, 9 insertions(+), 47 deletions(-)
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-23 7:16 ` Heiner Kallweit
@ 2023-11-23 8:19 ` Thomas Zimmermann
2023-11-23 8:34 ` Heiner Kallweit
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Zimmermann @ 2023-11-23 8:19 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Jocelyn Falempe, linux-sunxi, linux-mediatek,
Sean Paul, Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
[-- Attachment #1.1: Type: text/plain, Size: 4185 bytes --]
Hi
Am 23.11.23 um 08:16 schrieb Heiner Kallweit:
> On 23.11.2023 07:56, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit:
>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>> be used in new code. So we can remove this class completely now.
>>>
>>> Preferably this series should be applied via the i2c tree.
>>>
>>> v2:
>>> - change tag in commit subject of patch 03
>>> - add ack tags
>>> v3:
>>> - fix a compile error in patch 5
>>> v4:
>>> - more ack and review tags
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>
>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>> for the patches that don't already have my r-b.
>>
> This refers to which patches of the series?
> Patches 8, 16, 18 are the remaining ones w/o A-b or R-b.
I've looked through the patchset. Feel free to add my a-b to patches 1
to 19; except for 2 and 17, which already have my r-b.
BTW I only received 19 patches. is there a patch 20/20?
Best regards
Thomas
>
>> Best regards
>> Thomas
>>
> Thanks, Heiner
>
>>>
>>> ---
>>>
>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>> drivers/video/fbdev/i740fb.c | 1 -
>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>> drivers/video/fbdev/s3fb.c | 1 -
>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>> drivers/video/fbdev/tridentfb.c | 1 -
>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>> include/linux/i2c.h | 1 -
>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-23 8:19 ` Thomas Zimmermann
@ 2023-11-23 8:34 ` Heiner Kallweit
2023-11-23 8:52 ` Thomas Zimmermann
0 siblings, 1 reply; 9+ messages in thread
From: Heiner Kallweit @ 2023-11-23 8:34 UTC (permalink / raw)
To: Thomas Zimmermann, Wolfram Sang, intel-gfx
Cc: linux-i2c, Jernej Skrabec, Jonas Karlman, Laurent Pinchart,
linux-fbdev, amd-gfx, linux-rockchip, linux-arm-kernel, dri-devel,
linux-kernel, Jocelyn Falempe, linux-sunxi, linux-mediatek,
Sean Paul, Marijn Suijten, linux-arm-msm, freedreno, Xinwei Kong,
Sumit Semwal, Yongqin Liu, John Stultz
On 23.11.2023 09:19, Thomas Zimmermann wrote:
> Hi
>
> Am 23.11.23 um 08:16 schrieb Heiner Kallweit:
>> On 23.11.2023 07:56, Thomas Zimmermann wrote:
>>> Hi
>>>
>>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit:
>>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>>> be used in new code. So we can remove this class completely now.
>>>>
>>>> Preferably this series should be applied via the i2c tree.
>>>>
>>>> v2:
>>>> - change tag in commit subject of patch 03
>>>> - add ack tags
>>>> v3:
>>>> - fix a compile error in patch 5
>>>> v4:
>>>> - more ack and review tags
>>>>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>
>>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>>
>>> for the patches that don't already have my r-b.
>>>
>> This refers to which patches of the series?
>> Patches 8, 16, 18 are the remaining ones w/o A-b or R-b.
>
> I've looked through the patchset. Feel free to add my a-b to patches 1 to 19; except for 2 and 17, which already have my r-b.
>
> BTW I only received 19 patches. is there a patch 20/20?
>
Yes, see here:
https://patchwork.ozlabs.org/project/linux-i2c/patch/20231120214624.9378-21-hkallweit1@gmail.com/
If you're subscribed to linux-i2c or linux-kernel list you should have received it.
> Best regards
> Thomas
>
>>
>>> Best regards
>>> Thomas
>>>
>> Thanks, Heiner
>>
>>>>
>>>> ---
>>>>
>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>>> drivers/video/fbdev/i740fb.c | 1 -
>>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>>> drivers/video/fbdev/s3fb.c | 1 -
>>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>>> drivers/video/fbdev/tridentfb.c | 1 -
>>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>>> include/linux/i2c.h | 1 -
>>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>
>>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v4 00/20] remove I2C_CLASS_DDC support
2023-11-23 8:34 ` Heiner Kallweit
@ 2023-11-23 8:52 ` Thomas Zimmermann
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Zimmermann @ 2023-11-23 8:52 UTC (permalink / raw)
To: Heiner Kallweit, Wolfram Sang, intel-gfx
Cc: Yongqin Liu, freedreno, linux-fbdev, Jernej Skrabec,
Jocelyn Falempe, Jonas Karlman, linux-arm-msm, dri-devel,
John Stultz, linux-kernel, amd-gfx, Sumit Semwal, linux-rockchip,
Xinwei Kong, linux-mediatek, Laurent Pinchart, Marijn Suijten,
Sean Paul, linux-sunxi, linux-arm-kernel, linux-i2c
[-- Attachment #1.1: Type: text/plain, Size: 4917 bytes --]
Hi
Am 23.11.23 um 09:34 schrieb Heiner Kallweit:
> On 23.11.2023 09:19, Thomas Zimmermann wrote:
>> Hi
>>
>> Am 23.11.23 um 08:16 schrieb Heiner Kallweit:
>>> On 23.11.2023 07:56, Thomas Zimmermann wrote:
>>>> Hi
>>>>
>>>> Am 20.11.23 um 22:46 schrieb Heiner Kallweit:
>>>>> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
>>>>> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
>>>>> Class-based device auto-detection is a legacy mechanism and shouldn't
>>>>> be used in new code. So we can remove this class completely now.
>>>>>
>>>>> Preferably this series should be applied via the i2c tree.
>>>>>
>>>>> v2:
>>>>> - change tag in commit subject of patch 03
>>>>> - add ack tags
>>>>> v3:
>>>>> - fix a compile error in patch 5
>>>>> v4:
>>>>> - more ack and review tags
>>>>>
>>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>
>>>> Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
>>>>
>>>> for the patches that don't already have my r-b.
>>>>
>>> This refers to which patches of the series?
>>> Patches 8, 16, 18 are the remaining ones w/o A-b or R-b.
>>
>> I've looked through the patchset. Feel free to add my a-b to patches 1 to 19; except for 2 and 17, which already have my r-b.
>>
>> BTW I only received 19 patches. is there a patch 20/20?
>>
> Yes, see here:
> https://patchwork.ozlabs.org/project/linux-i2c/patch/20231120214624.9378-21-hkallweit1@gmail.com/
> If you're subscribed to linux-i2c or linux-kernel list you should have received it.
I see, I'm not on these lists. I don't have the authority to ack that
final patch, but let me know if you want to merge anything through the
DRM trees.
Best regards
Thomas
>
>> Best regards
>> Thomas
>>
>>>
>>>> Best regards
>>>> Thomas
>>>>
>>> Thanks, Heiner
>>>
>>>>>
>>>>> ---
>>>>>
>>>>> drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 -
>>>>> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 -
>>>>> drivers/gpu/drm/ast/ast_i2c.c | 1 -
>>>>> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 -
>>>>> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
>>>>> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
>>>>> drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 -
>>>>> drivers/gpu/drm/gma500/intel_gmbus.c | 1 -
>>>>> drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 -
>>>>> drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 -
>>>>> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 -
>>>>> drivers/gpu/drm/i915/display/intel_gmbus.c | 1 -
>>>>> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 -
>>>>> drivers/gpu/drm/loongson/lsdc_i2c.c | 1 -
>>>>> drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 -
>>>>> drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 -
>>>>> drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 -
>>>>> drivers/gpu/drm/radeon/radeon_i2c.c | 1 -
>>>>> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
>>>>> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
>>>>> drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 -
>>>>> drivers/video/fbdev/core/fb_ddc.c | 1 -
>>>>> drivers/video/fbdev/cyber2000fb.c | 1 -
>>>>> drivers/video/fbdev/i740fb.c | 1 -
>>>>> drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++----------
>>>>> drivers/video/fbdev/matrox/i2c-matroxfb.c | 12 ++++--------
>>>>> drivers/video/fbdev/s3fb.c | 1 -
>>>>> drivers/video/fbdev/tdfxfb.c | 1 -
>>>>> drivers/video/fbdev/tridentfb.c | 1 -
>>>>> drivers/video/fbdev/via/via_i2c.c | 1 -
>>>>> include/linux/i2c.h | 1 -
>>>>> 31 files changed, 9 insertions(+), 47 deletions(-)
>>>>
>>>
>>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-11-23 8:52 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-20 21:46 [PATCH v4 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-20 21:46 ` [PATCH v4 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-21 8:58 ` [Intel-gfx] [PATCH v4 00/20] " Jani Nikula
2023-11-21 12:25 ` Heiner Kallweit
2023-11-23 6:56 ` Thomas Zimmermann
2023-11-23 7:16 ` Heiner Kallweit
2023-11-23 8:19 ` Thomas Zimmermann
2023-11-23 8:34 ` Heiner Kallweit
2023-11-23 8:52 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).