From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5638AC6FD20 for ; Fri, 24 Mar 2023 13:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oT+acvdU6eO+amZb5hvogxi4+aOhqk3FEjsaaJ0DV7c=; b=TE1W/0vyuONs8ZVL/E8jN3j2MN fzvCNSHKMBspVL6rFoobpCLhh+mB23QVz/2+tNjWD/pWlXrEYngLHGSaNqYXjeF1lLS+Gu4mk0wqj 07l+BgCMHj35qmL1G6AF0N83PnEdbwKwMSLVlnsTM5iaF4RCaB4Y4dDVBd36TTzPPR+zGMzJxBccb gCGqQjMk5MHKLfRMgtURYLfeEemdo3w76r2TIy3qND4QLg7uvrZy+kexE2v+OmWRGsG51rOhRp/me t7nRzCyqoyuN76tOD0cHGqzEuBqp/AK5lHZemJCMYHSd/bEYZRfnRO8h9eh2usT6cAJzUIVAzKAQ5 kp1MYVxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfhAx-004Rn9-1Z; Fri, 24 Mar 2023 13:09:47 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfhAu-004RWO-1i for linux-mediatek@lists.infradead.org; Fri, 24 Mar 2023 13:09:45 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id B303418837C2; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id ACC3F2500B57; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id A23749B403F4; Fri, 24 Mar 2023 13:07:21 +0000 (UTC) X-Screener-Id: e32ae469fa6e394734d05373d3a705875723cf1e Received: from fujitsu (2-104-116-184-cable.dk.customer.tdc.net [2.104.116.184]) by smtp.gigahost.dk (Postfix) with ESMTPSA id B3AEB9B403E2; Fri, 24 Mar 2023 13:07:20 +0000 (UTC) From: Hans Schultz To: Ido Schimmel Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , "maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER" , Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , AngeloGioacchino Del Regno , Claudiu Manoil , Alexandre Belloni , =?utf-8?Q?Cl=C3=A9ment_L=C3=A9ger?= , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Christian Marangi , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" , "moderated list:ETHERNET BRIDGE" , "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: [PATCH v2 net-next 1/6] net: bridge: add dynamic flag to switchdev notifier In-Reply-To: References: <20230318141010.513424-1-netdev@kapio-technology.com> <20230318141010.513424-2-netdev@kapio-technology.com> Date: Fri, 24 Mar 2023 14:04:45 +0100 Message-ID: <87h6ua5mhe.fsf@kapio-technology.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230324_060944_712794_BDF994DE X-CRM114-Status: UNSURE ( 9.87 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Mar 20, 2023 at 10:48, Ido Schimmel wrote: > > I was under the impression that the consensus was to rename this to > 'is_static' so that it is consistent with other flags. > I think the consensus was that the bridge maintainers would decide if it should be changed, this according to Oltean. I still think that is_dyn is more secure codewise in the long run and it is logical as that is what the feature the flag concerns. When you say consistent with other flags, I don't understand the inconsistency. Could you please explain.