From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH 04/11] mt76x0: usb files Date: Mon, 23 Jul 2018 12:07:30 +0300 Message-ID: <87pnzexqul.fsf@codeaurora.org> References: <1530771142-4118-1-git-send-email-sgruszka@redhat.com> <1530771142-4118-5-git-send-email-sgruszka@redhat.com> <20180705150519.GB17524@localhost.localdomain> <87va96tq1g.fsf@purkki.adurom.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Lorenzo Bianconi's message of "Mon, 23 Jul 2018 10:57:02 +0200") Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lorenzo Bianconi Cc: Stanislaw Gruszka , linux-wireless , Felix Fietkau , Hans Ulli Kroll , Jakub Kicinski , Michal Schmidt , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org Lorenzo Bianconi writes: >> >> Lorenzo Bianconi writes: >> >> > On Jul 05, Stanislaw Gruszka wrote: >> >> Add usb files of mt76x0 driver. >> >> >> >> Signed-off-by: Stanislaw Gruszka >> >> [...] >> >> >> +static int mt76x0_suspend(struct usb_interface *usb_intf, pm_message_t state) >> >> +{ >> >> + struct mt76x0_dev *dev = usb_get_intfdata(usb_intf); >> >> + >> >> + mt76x0_cleanup(dev); >> > >> > Is it necessary to deallocate rx queue here in case of a system suspend? >> >> BTW it would really helpful to others if you could edit your quotes. It >> takes some time to find your oneliner from a 450 line message. > > Ack sorry, I will be more verbose next time :). I think you misunderstood, I actually was asking to be less verbose :) The oneliner was just fine. I was just suggesting that instead of sending a message with 400 lines trim the unnecessary quotation and just send a shorter 50 line message. That way you save a lot of time (and avoid frustration) for the people reading your mail. -- Kalle Valo