From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEC81C7EE30 for ; Tue, 28 Feb 2023 19:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UflYxWroEtmK39RAVwEkBjNlTv8uQehwxdDrnHocUV4=; b=zaVcpzhX8zKwsfGPdoZINRrVvv 0KrvH6V+HSPBQEDQKolbvtbgkd47j/ukogBv9oFkKbTd9AF2Gv1xoxaTt4lqsvD9MKL80KtRkI3GS nwEM1N1EO7khM+waEXiW2wuBYKxLbVCgcRIbPKga3iPQq9hUSHkTAkZ1HCnaW/4wE0gkA1Hu6Ypf8 hPlCno+iKmJJNMscqm+o7P5Ar3Sic9MTAZppE5LtT2eDFnzcAVu/+nfk+q/LN4UufzDNckVHy1M6/ 9VOl/Ut1QRcNN88skxhq1xMOZH/Wc/gxISoyIzwLs1t+GIesqAg9mYOgylcAY9GDX/F4HmwyLO4q/ WX295XrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pX5fU-00E5y5-Et; Tue, 28 Feb 2023 19:29:44 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pX5fJ-00E5vP-A3; Tue, 28 Feb 2023 19:29:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E3D11B80EBB; Tue, 28 Feb 2023 19:29:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31534C433D2; Tue, 28 Feb 2023 19:29:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677612570; bh=0crKvCVlXbQHhK0hVWeeHPbKSkNSrZfsAg93hhclvLM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UNZCZ9i3h0qhD6hHIVtloCYpkml4NRcDwkYhv9GrwZhRoMVsjYVzI0cArMQfbQZN+ LGFYbMx//Vw8HzeO6pCa2sBQ7dvrE4OZXbjWLikHI/na99+mwGxICloB0BrRpaPLc6 SJCN2i2Yp0CkGa+DfifrRT0TpGXqeYwUZdT/XSi5LiOFxipFLqnKoXQ3iBVI9tKSOP +ZHA6zHA8GPGlTtHOeWsrSqGchf0eL6NoT0smo67O6Si4L/jUbyIPlzYvac4CJlal5 3wVvuVfPOYy5jorgt6+nRECC6NKpdkZY/cj/RWy5u9nMWojGXEf1kigzCt727/LZ07 DrYjbjQzW024w== Received: from [47.176.216.2] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pX5fD-00Dv1i-Eb; Tue, 28 Feb 2023 19:29:27 +0000 Date: Tue, 28 Feb 2023 19:29:20 +0000 Message-ID: <87r0u9h9m7.wl-maz@kernel.org> From: Marc Zyngier To: Randy Dunlap Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, MyungJoo Ham , Chanwoo Choi , Donggeun Kim , Philipp Zabel , Peter Rosin , Greg Kroah-Hartman , Geert Uytterhoeven , Rob Herring , Eddie Huang , Sean Wang , Matthias Brugger , Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 0/3] IRQ_DOMAIN: remove all "depends on", use only "select" In-Reply-To: <6bb7bca5-e663-60c4-d574-9a4856cdb802@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> <8e6977b8-d256-4e51-82b7-e36d6ca259dc@infradead.org> <86y1p0xbqd.wl-maz@kernel.org> <6bb7bca5-e663-60c4-d574-9a4856cdb802@infradead.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 47.176.216.2 X-SA-Exim-Rcpt-To: rdunlap@infradead.org, arnd@arndb.de, linux-kernel@vger.kernel.org, myungjoo.ham@samsung.com, cw00.choi@samsung.com, dg77.kim@samsung.com, p.zabel@pengutronix.de, peda@axentia.se, gregkh@linuxfoundation.org, geert@linux-m68k.org, robh@kernel.org, eddie.huang@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230228_112933_655921_98AAC924 X-CRM114-Status: GOOD ( 41.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 23 Feb 2023 18:37:01 +0000, Randy Dunlap wrote: > > Hi Marc, > > On 2/14/23 11:56, Marc Zyngier wrote: > > On Tue, 14 Feb 2023 18:30:54 +0000, > > Randy Dunlap wrote: > >> > >> > >> > >> On 2/13/23 00:05, Arnd Bergmann wrote: > >>> On Mon, Feb 13, 2023, at 05:15, Randy Dunlap wrote: > >>>> IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set > >>>> it directly thru "make *config", so drivers should select it instead > >>>> of depending on it if they need it. > >>>> Relying on it being set for a dependency is risky. > >>>> > >>>> Consistently using "select" or "depends on" can also help reduce > >>>> Kconfig circular dependency issues. > >>>> > >>>> IRQ_DOMAIN is selected 109 times and is depended on 3 times in > >>>> current linux-next. Eliminate the uses of "depends on" by > >>>> converting them to "select". > >>>> > >>>> [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it > >>>> [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it > >>>> [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it > >>> > >>> From a Kconfig perspective, your reasoning makes a lot of sense. > >>> > >>> Looking at the bigger picture, I wonder if we should just remove the > >>> option and make it unconditional. It is enabled in ever architecture > >>> defconfig other than alpha and sparc, and it's selected by a lot of > >>> very common options such as I2C, GENERIC_MSI_IRQ, GENERIC_IRQ_CHIP, > >>> and PCI_HOST_GENERIC. Enabling the option on Alpha grows the kernel > >>> image from 9010KB to 9023KB, or on m68k Coldfire from 3346KB to > >>> 3351KB. > >> > >> Marc, what do you think about this suggestion? > > > > Seems sensible enough to me. > > > > I'd also get rid of the IRQ_DOMAIN_HIERARCHY option, which is used by > > a ton of things. Architectures that are not using it are either dead, > > or at least terminally comatose. > > > > I'm half-tempted to put the following patch into -next. Maybe after > > -rc1 though. And then the option can go as well. > > > > M. > > What is this patch based on? It doesn't apply cleanly to current linux-next. Not very surprising, I usually base my stuff on a stable rc tag. But in this instance, it may have been based on whatever was in my sandbox at that point in time, and subsequently discarded. > I made a similar patch (to linux-next) that drops the IRQ_DOMAIN_HIERARCHY > option and converts its dependent code to always on. > It has been built (multiple randconfigs) on all ARCHes (except hexagon), > both 32-bit and 64-bit where applicable (not that it should matter here). > > But yes, let's plan to get one of these patches in soon (after -rc1). Please send it based on -rc1 once it is out, and I'll be happy to stick that in -next for further simmering. Thanks, M. -- Without deviation from the norm, progress is not possible.