* [next v2] wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config
@ 2023-10-30 7:17 Deren Wu
2023-11-08 17:58 ` [next,v2] " Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Deren Wu @ 2023-10-30 7:17 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi, Kalle Valo
Cc: Sean Wang, Soul Huang, Ming Yen Hsieh, Leon Yen, Eric-SY Chang,
KM Lin, Robin Chiu, CH Yeh, Posh Sun, Stella Chang, Quan Zhou,
Ryder Lee, Shayne Chen, Ben Greear, linux-wireless,
linux-mediatek, Deren Wu
From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
No matter CLC is enabled or disabled, the driver should initialize
the default value 0xff for channel configuration of CLC. Otherwise,
the zero value would disable channels.
Reported-and-tested-by: Ben Greear <greearb@candelatech.com>
Closes: https://lore.kernel.org/all/2fb78387-d226-3193-8ca7-90040561b9ad@candelatech.com/
Fixes: 09382d8f8641 ("mt7921: update the channel usage when the regd domain changed")
Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
Signed-off-by: Deren Wu <deren.wu@mediatek.com>
---
v2:
* v1 is missing in wireless patchwork and lore.kernel.org.
* update title and message to make issue description clear
---
drivers/net/wireless/mediatek/mt76/mt7921/mcu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
index 63f3d4a5c9aa..2cc2d2788f83 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mcu.c
@@ -375,6 +375,7 @@ static int mt7921_load_clc(struct mt792x_dev *dev, const char *fw_name)
int ret, i, len, offset = 0;
u8 *clc_base = NULL, hw_encap = 0;
+ dev->phy.clc_chan_conf = 0xff;
if (mt7921_disable_clc ||
mt76_is_usb(&dev->mt76))
return 0;
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [next,v2] wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config
2023-10-30 7:17 [next v2] wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config Deren Wu
@ 2023-11-08 17:58 ` Kalle Valo
2023-11-08 18:10 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Kalle Valo @ 2023-11-08 17:58 UTC (permalink / raw)
To: Deren Wu
Cc: Felix Fietkau, Lorenzo Bianconi, Sean Wang, Soul Huang,
Ming Yen Hsieh, Leon Yen, Eric-SY Chang, KM Lin, Robin Chiu,
CH Yeh, Posh Sun, Stella Chang, Quan Zhou, Ryder Lee, Shayne Chen,
Ben Greear, linux-wireless, linux-mediatek, Deren Wu
Deren Wu <deren.wu@mediatek.com> wrote:
> From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
>
> No matter CLC is enabled or disabled, the driver should initialize
> the default value 0xff for channel configuration of CLC. Otherwise,
> the zero value would disable channels.
>
> Reported-and-tested-by: Ben Greear <greearb@candelatech.com>
> Closes: https://lore.kernel.org/all/2fb78387-d226-3193-8ca7-90040561b9ad@candelatech.com/
> Fixes: 09382d8f8641 ("wifi: mt76: mt7921: update the channel usage when the regd domain changed")
> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
Patch applied to wireless.git, thanks.
7a934b5cc3f4 wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config
--
https://patchwork.kernel.org/project/linux-wireless/patch/5a976ddf1f636b5cb809373501d3cfdc6d8de3e4.1698648737.git.deren.wu@mediatek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [next,v2] wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config
2023-11-08 17:58 ` [next,v2] " Kalle Valo
@ 2023-11-08 18:10 ` Kalle Valo
0 siblings, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-11-08 18:10 UTC (permalink / raw)
To: Deren Wu
Cc: Felix Fietkau, Lorenzo Bianconi, Sean Wang, Soul Huang,
Ming Yen Hsieh, Leon Yen, Eric-SY Chang, KM Lin, Robin Chiu,
CH Yeh, Posh Sun, Stella Chang, Quan Zhou, Ryder Lee, Shayne Chen,
Ben Greear, linux-wireless, linux-mediatek
Kalle Valo <kvalo@kernel.org> writes:
> Deren Wu <deren.wu@mediatek.com> wrote:
>
>> From: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
>>
>> No matter CLC is enabled or disabled, the driver should initialize
>> the default value 0xff for channel configuration of CLC. Otherwise,
>> the zero value would disable channels.
>>
>> Reported-and-tested-by: Ben Greear <greearb@candelatech.com>
>> Closes: https://lore.kernel.org/all/2fb78387-d226-3193-8ca7-90040561b9ad@candelatech.com/
>> Fixes: 09382d8f8641 ("wifi: mt76: mt7921: update the channel usage when the regd domain changed")
>> Signed-off-by: Ming Yen Hsieh <mingyen.hsieh@mediatek.com>
>> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
>
> Patch applied to wireless.git, thanks.
>
> 7a934b5cc3f4 wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config
BTW the fixes tag didn't use correct title and I fixed it during commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-08 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-30 7:17 [next v2] wifi: mt76: mt7921: fix 6GHz disabled by the missing default CLC config Deren Wu
2023-11-08 17:58 ` [next,v2] " Kalle Valo
2023-11-08 18:10 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).