linux-mediatek.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"V sujith kumar Reddy" <Vsujithkumar.Reddy@amd.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Gaosheng Cui" <cuigaosheng1@huawei.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Mohan Kumar" <mkumard@nvidia.com>,
	"Geoff Levand" <geoff@infradead.org>,
	"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Vijendar Mukunda" <Vijendar.Mukunda@amd.com>,
	"syed saba kareem" <syed.sabakareem@amd.com>,
	"Mario Limonciello" <mario.limonciello@amd.com>,
	"Meng Tang" <tangmeng@uniontech.com>,
	"Martin Povišer" <povik+lin@cutebit.org>,
	"Codrin Ciubotariu" <codrin.ciubotariu@microchip.com>,
	"Peter Rosin" <peda@axentia.se>, "Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"Allison Randal" <allison@lohutok.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
	"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"James Schulman" <james.schulman@cirrus.com>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Lucas Tanure" <tanureal@opensource.cirrus.com>,
	"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Banajit Goswami" <bgoswami@quicinc.com>,
	"Miaoqian Lin" <linmq006@gmail.com>,
	"Colin Ian King" <colin.i.king@gmail.com>,
	"Aidan MacDonald" <aidanmacdonald.0x0@gmail.com>,
	"Zhang Qilong" <zhangqilong3@huawei.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	"Liang He" <windhl@126.com>,
	"Shengjiu Wang" <shengjiu.wang@gmail.com>,
	"Xiubo Li" <Xiubo.Lee@gmail.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Yang Yingliang" <yangyingliang@huawei.com>,
	"Minghao Chi" <chi.minghao@zte.com.cn>,
	"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
	"Bard Liao" <yung-chuan.liao@linux.intel.com>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Cezary Rojewski" <cezary.rojewski@intel.com>,
	"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
	"Peter Ujfalusi" <peter.ujfalusi@linux.intel.com>,
	"Ranjani Sridharan" <ranjani.sridharan@linux.intel.com>,
	"Akihiko Odaki" <akihiko.odaki@gmail.com>,
	"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Moises Cardona" <moisesmcardona@gmail.com>,
	"Zhen Ni" <nizhen@uniontech.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Andrey Turkin" <andrey.turkin@gmail.com>,
	"Muralidhar Reddy" <muralidhar.reddy@intel.com>,
	"Zhu Ning" <zhuning0077@gmail.com>,
	"Gongjun Song" <gongjun.song@intel.com>,
	"Shuming Fan" <shumingf@realtek.com>,
	"Yong Zhi" <yong.zhi@intel.com>,
	"Lior Amsalem" <alior@marvell.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Hezi Shahmoon" <hezi@marvell.com>,
	"Neta Zur Hershkovits" <neta@marvell.com>,
	"Marcin Wojtas" <mw@semihalf.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Jiasheng Jiang" <jiasheng@iscas.ac.cn>,
	"Ricardo Ribalda" <ribalda@chromium.org>,
	"Trevor Wu" <trevor.wu@mediatek.com>,
	"Dan Carpenter" <error27@gmail.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Nicolas Frattaroli" <frattaroli.nicolas@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	"Sylwester Nawrocki" <s.nawrocki@samsung.com>,
	"Linh Phung" <linh.phung.jy@renesas.com>,
	"Shang XiaoJing" <shangxiaojing@huawei.com>,
	"Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"Biju Das" <biju.das.jz@bp.renesas.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Olivier Moysan" <olivier.moysan@foss.st.com>,
	"Arnaud Pouliquen" <arnaud.pouliquen@foss.st.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Mikhail Rudenko" <mike.rudenko@gmail.com>,
	"Li Chen" <lchen@ambarella.com>,
	"Ban Tao" <fengzheng923@gmail.com>,
	"Sameer Pujar" <spujar@nvidia.com>,
	YueHaibing <yuehaibing@huawei.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Li kunyu" <kunyu@nfschina.com>,
	"Peter Ujfalusi" <peter.ujfalusi@gmail.com>,
	"Jarkko Nikula" <jarkko.nikula@bitmer.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>,
	alsa-devel@alsa-project.org, kernel@pengutronix.de,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	linuxppc-dev@lists.ozlabs.org, asahi@lists.linux.dev,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	patches@opensource.cirrus.com,
	"Fabio Estevam" <festevam@gmail.com>,
	"Nicolin Chen" <nicoleotsuka@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	linux-mediatek@lists.infradead.org,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	linux-amlogic@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-omap@vger.kernel.org,
	linux-xtensa@linux-xtensa.org
Subject: Re: [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void
Date: Thu, 16 Mar 2023 10:32:08 +0100	[thread overview]
Message-ID: <87ttylhwiv.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de>

On Wed, 15 Mar 2023 16:04:52 +0100,
Uwe Kleine-König wrote:
> 
> Hello,
> 
> this series adapts the platform drivers below sound/ to use the .remove_new()
> callback. Compared to the traditional .remove() callback .remove_new() returns
> no value. This is a good thing because the driver core doesn't (and cannot)
> cope for errors during remove. The only effect of a non-zero return value in
> .remove() is that the driver core emits a warning. The device is removed anyhow
> and an early return from .remove() usually yields a resource leak.
> 
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
> 
> The first two patches simplify a driver each to return zero unconditionally,
> and then all drivers are trivially converted to .remove_new().
> 
> There are nearly no interdependencies in this patch set---only 1 <- 11 and
> 2 <- 16. So even if some individual problems are found (I don't expect that),
> the other patches can (and from my POV should) still be applied.
> 
> Best regards
> Uwe
> 
> Uwe Kleine-König (173):
(snip)

For the whole series,

Acked-by: Takashi Iwai <tiwai@suse.de>


thanks,

Takashi


  parent reply	other threads:[~2023-03-16  9:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 15:04 [PATCH 000/173] ALSA/ASoC: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-15 15:06 ` [PATCH 106/173] ASoC: mediatek: mtk-btcvsd: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 107/173] ASoC: mediatek: mt2701-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 108/173] ASoC: mediatek: mt6797-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 109/173] ASoC: mediatek: mt8173-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 110/173] ASoC: mediatek: mt8183-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 111/173] ASoC: mediatek: mt8188-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-16 10:12   ` Trevor Wu (吳文良)
2023-03-15 15:06 ` [PATCH 112/173] ASoC: mediatek: mt8192-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-15 15:06 ` [PATCH 113/173] ASoC: mediatek: mt8195-afe-pcm: " Uwe Kleine-König
2023-03-16  8:42   ` AngeloGioacchino Del Regno
2023-03-16  9:32 ` Takashi Iwai [this message]
2023-03-21 16:50 ` (subset) [PATCH 000/173] ALSA/ASoC: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttylhwiv.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=Vsujithkumar.Reddy@amd.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=aidanmacdonald.0x0@gmail.com \
    --cc=akihiko.odaki@gmail.com \
    --cc=alexander.sverdlin@gmail.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alior@marvell.com \
    --cc=allison@lohutok.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=andrew@lunn.ch \
    --cc=andrey.turkin@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnaud.pouliquen@foss.st.com \
    --cc=arnd@arndb.de \
    --cc=asahi@lists.linux.dev \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgoswami@quicinc.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=chi.minghao@zte.com.cn \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=christophe.leroy@csgroup.eu \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=codrin.ciubotariu@microchip.com \
    --cc=colin.i.king@gmail.com \
    --cc=cuigaosheng1@huawei.com \
    --cc=daniel@zonque.org \
    --cc=david.rhodes@cirrus.com \
    --cc=error27@gmail.com \
    --cc=fengzheng923@gmail.com \
    --cc=festevam@gmail.com \
    --cc=frattaroli.nicolas@gmail.com \
    --cc=geoff@infradead.org \
    --cc=gongjun.song@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=hdegoede@redhat.com \
    --cc=heiko@sntech.de \
    --cc=hezi@marvell.com \
    --cc=james.schulman@cirrus.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=jbrunet@baylibre.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jernej.skrabec@gmail.com \
    --cc=jiapeng.chong@linux.alibaba.com \
    --cc=jiasheng@iscas.ac.cn \
    --cc=jonathanh@nvidia.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=kunyu@nfschina.com \
    --cc=lchen@ambarella.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=linh.phung.jy@renesas.com \
    --cc=linmq006@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-xtensa@linux-xtensa.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mario.limonciello@amd.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mhiramat@kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=mike.rudenko@gmail.com \
    --cc=mkumard@nvidia.com \
    --cc=moisesmcardona@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=muralidhar.reddy@intel.com \
    --cc=mw@semihalf.com \
    --cc=neil.armstrong@linaro.org \
    --cc=neta@marvell.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=nicoleotsuka@gmail.com \
    --cc=nizhen@uniontech.com \
    --cc=npiggin@gmail.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=olivier.moysan@foss.st.com \
    --cc=orsonzhai@gmail.com \
    --cc=patches@opensource.cirrus.com \
    --cc=peda@axentia.se \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@gmail.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=povik+lin@cutebit.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=rf@opensource.cirrus.com \
    --cc=ribalda@chromium.org \
    --cc=rjui@broadcom.com \
    --cc=robert.jarzmik@free.fr \
    --cc=s.hauer@pengutronix.de \
    --cc=s.nawrocki@samsung.com \
    --cc=samuel@sholland.org \
    --cc=sbranden@broadcom.com \
    --cc=shangxiaojing@huawei.com \
    --cc=shawnguo@kernel.org \
    --cc=shengjiu.wang@gmail.com \
    --cc=shumingf@realtek.com \
    --cc=spujar@nvidia.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=syed.sabakareem@amd.com \
    --cc=tangmeng@uniontech.com \
    --cc=tanureal@opensource.cirrus.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    --cc=trevor.wu@mediatek.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wens@csie.org \
    --cc=windhl@126.com \
    --cc=yangyingliang@huawei.com \
    --cc=yong.zhi@intel.com \
    --cc=yuehaibing@huawei.com \
    --cc=yung-chuan.liao@linux.intel.com \
    --cc=zhang.lyra@gmail.com \
    --cc=zhangqilong3@huawei.com \
    --cc=zhuning0077@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).