From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v1 02/11] drm: drop uapi dependency from drm_print.h Date: Mon, 29 Jul 2019 15:45:35 +0300 Message-ID: <87tvb5nh5c.fsf@intel.com> References: <20190718161507.2047-1-sam@ravnborg.org> <20190718161507.2047-3-sam@ravnborg.org> <156346840026.24728.936589728458336617@skylake-alporthouse-com> <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <460bf1e1-a38b-5f79-26e5-93764067f4e1@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "Koenig, Christian" , Chris Wilson , Intel Graphics Development , Sam Ravnborg , "dri-devel@lists.freedesktop.org" Cc: Boris Brezillon , David Airlie , Daniel Vetter , Liviu Dudau , Maxime Ripard , "linux-mediatek@lists.infradead.org" , Thomas Zimmermann , Matthias Brugger , Sean Paul , Thierry Reding , Sean Paul , "linux-arm-kernel@lists.infradead.org" List-Id: linux-mediatek@lists.infradead.org On Fri, 19 Jul 2019, "Koenig, Christian" wrote: > Am 18.07.19 um 18:46 schrieb Chris Wilson: >> Quoting Sam Ravnborg (2019-07-18 17:14:58) >>> drm_print.h used DRM_NAME - thus adding a dependency from >>> include/drm/drm_print.h => uapi/drm/drm.h >>> >>> Hardcode the name "drm" to break this dependency. >>> The idea is that there shall be a minimal dependency >>> between include/drm/* and uapi/* >>> >>> Signed-off-by: Sam Ravnborg >>> Suggested-by: Daniel Vetter >>> Reviewed-by: Daniel Vetter >>> Cc: Maarten Lankhorst >>> Cc: Maxime Ripard >>> Cc: Sean Paul >>> Cc: David Airlie >>> Cc: Rob Clark >>> Cc: Sean Paul >>> Cc: Chris Wilson >>> Cc: Daniel Vetter >>> --- >>> include/drm/drm_print.h | 4 +--- >>> 1 file changed, 1 insertion(+), 3 deletions(-) >>> >>> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h >>> index a5d6f2f3e430..760d1bd0eaf1 100644 >>> --- a/include/drm/drm_print.h >>> +++ b/include/drm/drm_print.h >>> @@ -32,8 +32,6 @@ >>> #include >>> #include >>> >>> -#include >>> - >>> /** >>> * DOC: print >>> * >>> @@ -287,7 +285,7 @@ void drm_err(const char *format, ...); >>> /* Macros to make printk easier */ >>> >>> #define _DRM_PRINTK(once, level, fmt, ...) \ >>> - printk##once(KERN_##level "[" DRM_NAME "] " fmt, ##__VA_ARGS__) >>> + printk##once(KERN_##level "[drm] " fmt, ##__VA_ARGS__) >> I guess I'm th only one who >> >> #undef DRM_NAME >> #define DRM_NAME i915 >> >> just so that I didn't have inane logs? >> >> One might suggest that instead of hardcoding it, follow the pr_fmt() >> pattern and only add "[drm]" for the drm core. >> >> Even then it so useless (which drm driver is this message for???) that I >> want to remove them all :( > > Yeah, agree. I mean it is nice if the core drm functions use a prefix > for debug output. > > But I actually don't see the point for individual drivers. We should all migrate to the versions with device... BR, Jani. > > Christian. > >> -Chris > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center