From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D581DC07E9D for ; Tue, 27 Sep 2022 10:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uHfk9aMzPHZFkszeo32pmWcdDEHKglYDlW6aDVizdnI=; b=ljA+NhtD6eKKzxCC1oCqYPMkIf WzJw1M0lvesqAP2KEj8/SdinKewDUa2GRR5AEo5w9NzAu1pt50mfekpv45WrHb309w3MwpiArdtlz iVqrH8kHzu82c8du1HSKO5iSYRvpmNXmCG3cC4uYpLr0nespmW6PUc9jzKgTMlnz7OVaHOZdLDuzT hRPIxEmgK1wdXCOFJkQ8l7owQr4MOr1MZ+3dc/a3e69CFxlseYy2GaRiuNaQoIVB4aXJsr8mikfZh 7m3oi0Sr6vS180neYlK96aY0TKJsDd1k4pkKJdNYL0qduM8bTh2sHPqzyVQVrH+SLRnIy/xYfI9aB UO6Ak9LA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1od85O-009x2d-Oz; Tue, 27 Sep 2022 10:45:10 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1od856-009wvY-SH; Tue, 27 Sep 2022 10:44:54 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 125C96602265; Tue, 27 Sep 2022 11:44:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664275491; bh=ql4FTrakdy7CCJMp7yH+mwWBCOP+cR85Z8Ogp0SyhfQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YPYx0ZrExlZHMAFeo/WtOFIN8CcQcAPdKHAiMl1HxB5TXBC535cZvTs8W0xZmK7lF +/fdeD6qWM1p33efR/YpUjibMzM/k+mXVg953aKxQoHBf3ct9lB+bdNBnX8rkNaDBt pvJSrvGB21cdSfH3GXqwjlfKa16GfaGZ0vWXv9RKA9HAbodUKHphgiLLph2VDaHa4c NLufBwh57PaWEyCzJclqmsBDDpq3HIG9jJJ463q+whX3ILocQY9HucQGgeTT/tI8SI PQLcAyKBWa3BXTAou5taxGv4uNP7qbv2RhHaATsbjTM9gJ5XkxZ1fV/4/q6TB0UFS3 nlwmyFZSQbVhg== Message-ID: <888703a8-a8e5-e691-7a53-294f88ad7a4e@collabora.com> Date: Tue, 27 Sep 2022 12:44:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v5 4/4] net: stmmac: Update the name of property 'clk_csr' Content-Language: en-US To: Jianguo Zhang , Krzysztof Kozlowski , "David S . Miller" , Rob Herring , Krzysztof Kozlowski Cc: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Matthias Brugger , Biao Huang , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220923052828.16581-1-jianguo.zhang@mediatek.com> <20220923052828.16581-5-jianguo.zhang@mediatek.com> <4f205f0d-420d-8f51-ad26-0c2475c0decd@linaro.org> <80c59c9462955037981a1eab6409ba69fc9b7c34.camel@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <80c59c9462955037981a1eab6409ba69fc9b7c34.camel@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220927_034453_072420_E6256E12 X-CRM114-Status: GOOD ( 15.93 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Il 27/09/22 10:44, Jianguo Zhang ha scritto: > Dear Krzysztof, > Thanks for your comment. > > On Fri, 2022-09-23 at 20:15 +0200, Krzysztof Kozlowski wrote: >> On 23/09/2022 20:14, Krzysztof Kozlowski wrote: >>>> This is going to break MT2712e on old devicetrees. >>>> >>>> The right way of doing that is to check the return value of >>>> of_property_read_u32() >>>> for "snps,clk-csr": if the property is not found, fall back to >>>> the old "clk_csr". >>> >>> I must admit - I don't care. That's the effect when submitter >>> bypasses >>> DT bindings review (81311c03ab4d ("net: ethernet: stmmac: add >>> management >>> of clk_csr property")). >>> >>> If anyone wants ABI, please document the properties. >>> >>> If out-of-tree users complain, please upstream your DTS or do not >>> use >>> undocumented features... >>> >> >> OTOH, as Angelo pointed out, handling old and new properties is quite >> easy to achieve, so... :) >> > So, the conclusion is as following: > > 1. add new property 'snps,clk-csr' and document it in binding file. > 2. parse new property 'snps,clk-csr' firstly, if failed, fall back to > old property 'clk_csr' in driver. > > Is my understanding correct? Yes, please. I think that bindings should also get a 'clk_csr' with deprecated: true, but that's Krzysztof's call. Regards, Angelo > >> Best regards, >> Krzysztof >> > BRS > Jianguo >