From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80F4ECCFA05 for ; Thu, 6 Nov 2025 14:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+lYBRtKJ91fQKAJrUYHxIxb8csyygTiAg1aUJtcDymw=; b=pBH2acXPA0KU4LQhNjbIRRCtnr FsDJm7ldXm9KpMjSySxNzpPIWq/SnelBjNzNOR5ghNNxRxgmQSmxI7WwPK/pCmU9MXcItOqJBbqR5 nYcSr79/sWOEdpRViM99zz/xgEkY77yJg+1GkYuo/PkdhcrL+O/DRW/OARPyua8z7vWnLwXjfpivC lR2CunfACHpp4Z40ICmoglL80AdhjaSnjppXsHQFNc0Zmd/ur3imtiFV64sCM0BoL3qHdun0N3dQp jW5s1vXmpSEROduCQJex+JAVrrigqj+dSBW5xbVWiLkmZpEiW9nQ7FxkSg0mjlzbO5PLRUynDn1qC E2HP0AtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH1Fw-0000000FjBx-46Lw; Thu, 06 Nov 2025 14:46:33 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vH1Fu-0000000FjBA-2ruf; Thu, 06 Nov 2025 14:46:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1762440387; bh=dGOlyZRnTXRalBcuIplk4eH5kRwlh1SL2I9sgliJA7c=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Lw+gF5MQXFFl9ynmcctABtq3k21bUx5HiAupg4ybdkPoF/NQil2aqKCXeAshG/8mK qMlQdBNo+XZcPao+2NcGO4If6Eaf0uKx35SVnN3+w7GxG73Icp1bjh8vtXW1BbJ27S iPNHUWbtXlC4cB76egMk8Azv9k8CBpfsId0fYRLLU8u61uV+yWvS/NqNoeoYqhI221 p1EMlLumWtsFPo3OP2gvGryIHlzHRnYz9lUGqXLvKkVJ+ntASTFyd2Yz2tG/DJl4tR 3NEmcVuQUH4xVU6lYrKPAJo3t9h68XahX5lMPmmNTelgQ1PGnPlaYSTxDyfGuIrWBL 4x9BV88PLBBuA== Received: from [IPv6:2606:6d00:11:ef24::c41] (unknown [IPv6:2606:6d00:11:ef24::c41]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nicolas) by bali.collaboradmins.com (Postfix) with ESMTPSA id DB48C17E0CA1; Thu, 6 Nov 2025 15:46:24 +0100 (CET) Message-ID: <899fb4c2ce292bcce4caeb6cf6f38744c449e8e9.camel@collabora.com> Subject: Re: [PATCH v5 5/8] media: mediatek: vcodec: fix vp9 4096x2176 fail for profile2 From: Nicolas Dufresne To: Kyrie Wu , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Hans Verkuil , Nathan Hebert , Arnd Bergmann , Irui Wang , George Sun , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Yilong Zhou Cc: Neil Armstrong , Andrzej Pietrasiewicz Date: Thu, 06 Nov 2025 09:46:22 -0500 In-Reply-To: <20251106061323.2193-6-kyrie.wu@mediatek.com> References: <20251106061323.2193-1-kyrie.wu@mediatek.com> <20251106061323.2193-6-kyrie.wu@mediatek.com> Autocrypt: addr=nicolas.dufresne@collabora.com; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0J05pY29sYXMgRHVmcmVzbmUgPG5pY29sYXNAbmR1ZnJlc25lLmNhPoicBBMWCgBEAhsDBQsJCA cCAiICBhUKCQgLAgQWAgMBAh4HAheABQkJZfd1FiEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrjo CGQEACgkQ2UGUUSlgcvQlQwD/RjpU1SZYcKG6pnfnQ8ivgtTkGDRUJ8gP3fK7+XUjRNIA/iXfhXMN abIWxO2oCXKf3TdD7aQ4070KO6zSxIcxgNQFtDFOaWNvbGFzIER1ZnJlc25lIDxuaWNvbGFzLmR1Z nJlc25lQGNvbGxhYm9yYS5jb20+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4 AWIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyyxgUJCWX3dQAKCRDZQZRRKWBy9ARJAP96pFmLffZ smBUpkyVBfFAf+zq6BJt769R0al3kHvUKdgD9G7KAHuioxD2v6SX7idpIazjzx8b8rfzwTWyOQWHC AAS0LU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAZ21haWwuY29tPoiZBBMWCgBBF iEE7w1SgRXEw8IaBG8S2UGUUSlgcvQFAmibrGYCGwMFCQll93UFCwkIBwICIgIGFQoJCAsCBBYCAw ECHgcCF4AACgkQ2UGUUSlgcvRObgD/YnQjfi4+L8f4fI7p1pPMTwRTcaRdy6aqkKEmKsCArzQBAK8 bRLv9QjuqsE6oQZra/RB4widZPvphs78H0P6NmpIJ Organization: Collabora Canada Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RJXZVmVnlFQ3K2q8dvWW" User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251106_064630_912670_D3BF1971 X-CRM114-Status: GOOD ( 20.53 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org --=-RJXZVmVnlFQ3K2q8dvWW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Le jeudi 06 novembre 2025 =C3=A0 14:13 +0800, Kyrie Wu a =C3=A9crit=C2=A0: > The dram addr of vp9 decoder tile number, which use dram mode > to set tile information, may reach to 36bits for 4096x2176. > It needs to get the highest 4bit of tile buffer address to > set tile buffer address. Please rework that commit message. Perhaps: The DRAM address of the VP9 decoder mode info (MI) buffers may require as much as 36bits for 4096x2176 resolution. Fold the 4 most significant bits into the lower (padding) four bits of address. >=20 > Fixes: 5d418351ca8f1 ("media: mediatek: vcodec: support stateless VP9 dec= oding") >=20 > Signed-off-by: Kyrie Wu > Reviewed-by: AngeloGioacchino Del Regno > --- > =C2=A0.../mediatek/vcodec/decoder/vdec/vdec_vp9_req_lat_if.c=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9= _req_lat_if.c b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp= 9_req_lat_if.c > index d966914db4b9..91c563c049bd 100644 > --- a/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_la= t_if.c > +++ b/drivers/media/platform/mediatek/vcodec/decoder/vdec/vdec_vp9_req_la= t_if.c > @@ -1156,7 +1156,10 @@ static int vdec_vp9_slice_setup_tile_buffer:q(stru= ct vdec_vp9_slice_instance *inst > =C2=A0 tiles->size[i][j] =3D size; > =C2=A0 if (tiles->mi_rows[i]) { > =C2=A0 *tb++ =3D (size << 3) + ((offset << 3) & 0x7f); > - *tb++ =3D pa & ~0xf; > + *tb =3D pa & ~0xf; > + if (IS_ENABLED(CONFIG_ARCH_DMA_ADDR_T_64BIT)) > + *tb |=3D (pa >> 32) & 0xf; > + tb++; You are following the style here, so no complaints, though the macros GENMASK(3, 0) instead of 0xf and GENMASK(31, 4) instead of ~0xf is another = way to write this code. Since this is not always obvious when the alignment padding of an address i= s being reused to extend the number of bits of an address, it would be nice i= f you add a comment explaining in words what his is doing. cheers, Nicolas > =C2=A0 *tb++ =3D (pa << 3) & 0x7f; > =C2=A0 mi_row =3D (tiles->mi_rows[i] - 1) & 0x1ff; > =C2=A0 mi_col =3D (tiles->mi_cols[j] - 1) & 0x3f; --=-RJXZVmVnlFQ3K2q8dvWW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaQy0vgAKCRDZQZRRKWBy 9L2NAQC5CFyK0h7cwfX3f6U15ujRa3Ls59ivxET4FMGkhDKXOwEAnBWXXu23j4ET ZmbIdwMT3KVsp0HnznoqU3/1OIsg7QI= =MdCW -----END PGP SIGNATURE----- --=-RJXZVmVnlFQ3K2q8dvWW--