From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Justin Swartz <justin.swartz@risingedge.co.za>
Cc: "Arınç ÜNAL" <arinc.unal@arinc9.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
linux-mips@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style
Date: Mon, 18 Mar 2024 10:19:39 +0100 [thread overview]
Message-ID: <8a6e717d-a63b-4f1f-9873-efce2a868a4a@linaro.org> (raw)
In-Reply-To: <CAMhs-H_1bwfKO8yquz-3BHQ0UQYW1FFVJYHE66w8Q9m1+fCCHw@mail.gmail.com>
On 18/03/2024 09:48, Sergio Paracuellos wrote:
>>
>>
>>>> But if there're no objections and it lessens the burden on
>>>> maintainers upstream to have less patches to apply, then I have no
>>>> problem combining them into a single patch.
>>>>
>>>
>>> Yeah, one review response instead of 14 responses... One commit in the
>>> history instead of 14.
>>
>> I agree that 1 commit vs 14 is better.
>>
>> But for future reference: is it not enough for the Reviewed-by: trailer
>> to be sent in response to the cover letter of a patch set if a reviewer
>> has looked at the entire set?
>
> It is enough, AFAICT. I found your patchset very easy to review so I
> am ok with the patchset as it is. However, at the end this will be
> through the mips tree, so let's do what Thomas prefers: add all
> patches as they are or squash all of them in one commit.
Yeah, like fixing language typos in comments: one typo per patch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-18 9:19 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-16 4:54 [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style Justin Swartz
2024-03-16 4:54 ` [PATCH 01/14] mips: dts: ralink: mt7621: reorder cpu node attributes Justin Swartz
2024-03-16 9:20 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 02/14] mips: dts: ralink: mt7621: reorder cpuintc " Justin Swartz
2024-03-16 9:20 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 03/14] mips: dts: ralink: mt7621: reorder mmc regulator attributes Justin Swartz
2024-03-16 9:20 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 04/14] mips: dts: ralink: mt7621: reorder sysc node attributes Justin Swartz
2024-03-16 9:21 ` Arınç ÜNAL
2024-03-17 15:09 ` Krzysztof Kozlowski
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 05/14] mips: dts: ralink: mt7621: reorder gpio " Justin Swartz
2024-03-16 9:21 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 06/14] mips: dts: ralink: mt7621: reorder i2c " Justin Swartz
2024-03-16 9:21 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 07/14] mips: dts: ralink: mt7621: reorder spi0 " Justin Swartz
2024-03-16 9:22 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 08/14] mips: dts: ralink: mt7621: move pinctrl and sort its children Justin Swartz
2024-03-16 9:22 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 09/14] mips: dts: ralink: mt7621: reorder mmc node attributes Justin Swartz
2024-03-16 9:22 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 10/14] mips: dts: ralink: mt7621: reorder gic " Justin Swartz
2024-03-16 9:22 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 11/14] mips: dts: ralink: mt7621: reorder ethernet node attributes and kids Justin Swartz
2024-03-16 9:22 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 12/14] mips: dts: ralink: mt7621: reorder pcie node attributes and children Justin Swartz
2024-03-16 9:23 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 13/14] mips: dts: ralink: mt7621: reorder pci?_phy attributes Justin Swartz
2024-03-16 9:23 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 4:54 ` [PATCH 14/14] mips: dts: ralink: mt7621: reorder the attributes of the root node Justin Swartz
2024-03-16 9:23 ` Arınç ÜNAL
2024-03-18 10:20 ` AngeloGioacchino Del Regno
2024-03-16 9:24 ` [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style Arınç ÜNAL
2024-03-16 14:03 ` Justin Swartz
2024-03-16 15:16 ` Arınç ÜNAL
2024-03-16 15:49 ` Sergio Paracuellos
2024-03-17 15:10 ` Krzysztof Kozlowski
2024-03-17 15:22 ` Justin Swartz
2024-03-17 15:29 ` Krzysztof Kozlowski
2024-03-17 15:43 ` Justin Swartz
2024-03-18 8:48 ` Sergio Paracuellos
2024-03-18 9:19 ` Krzysztof Kozlowski [this message]
2024-03-18 10:57 ` Justin Swartz
2024-03-18 9:23 ` Krzysztof Kozlowski
2024-03-18 11:06 ` Justin Swartz
2024-04-08 7:35 ` Arınç ÜNAL
2024-04-15 8:32 ` Thomas Bogendoerfer
2024-04-15 8:33 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6e717d-a63b-4f1f-9873-efce2a868a4a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arinc.unal@arinc9.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=justin.swartz@risingedge.co.za \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox