From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 455BBC3ABC3 for ; Tue, 13 May 2025 12:33:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ikO6NxPSIIjD1kUAHzPCWxeEkTOjGoN0DmnRySn4PCk=; b=JL4Nx54rplN/svieighbw7l1o+ l9vFmaMLVlVUrGk6kpy+cq2sjnJbz+GJ6iOTxe1JAPyTRCGQLgigqY/Wtb942KrBgltP0NFvSzvqg Y8LLrunsY3Wveugfwdvgkdq1d7BnTxGpNKxTYUxho2cYyxfSoJFLrv0eYc3APTw8adruqpzFUtubA 5TxkERSjOAe0I9YAtVQDDAGzp1M2MaGcC2GHDt1i/+DhcpG0YDqPUhsHe13jAkHp7Yz9Zakfp8hT9 7ZgccFTa+81q/4sez4UoKBupeyPeYSAIXTWUla3njcnE5O6+gdgDgzNggcA10uyLd2NMDsB/rWuV7 mDvMFCGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEopD-0000000CMjp-1xSc; Tue, 13 May 2025 12:33:35 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uEoob-0000000CMbG-0hEI; Tue, 13 May 2025 12:32:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=ikO6NxPSIIjD1kUAHzPCWxeEkTOjGoN0DmnRySn4PCk=; b=sj emz6n58GPUmWdFVzAHRjKI2dWuI0rPQE8SL/5bYfGaf3w24mGVb9f0MujMpWRRsD0Uf3JyFv5eIVp +S43WT3eawgxo08pQ0i2Yjr8Sx3wlWf9hSC9Jm8lJCuaesVHG56wUYi9WlyHQ/d7Um/fp9Ef8n6c4 Upwr265iTWTKWnU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uEooK-00CS0n-Mk; Tue, 13 May 2025 14:32:40 +0200 Date: Tue, 13 May 2025 14:32:40 +0200 From: Andrew Lunn To: SkyLake Huang =?utf-8?B?KOm7g+WVn+a+pCk=?= Cc: "linux@armlinux.org.uk" , "dqfext@gmail.com" , Steven Liu =?utf-8?B?KOWKieS6uuixqik=?= , "davem@davemloft.net" , AngeloGioacchino Del Regno , "linux-mediatek@lists.infradead.org" , "pabeni@redhat.com" , "edumazet@google.com" , "linux-kernel@vger.kernel.org" , "hkallweit1@gmail.com" , "horms@kernel.org" , "daniel@makrotopia.org" , "kuba@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH net-next v2 3/3] net: phy: mediatek: add driver for built-in 2.5G ethernet PHY on MT7988 Message-ID: <8b67fa4c-a07a-4941-ba7b-23d4e1104451@lunn.ch> References: <20250219083910.2255981-1-SkyLake.Huang@mediatek.com> <20250219083910.2255981-4-SkyLake.Huang@mediatek.com> <74ce0275952a9c60af87ded9d64ca7301fd69d0f.camel@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <74ce0275952a9c60af87ded9d64ca7301fd69d0f.camel@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250513_053257_206439_949B516C X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, May 13, 2025 at 10:12:04AM +0000, SkyLake Huang (黃啟澤) wrote: > On Wed, 2025-02-19 at 09:33 +0000, Russell King (Oracle) wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > > > > > On Wed, Feb 19, 2025 at 04:39:10PM +0800, Sky Huang wrote: > > > +static int mt798x_2p5ge_phy_config_init(struct phy_device *phydev) > > > +{ > > > +     struct pinctrl *pinctrl; > > > +     int ret; > > > + > > > +     /* Check if PHY interface type is compatible */ > > > +     if (phydev->interface != PHY_INTERFACE_MODE_INTERNAL) > > > +             return -ENODEV; > > > + > > > +     ret = mt798x_2p5ge_phy_load_fw(phydev); > > > +     if (ret < 0) > > > +             return ret; > > > > Firmware should not be loaded in the .config_init method. The above > > call will block while holding the RTNL which will prevent all other > > network configuration until the firmware has been loaded or the load > > fails. > > > > Thanks. > > > > -- > > RMK's Patch system: > > https://urldefense.com/v3/__https://www.armlinux.org.uk/developer/patches/__;!!CTRNKA9wMg0ARbw!iV-1ViPFsUV-lLj7aIycan8nery6sQO3t6mkpdlb_GW8hswhxc4ejJozxqkU3s2WzxSizs4kfdC77yr7HGGRIuU$ > > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! > > Actually, I wrote fw loading flow in .probe. However, during boot time, > .probe is called at very early stage (about the first 2s after booting > into Linux Kernel). At that time, filesystem isn't ready yet and phy > driver can't locate /lib/firmware/mediatek/mt7988/i2p5ge-phy-pmb.bin. Tell Dracut or whatever you are using to build the initramfs to include the firmware. That is what MODULE_FIRMWARE() is for. Andrew