From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Bayi Cheng <bayi.cheng@mediatek.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Ikjoon Jang <ikjn@chromium.org>
Cc: linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Chuanhong Guo <gch981213@gmail.com>,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2] spi: spi-mtk-nor: Add recovery mechanism for dma read timeout
Date: Wed, 7 Dec 2022 14:21:56 +0100 [thread overview]
Message-ID: <8bec1bdb-2e22-d2bd-18bf-505f6dc75024@collabora.com> (raw)
In-Reply-To: <20221207055435.30557-1-bayi.cheng@mediatek.com>
Il 07/12/22 06:54, Bayi Cheng ha scritto:
> From: bayi cheng <bayi.cheng@mediatek.com>
>
> The state machine of MTK spi nor controller may be disturbed by some
> glitch signals from the relevant BUS during dma read, Although the
> possibility of causing the dma read to fail is next to nothing,
> However, if error-handling is not implemented, which makes the feature
> somewhat risky.
>
> Add an error-handling mechanism here, reset the state machine and
> re-read the data when an error occurs.
>
> Signed-off-by: bayi cheng <bayi.cheng@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2022-12-07 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 5:54 [PATCH v2] spi: spi-mtk-nor: Add recovery mechanism for dma read timeout Bayi Cheng
2022-12-07 13:21 ` AngeloGioacchino Del Regno [this message]
2022-12-07 16:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bec1bdb-2e22-d2bd-18bf-505f6dc75024@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=bayi.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=gch981213@gmail.com \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox