From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Sergio Paracuellos <sergio.paracuellos@gmail.com>,
Luiz Angelo Daros de Luca <luizluca@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: erkin.bozoglu@xeront.com, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-mips@vger.kernel.org
Subject: Re: [PATCH 09/14] mips: dts: ralink: mt7621: use the new compatible string for MT7621 pinctrl
Date: Thu, 14 Apr 2022 11:38:33 +0300 [thread overview]
Message-ID: <8eb29967-83ca-97c5-d6b9-808cf3ddeb16@arinc9.com> (raw)
In-Reply-To: <b415523c-34e3-28a1-bcce-4682e7c67e77@linaro.org>
On 13/04/2022 18:27, Krzysztof Kozlowski wrote:
> On 13/04/2022 08:07, Arınç ÜNAL wrote:
>> Use the new compatible string "ralink,mt7621-pinctrl" for the Ralink MT7621
>> pinctrl subdriver on mt7621.dtsi.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>> arch/mips/boot/dts/ralink/mt7621.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> index 3222684915ac..ee2ec78c8952 100644
>> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
>> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
>> @@ -151,7 +151,7 @@ spi0: spi@b00 {
>> };
>>
>> pinctrl: pinctrl {
>> - compatible = "ralink,rt2880-pinmux";
>> + compatible = "ralink,mt7621-pinctrl";
>
> The change is non-bisectable and causes issues all other users of DT
> (other projects, systems etc). This is discouraged in general, so you
> should describe it. The commit msg lacks answer to the main question:
> Why? You focused only on what you are doing, but why you are doing is
> actually more important for such change.
As it's seen on any other pinctrl subdriver that calls code from a main
driver, each subdriver needs to have a different compatible string. We
don't want the same compatible string to match a different subdriver's
pinmux data as it's not for our SoC.
I'll add what I typed above to the commit log.
Arınç
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-04-14 8:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 6:07 [PATCH 0/14] Refactor Ralink Pinctrl and Add Documentation Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 01/14] pinctrl: ralink: rename MT7628(an) functions to MT76X8 Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 02/14] pinctrl: ralink: rename pinctrl-rt2880 to pinctrl-ralink Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 03/14] pinctrl: ralink: rename pinmux functions to pinctrl Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 04/14] pinctrl: ralink: rename pinctrl-rt288x to pinctrl-rt2880 Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 05/14] pinctrl: ralink: rename variable names for functions on MT7620 and MT7621 Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 06/14] pinctrl: ralink: rename driver names to subdrivers Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 07/14] pinctrl: ralink: add new compatible strings for each pinctrl subdriver Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 08/14] MAINTAINERS: add Ralink pinctrl driver Arınç ÜNAL
2022-04-13 6:27 ` Sergio Paracuellos
2022-04-13 8:29 ` Joe Perches
2022-04-13 10:40 ` Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 09/14] mips: dts: ralink: mt7621: use the new compatible string for MT7621 pinctrl Arınç ÜNAL
2022-04-13 15:27 ` Krzysztof Kozlowski
2022-04-14 8:38 ` Arınç ÜNAL [this message]
2022-04-13 6:07 ` [PATCH 10/14] dt-bindings: pinctrl: rt2880: fix binding name, pin groups and functions Arınç ÜNAL
2022-04-13 15:25 ` Krzysztof Kozlowski
2022-04-14 8:34 ` Arınç ÜNAL
2022-04-14 16:17 ` Rob Herring
2022-04-14 16:37 ` Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 11/14] dt-bindings: pinctrl: add binding for Ralink MT7620 pinctrl Arınç ÜNAL
2022-04-13 15:37 ` Krzysztof Kozlowski
2022-04-14 1:52 ` Arınç ÜNAL
2022-04-14 6:33 ` Krzysztof Kozlowski
2022-04-14 8:16 ` Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 12/14] dt-bindings: pinctrl: add binding for Ralink MT7621 pinctrl Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 13/14] dt-bindings: pinctrl: add binding for Ralink RT305X pinctrl Arınç ÜNAL
2022-04-13 6:07 ` [PATCH 14/14] dt-bindings: pinctrl: add binding for Ralink RT3883 pinctrl Arınç ÜNAL
2022-04-13 6:36 ` [PATCH 0/14] Refactor Ralink Pinctrl and Add Documentation Sergio Paracuellos
2022-04-13 7:52 ` Arınç ÜNAL
2022-04-13 15:39 ` Krzysztof Kozlowski
2022-04-14 8:26 ` Arınç ÜNAL
2022-04-21 14:27 ` Linus Walleij
2022-04-21 14:43 ` Arınç ÜNAL
2022-04-22 5:21 ` Sergio Paracuellos
2022-04-22 6:13 ` Arınç ÜNAL
2022-04-22 22:07 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eb29967-83ca-97c5-d6b9-808cf3ddeb16@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=devicetree@vger.kernel.org \
--cc=erkin.bozoglu@xeront.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergio.paracuellos@gmail.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox