From: Matthias Brugger <matthias.bgg@gmail.com>
To: Frank Wunderlich <linux@fw-web.de>, linux-mediatek@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3
Date: Mon, 6 Feb 2023 21:20:57 +0100 [thread overview]
Message-ID: <8f04f2b5-320e-50d4-9517-6dac989f63b3@gmail.com> (raw)
In-Reply-To: <20230205174833.107050-1-linux@fw-web.de>
On 05/02/2023 18:48, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Leds for Wifi are low-active, so add property to devicetree.
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index 33bd6febc160..2b028141f1f7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -446,5 +446,9 @@ &wifi {
> pinctrl-names = "default", "dbdc";
> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> +
> + led {
> + led-active-low;
> + };
The binding is missing this property also the driver implements it. Could you
please update the bindind description properly?
Thanks
Matthias
next prev parent reply other threads:[~2023-02-06 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 17:48 [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3 Frank Wunderlich
2023-02-06 20:20 ` Matthias Brugger [this message]
2023-02-07 15:17 ` AngeloGioacchino Del Regno
2023-05-22 8:26 ` Aw: " Frank Wunderlich
2023-05-29 16:07 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f04f2b5-320e-50d4-9517-6dac989f63b3@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@fw-web.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox