From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AF15C36005 for ; Sat, 22 Mar 2025 15:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mSMXTmA7NHlO+etZYtz5b3FTs1rltNj6XepKrdcM7Vw=; b=ihtqrJy7kBWg1d3fVHFQtuj1R0 JjxNKbHYXxDkojkpdggwpgW412T+rZ1ZficRwsNjySM6szLZQRmy6M+gCIN+6PWwpyIg1XBgEHehv p9EeYJAtFYfomL2RAFVX7xXOeLDysee4jph4axtbBC/xmYr1YJu6xL17KUQd2fruzEWzM5bLOot/X hb12iVFgK/01UVsT9ZLoJ0eNNQS7LKHPJxmpWlD2m3kiNTY7VU9iQoKbnNNfpOEoFkgkNEyNim3SV iQPDGEZT8tDTNQeMT1LPKS53lJ/t2QuPy7EsP2xgWwmYWVvJhcB80lvswE7xZeygFa6Qt8s6Wgme9 sdwpfwyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tw1BQ-000000002tE-3pT2; Sat, 22 Mar 2025 15:54:48 +0000 Received: from s3.sipsolutions.net ([2a01:4f8:242:246e::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tw1BP-000000002si-1TjK; Sat, 22 Mar 2025 15:54:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=mSMXTmA7NHlO+etZYtz5b3FTs1rltNj6XepKrdcM7Vw=; t=1742658886; x=1743868486; b=Q6TFQaYl5CX/o0vJMOmAUcUk/ZyIdAwU7tLROf9JHibAsH7 DvzW1RMKEPsOyVeTzpaO/4sIJodDEE0OAm/zyxVTlG/bQoPzNVokw3cew4h4CQFaaq4qyKluCb4MJ iClZqANzQMzweSvW2FxTW/gFku8padxJwYCTcq3rtP0kP0sgT2rZYYVSpID8NH7IXJ5gFqll+Ub7o d/E2N+fsUxVmOV9r+mkrP1Ya6IYQ9bjAR9RO8+Zueabg6QxwktzYravux2MNBlebgvXO0SrLcJFRD tmMM8LixaLtUsPbG2XSYDIHQh2i5nrAiz2m5WF2Ytn8ucC5uSZW6JqgAoejnBVgQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tw1BK-000000024Ph-3HW4; Sat, 22 Mar 2025 16:54:43 +0100 Message-ID: <92d1a410788c54facedec033474046dda6a1a2cc.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: mt76: mt7996: avoid potential null deref in mt7996_get_et_stats() From: Johannes Berg To: Markus Elfring , Qasim Ijaz , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Cc: LKML , Angelo Gioacchino Del Regno , Bo Jiao , Dan Carpenter , Felix Fietkau , Lorenzo Bianconi , Matthias Brugger , Peter Chiu , Ryder Lee , Sean Wang , Shayne Chen Date: Sat, 22 Mar 2025 16:54:41 +0100 In-Reply-To: References: <20250322141910.4461-1-qasdev00@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250322_085447_388963_2498E9FF X-CRM114-Status: UNSURE ( 8.03 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sat, 2025-03-22 at 15:55 +0100, Markus Elfring wrote: > > Ensure phy->mib is only accessed after the null sanity check for phy > > otherwise the code may trigger a potential null deref. >=20 > * Would you like to use the term =E2=80=9Cnull pointer dereference=E2=80= =9D consistently? >=20 > * Were any known source code analysis tools involved also for > =C2=A0=C2=A0this software improvement? >=20 Do you really have to double down? STOP. You're just wasting everyone's time. johannes