From: xinlei.lee <xinlei.lee@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<matthias.bgg@gmail.com>
Cc: <linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH,2/2] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm.
Date: Tue, 23 Aug 2022 17:20:34 +0800 [thread overview]
Message-ID: <93938744264079d92c2bedf3a9abc4e92abc3ae6.camel@mediatek.com> (raw)
In-Reply-To: <f621a841-593f-cfed-9560-64c011a00bdd@linaro.org>
On Tue, 2022-08-23 at 11:32 +0300, Krzysztof Kozlowski wrote:
> On 23/08/2022 10:31, xinlei.lee@mediatek.com wrote:
> > From: xinlei lee <xinlei.lee@mediatek.com>
> >
> > In the original mtk_disp_pwm_get_state() function, the result of
> > reading
> > con0 & BIT(0) is enabled as disp_pwm.
> > In order to conform to the register table, we should use the
> > disp_pwm
> > base address as the enabled judgment.
> >
> > Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API
> > .get_state()")
> > Signed-off-by: xinlei lee <xinlei.lee@mediatek.com>
>
> This is a fix so not really related with the change adding new
> device.
> Send them separately in the future.
>
> Best regards,
> Krzysztof
Hi Krzysztof:
Thanks for your suggestion.
If there are no other comments on this revision, I will separate them
in the next edition.
Best Regards!
Xinlei
next prev parent reply other threads:[~2022-08-23 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 7:31 [PATCH 0/2] Fix mtk_disp_pwm_get_state function disp_pwm enabled flag xinlei.lee
2022-08-23 7:31 ` [PATCH,1/2] dt-bindings: pwm: Add compatible for Mediatek MT8188 xinlei.lee
2022-08-23 8:31 ` Krzysztof Kozlowski
2022-09-14 19:54 ` Uwe Kleine-König
2022-08-23 7:31 ` [PATCH,2/2] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp_pwm xinlei.lee
2022-08-23 8:32 ` Krzysztof Kozlowski
2022-08-23 9:20 ` xinlei.lee [this message]
2022-08-23 9:26 ` Miles Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93938744264079d92c2bedf3a9abc4e92abc3ae6.camel@mediatek.com \
--to=xinlei.lee@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox