Re: [PATCH v2,3/7] media: mediatek: vcodec: Add a debugfs file to get different useful information

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 22/03/23 10:46, Yunfei Dong ha scritto:
> In oder to get each instance information according to test command, adding
> one file node "vdec".
> 
> Can use echo command to set different string value as 'echo -picinfo > vdec'.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> ---
>   .../mediatek/vcodec/mtk_vcodec_dbgfs.c        | 64 +++++++++++++++++++
>   .../mediatek/vcodec/mtk_vcodec_dbgfs.h        | 32 ++++++++++
>   .../mediatek/vcodec/mtk_vcodec_dec_drv.c      |  2 +
>   3 files changed, 98 insertions(+)
> 

> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.h
> index 5eec2211cbbe..47c0a986877d 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dbgfs.h
> @@ -8,19 +8,51 @@
>   #define __MTK_VCODEC_DBGFS_H__
>   
>   struct mtk_vcodec_dev;
> +struct mtk_vcodec_ctx;
> +
> +/**
> + * struct mtk_vcodec_dbgfs_inst  - debugfs informatiaoin for each inst

There's a typo: "information"

> + * @node: list node for each inst
> + * @vcodec_ctx: struct mtk_vcodec_ctx
> + * @inst_id: index of the context that the same with ctx->id
> + */
> +struct mtk_vcodec_dbgfs_inst {
> +	struct list_head node;
> +	struct mtk_vcodec_ctx *vcodec_ctx;
> +	int inst_id;
> +};
>   
>   /**
>    * struct mtk_vcodec_dbgfs  - dbgfs information
> + * @dbgfs_head: list head used to link each instance
>    * @vcodec_root: vcodec dbgfs entry
> + * @dbgfs_lock: dbgfs lock used to protect dbgfs_buf
> + * @dbgfs_buf: dbgfs buf used to store dbgfs cmd
> + * @inst_count: the count of total instance
>    */
>   struct mtk_vcodec_dbgfs {
> +	struct list_head dbgfs_head;
>   	struct dentry *vcodec_root;
> +	/* dbgfs lock used to protect dbgfs_buf */

This comment is duplicated, you're already documenting it in kerneldoc above! :-)

> +	struct mutex dbgfs_lock;
> +	char dbgfs_buf[1024];
> +	int inst_count;
>   };
>   

Regards,
Angelo