From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5BB9AC43458 for ; Wed, 8 Jul 2026 12:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LMTh0V639Yf2I2TTVIIe/eluhRhvYcsFWaLhme4GuFU=; b=u3KsV2Tk1YKTm8rZASFl5WYpQd +cjI+Q8mqZNHlecIBeyjuw2FfY3tRZhy4sp3BVmx3aDE08NVhOsWC1OxeykTpgSd/I/wR0bOe5/iM WpZIop8mXEOLYH1kKRm21dSnBW/VVunW0jHdavu2KQ8zOng0+mdR5J0YPdSSd+8ncWg1R8GhSwV+5 jikvsyVllIbhYrfs2hlcLmjddHo7jyed00vcrELn89GrrqJvPav7tefEsCoMygj5mUdiBMX9dZFmS aWsEHym668OVN+EMoAgGo+48y1Zc0shnfKlnRzK6hNxZysmENbsUYdnb96XJ4ESMBfKJVcyktn6Px twSsvBTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whR8o-0000000H4LQ-0veq; Wed, 08 Jul 2026 12:12:38 +0000 Received: from bali.collaboradmins.com ([148.251.105.195]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whR8k-0000000H4Ji-2NK2; Wed, 08 Jul 2026 12:12:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1783512750; bh=LWzKAWbjXwRZm/8P259BKzlhUiJ6T2PGRVC7hN/IGTE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=khi/t3Rn7xuVoMQK1wZmJSqjU13hZ8VjC9Trgd3XIn6eOMPD6pcUnkVdIBhUWN/3N kTRZuDS4OM+fAXzDZgihCWwkiPmM1l72+SdSp4ZedCgpggoFTdwF50yzcOjlN1f1Ub jjLzAzV4lhmYA0vx3HYXEod5M4AN+3zpDt9YCNzr5tFmWGhvlFUoC8T01SL1LNMTDj SdeCysDTcbel7p4EpfA9Av1A/u1m2/ZSHSLBdNpD0MzuxGlcFUqJIw6CXOy4r2W6Fn CVRXhu0TVZvLErOJxH+HxzucljwRIa4HfBCOR1oamCcNVEMXM3Eo/RQhnA26HA2Cz+ wBgg5s+g9CMrg== Received: from [100.64.1.21] (unknown [100.64.1.21]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange x25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id B78B317E0713; Wed, 08 Jul 2026 14:12:29 +0200 (CEST) Message-ID: <956e84d2-728a-4e8c-8026-ae1a41e69171@collabora.com> Date: Wed, 8 Jul 2026 14:12:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/mediatek: mtk_dsi: enable hs clock during pre-enable To: Adam Thiede , Thorsten Leemhuis , =?UTF-8?B?Q0sgSHUgKOiDoeS/iuWFiSk=?= , "bisson.gary@gmail.com" Cc: "chunkuang.hu@kernel.org" , "simona@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "airlied@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "p.zabel@pengutronix.de" , "matthias.bgg@gmail.com" , "linux-mediatek@lists.infradead.org" , "regressions@lists.linux.dev" References: <20260120-mtkdsi-v1-1-b0f4094f3ac3@gmail.com> <42607fa4-485d-4142-b31c-7bfac71118d2@adamthiede.com> <5baeb90d2c3736df67ad075ede4ac765bfeaed2d.camel@mediatek.com> <84233951-ee22-4980-9f17-2af1df51fdbf@leemhuis.info> <6fed12a6-0c94-477f-8a2e-466c33ea2e29@collabora.com> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260708_051234_764169_BB75E208 X-CRM114-Status: GOOD ( 26.28 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 7/8/26 03:25, Adam Thiede wrote: > On 7/7/26 05:38, AngeloGioacchino Del Regno wrote: >> On 7/7/26 10:51, Thorsten Leemhuis wrote: >>> On 7/7/26 04:20, CK Hu (胡俊光) wrote: >>>> On Mon, 2026-07-06 at 12:16 +0200, Thorsten Leemhuis wrote: >>>>> On 6/22/26 15:23, Adam Thiede wrote: >>>>>> On 6/22/26 06:22, Gary Bisson wrote: >>>>>>> On Thu, Jun 18, 2026 at 04:06:28PM -0500, Adam Thiede wrote: >>>>>>>> On 1/20/26 05:36, Gary Bisson wrote: >>>>>>>>> Some bridges, such as the TI SN65DSI83, require the HS clock to be >>>>>>>>> running in order to lock its PLL during its own pre-enable function. >>>>>>>>> >>>>>>>>> Without this change, the bridge gives the following error: >>>>>>>>> sn65dsi83 14-002c: failed to lock PLL, ret=-110 >>>>>>>>> sn65dsi83 14-002c: Unexpected link status 0x01 >>>>>>>>> sn65dsi83 14-002c: reset the pipe >>>>>>>>> [...] >>>>>>>> >>>>>>>> This commit was part of 7.1 and caused a problem for me. >>>>>>>> I'm running postmarketOS (basically Alpine Linux) on a Lenovo C330 >>>>>>>> chromebook with a Mediatek MT8173 processor. >>>>>>>> The problem: when the display on my laptop powers off (via suspend or >>>>>>>> idle, >>>>>>>> like xset dpms off) the picture does not come back when the display >>>>>>>> powers >>>>>>>> back on (from resume). The display backlight comes on and brightness is >>>>>>>> adjustable but there is no picture. The only fix is to reboot. >>>>>>>> >>>>>>>> Reverting this commit and applying it as a patch on top of 7.1 >>>>>>>> addresses the >>>>>>>> issue for me. >>>>>>>> >>>>>>>> You can view the config I'm using here: >>>>>>>> https://urldefense.com/v3/__https://gitlab.postmarketos.org/ postmarketOS/ >>>>>>>> pmaports/-/__;!!CTRNKA9wMg0ARbw! >>>>>>>> jrsPDtSEUdaINzLlq92Li8gmsEBkTOxZ6WUzNHjvIN6CyOJjHiHkNSOhIRPXFTLPlaYlxU2uvryVkwjUAN9bmax5$ >>>>>>>> merge_requests/8819 >>>>>>>> >>>>>>>> Is there any sort of testing or other debugging info I can provide to >>>>>>>> help >>>>>>>> address this issue? >>>>>>> >>>>>>> Thanks for reporting the issue, could you share some logs? Is the driver >>>>>>> saying anything during resume? Also, what type of panel is used on that >>>>>>> chromebook? >>>>>> >>>>>> The curious thing is that there are no real logs in dmesg or /var/log/ >>>>>> messages about this. This picture just fails to come back. If there are >>>>>> some kernel params I can set to get deeper logging, that would help, but >>>>>> I'm not aware of any. >>>>>> >>>>>> I think the panel is a "BOE NV116WHM-T00" - I used this command to get >>>>>> info: cat /sys/class/drm/card0-eDP-1/edid | edid-decode >>>>>> >>>>>> Output: https://urldefense.com/v3/__https://termbin.com/8nbd__;!! >>>>>> CTRNKA9wMg0ARbw! >>>>>> jrsPDtSEUdaINzLlq92Li8gmsEBkTOxZ6WUzNHjvIN6CyOJjHiHkNSOhIRPXFTLPlaYlxU2uvryVkwjUAJooSyqL$ >>>>> >>>>> This looked stalled. If I'm mistaken here, please let me known; but if >>>>> no solution is in sight, should we maybe just revert the change until a >>>>> proper was found? >>>> >>>> It's welcome anyone to provide a revert patch, >>>> but I would still wait for the fixup patch until 7.2-rc4. >>>> If no fixup patch exist, then apply the revert patch. >>>  From my understanding of things the position in the devel cycle doesn't >>> matter much in a case like this. To quote Linus statements from >>> https://www.kernel.org/doc/html/latest/process/handling- regressions.html#on- >>> how-quickly-regressions-should-be-fixed >>> >>> """ >>>  From 2026-01-22: >>> >>>   But a user complaining should basically result in an immediate fix - >>>   possibly a "revert and rethink". >>> >>> With a later clarification on 2026-01-28: >>> >>>   It's also worth noting that "immediate" obviously doesn't mean "right >>>   this *second* when the problem has been reported". >>> >>>   But if it's a regression with a known commit that caused it, I think >>>   the rule of thumb should generally be "within a week", preferably >>>   before the next rc. >>> """ >>> >>> Adam reported the problem about three weeks ago, so we are way past the >>> "rule of thumb" timeframe Linus set. >>> >>> Ciao, Thorsten >> >> This is a kind of odd situation here. The fix from Adam is actually correct, as in, >> the SN65DSI83 bridge gets broken without... >> >> ....but then, there's some more oddness going on: I tried to reproduce this on my >> MT8173 Elm device, but there I can resume the system just fine, and the display is >> up and running like normal? >> >> I'm not sure what to advice here at this point - just adding some info. >> >> Cheers, >> Angelo > Angelo, would you mind sharing your config, and the details of what you're running? > It might be a configuration difference. > Thanks! Sure, here it is: https://gitlab.collabora.com/mediatek/aiot/linux/-/blob/mediatek-dev/arch/arm64/configs/defconfig?ref_type=heads Cheers, Angelo