From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D39A6C43458 for ; Mon, 6 Jul 2026 00:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wYrjdzAhnc0P88BFwUH/b6uj52WFQfIRb2R1u4QFCds=; b=gJw3IHr8untfiaLj9rnNpR1HA8 8bv9Y3lIA8BruPTd2aGb7zRnBK6qFJBJAZWHKhcDE4UpGtZOGw+wHDziU44ihyNJu4kiqP0qA0kGj b0xLR5zXmGkllobegps2jXMReUhV1a0lyOcRE9Ua9C+rmugeDSmyh/stQIsOfY8Z1zqeYtjt2yYXE 3HbtgPlIQdVxWJS8WXRYNp5oWRuKlo7raZbcSSsqJrTO5D8oLjpMuVP8tKM8F78KkG5eWcrDP3WCW pJC6moP2C744EQC8mGml4Vf733Sw9uLkYMD64aqhGA5L/oOPFAYFdElPxFsqMNAkP/57lR4x8Xsfo o+YYj4Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgXID-0000000AuPv-1PO4; Mon, 06 Jul 2026 00:34:37 +0000 Received: from out-184.mta0.migadu.com ([91.218.175.184]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wgXI9-0000000AuM1-1lIU for linux-mediatek@lists.infradead.org; Mon, 06 Jul 2026 00:34:35 +0000 Message-ID: <973f3d6f-6ff4-4685-9c9f-b07987f74d98@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1783298059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wYrjdzAhnc0P88BFwUH/b6uj52WFQfIRb2R1u4QFCds=; b=mLsuUED9ENIp3ed3h8bdKFYcEwFgoRzOELLNc1jLIXF6taZ+WEztXLwd9/BAKQWvUz2Hs3 3EKLIatmB5Z+Df3dgdlCr8bmpTJQbWFj3Jp6WCvzaQnW40BXVB4LUsJRj7jQdhncagFIYu oCbFYryMjDBm1fu5il4d+x3rl9gBRyM= Date: Mon, 6 Jul 2026 08:33:47 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v1 4/5] pwm: Unify coding style of of_device_id arrays To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= , linux-pwm@vger.kernel.org Cc: Sven Peter , Janne Grunau , Neal Gompa , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Ray Jui , Scott Branden , Broadcom internal kernel review list , Florian Fainelli , Benson Leung , Guenter Roeck , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Paul Cercueil , Vladimir Zapolskiy , Piotr Wojtaszczyk , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Paul Walmsley , Samuel Holland , Michael Walle , Inochi Amaoto , Orson Zhai , Baolin Wang , Chunyan Zhang , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Hammer Hsieh , Nobuhiro Iwamatsu , Alexey Charkov , Sean Anderson , Michal Simek , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, imx@lists.linux.dev, linux-mips@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-riscv@lists.infradead.org, sophgo@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev References: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chen Wang In-Reply-To: <20de6cd60c2938aad2d21397b92742849418ab1b.1783263835.git.ukleinek@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260705_173433_614175_69B54C49 X-CRM114-Status: GOOD ( 13.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On 7/5/2026 11:14 PM, Uwe Kleine-König (The Capable Hub) wrote: > - Use a single space in a of_device_id array terminator; A single space > after the opening { and before the closing } in non-empty > initializers; > - No comma after an array terminator; > - Also no trailing comma after a named initializer iff the iff -> if > closing } is on the same line; > > Signed-off-by: Uwe Kleine-König (The Capable Hub) [......] > diff --git a/drivers/pwm/pwm-sophgo-sg2042.c b/drivers/pwm/pwm-sophgo-sg2042.c > index 7d07b0ca7d29..0b6461172e6a 100644 > --- a/drivers/pwm/pwm-sophgo-sg2042.c > +++ b/drivers/pwm/pwm-sophgo-sg2042.c > @@ -225,11 +225,10 @@ static const struct sg2042_chip_data sg2044_chip_data = { > static const struct of_device_id sg2042_pwm_ids[] = { > { > .compatible = "sophgo,sg2042-pwm", > - .data = &sg2042_chip_data > - }, > - { > + .data = &sg2042_chip_data, > + }, { > .compatible = "sophgo,sg2044-pwm", > - .data = &sg2044_chip_data > + .data = &sg2044_chip_data, > }, > { } > }; Changes to sophgo related files： Reviewed-by: Chen Wang Thanks, Chen [......]