[PATCH v2 1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node

[PATCH v2 1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node

[Christian Marangi]

Sata node reference the pciesys with the property mediatek,phy-node
and that is used as a syscon to access the pciesys regs.

Readd the syscon compatible to pciesys node to restore correct
functionality of the SATA interface.

Fixes: 3ba5a6159434 ("arm64: dts: mediatek: mt7622: fix clock controllers")
Reported-by: Frank Wunderlich <frank-w@public-files.de>
Co-developed-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org
---
 arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
index 917fa39a74f8..bb0ec1edbe5b 100644
--- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
@@ -790,7 +790,7 @@ u2port1: usb-phy@1a0c5000 {
 	};
 
 	pciesys: clock-controller@1a100800 {
-		compatible = "mediatek,mt7622-pciesys";
+		compatible = "mediatek,mt7622-pciesys", "syscon";
 		reg = <0 0x1a100800 0 0x1000>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;
-- 
2.45.1

[PATCH v2 2/2] dt-bindings: clock: mediatek: add syscon compatible for mt7622 pciesys

[Christian Marangi]

Add required syscon compatible for mt7622 pciesys. This is required for
SATA interface as the regs are shared.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
Changes v2:
- Fix broken schema example

 .../bindings/clock/mediatek,mt7622-pciesys.yaml        | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
index c77111d10f90..9c3913f9092c 100644
--- a/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
+++ b/Documentation/devicetree/bindings/clock/mediatek,mt7622-pciesys.yaml
@@ -14,9 +14,11 @@ maintainers:
 
 properties:
   compatible:
-    enum:
-      - mediatek,mt7622-pciesys
-      - mediatek,mt7629-pciesys
+    oneOf:
+      - items:
+          - const: mediatek,mt7622-pciesys
+          - const: syscon
+      - const: mediatek,mt7629-pciesys
 
   reg:
     maxItems: 1
@@ -38,7 +40,7 @@ additionalProperties: false
 examples:
   - |
     clock-controller@1a100800 {
-        compatible = "mediatek,mt7622-pciesys";
+        compatible = "mediatek,mt7622-pciesys", "syscon";
         reg = <0x1a100800 0x1000>;
         #clock-cells = <1>;
         #reset-cells = <1>;
-- 
2.45.1

Re: [PATCH v2 1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node

[Markus Elfring]

> Sata node reference the pciesys with the property mediatek,phy-node
> and that is used as a syscon to access the pciesys regs.
>
> Readd the syscon compatible to pciesys node to restore correct
> functionality of the SATA interface.
…
> Reported-by: Frank Wunderlich …

Was any related information published?

Regards,
Markus

Re: [PATCH v2 1/2] arm64: dts: mediatek: mt7622: readd syscon to pciesys node

[Frank Wunderlich]

Am 29. Juni 2024 19:35:01 MESZ schrieb Markus Elfring <Markus.Elfring@web.de>:
>> Sata node reference the pciesys with the property mediatek,phy-node
>> and that is used as a syscon to access the pciesys regs.
>>
>> Readd the syscon compatible to pciesys node to restore correct
>> functionality of the SATA interface.
>…
>> Reported-by: Frank Wunderlich …
>
>Was any related information published?
>
>Regards,
>Markus
>

Hi,

I found this while changing uboot to of_upstream and fixed it there (not yet send to mailinglist). As of_upstream uses linux dts,i rechecked if it is broken there too and yes it is.

But i have not sent issue to mailinglist because we fixed it before :)
regards Frank

Re: [PATCH v2 2/2] dt-bindings: clock: mediatek: add syscon compatible for mt7622 pciesys

[Krzysztof Kozlowski]

On 28/06/2024 12:55, Christian Marangi wrote:
> Add required syscon compatible for mt7622 pciesys. This is required for
> SATA interface as the regs are shared.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> Changes v2:
> - Fix broken schema example

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2 2/2] dt-bindings: clock: mediatek: add syscon compatible for mt7622 pciesys

[Stephen Boyd]

Quoting Christian Marangi (2024-06-28 03:55:41)
> Add required syscon compatible for mt7622 pciesys. This is required for
> SATA interface as the regs are shared.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---

Applied to clk-next