Re: [PATCH 2/2] usb: mtu3: fix NULL pointer dereference

Markus Elfring
2020-06-29T08:00:51Z

> Some pointers are dereferenced before successful checks.

I suggest to reconsider and improve the change description.

* Would a null pointer dereference be possible only with the variables “mep”
and “mreq” in the implementation of the function “mtu3_gadget_dequeue”?

* How do you think about to adjust any more variable initialisations?

* Will it become helpful to add the tag “Fixes” to the commit message?

Regards,
Markus