From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Rui Zhou <zhourui@huaqin.corp-partner.google.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, perex@perex.cz, allen-kh.cheng@mediatek.com,
kuninori.morimoto.gx@renesas.com
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [v1 3/3] ASoC: mediatek: mt8188-mt6359: add two amps support
Date: Tue, 7 Nov 2023 09:30:59 +0100 [thread overview]
Message-ID: <9a30463b-3581-4738-9eea-b45e0c9a1d7a@collabora.com> (raw)
In-Reply-To: <20231107031442.2768765-4-zhourui@huaqin.corp-partner.google.com>
Il 07/11/23 04:14, Rui Zhou ha scritto:
> Support codec rt5682 using two amps.
>
> Signed-off-by: Rui Zhou <zhourui@huaqin.corp-partner.google.com>
Can you please change the commit description so that it's clear that you're adding
the two amps support to the RT5682s variant? As it is right now, it reads like you
are adding that globally.
ASoC: mediatek: mt8188-mt6359: Enable dual amp for mt8188_rt5682s
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> sound/soc/mediatek/mt8188/mt8188-mt6359.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/mediatek/mt8188/mt8188-mt6359.c b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> index e994faa3556b..917640939621 100644
> --- a/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> +++ b/sound/soc/mediatek/mt8188/mt8188-mt6359.c
> @@ -1549,7 +1549,7 @@ static struct mt8188_card_data mt8188_nau8825_card = {
>
> static struct mt8188_card_data mt8188_rt5682s_card = {
> .name = "mt8188_rt5682s",
> - .quirk = RT5682S_HS_PRESENT,
> + .quirk = RT5682S_HS_PRESENT | MAX98390_TWO_AMP,
> };
>
> static struct mt8188_card_data mt8188_es8326_card = {
next prev parent reply other threads:[~2023-11-07 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 3:14 [v1 0/3] add es8326 dt-bindings and es8326 support Rui Zhou
2023-11-07 3:14 ` [v1 1/3] ASoC: dt-bindings: mt8188-mt6359: add " Rui Zhou
2023-11-07 7:11 ` Krzysztof Kozlowski
2023-11-07 7:59 ` Rui Zhou
2023-11-07 8:06 ` Krzysztof Kozlowski
2023-11-07 8:19 ` Rui Zhou
2023-11-07 8:30 ` AngeloGioacchino Del Regno
2023-11-07 8:33 ` AngeloGioacchino Del Regno
2023-11-07 3:14 ` [v1 2/3] ASoC: mediatek: " Rui Zhou
2023-11-07 8:30 ` AngeloGioacchino Del Regno
2023-11-07 3:14 ` [v1 3/3] ASoC: mediatek: mt8188-mt6359: add two amps support Rui Zhou
2023-11-07 8:30 ` AngeloGioacchino Del Regno [this message]
2023-11-07 8:41 ` Rui Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a30463b-3581-4738-9eea-b45e0c9a1d7a@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=zhourui@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox