From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v3 1/7] iommu/mediatek: Correct the flush_iotlb_all callback Date: Mon, 14 Oct 2019 15:06:49 +0100 Message-ID: <9aa2e356-d234-df21-7203-ce569c232e02@arm.com> References: <1571035101-4213-1-git-send-email-yong.wu@mediatek.com> <1571035101-4213-2-git-send-email-yong.wu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1571035101-4213-2-git-send-email-yong.wu@mediatek.com> Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Yong Wu , Matthias Brugger , Joerg Roedel , Will Deacon Cc: Evan Green , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, Nicolas Boichat , anan.sun@mediatek.com, cui.zhang@mediatek.com, chao.hao@mediatek.com, edison.hsieh@mediatek.com List-Id: linux-mediatek@lists.infradead.org On 14/10/2019 07:38, Yong Wu wrote: > Use the correct tlb_flush_all instead of the original one. Reviewed-by: Robin Murphy > Fixes: 4d689b619445 ("iommu/io-pgtable-arm-v7s: Convert to IOMMU API TLB sync") > Signed-off-by: Yong Wu > --- > drivers/iommu/mtk_iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/mtk_iommu.c b/drivers/iommu/mtk_iommu.c > index 67a483c..76b9388 100644 > --- a/drivers/iommu/mtk_iommu.c > +++ b/drivers/iommu/mtk_iommu.c > @@ -447,7 +447,7 @@ static size_t mtk_iommu_unmap(struct iommu_domain *domain, > > static void mtk_iommu_flush_iotlb_all(struct iommu_domain *domain) > { > - mtk_iommu_tlb_sync(mtk_iommu_get_m4u_data()); > + mtk_iommu_tlb_flush_all(mtk_iommu_get_m4u_data()); > } > > static void mtk_iommu_iotlb_sync(struct iommu_domain *domain, >