From: Bart Van Assche <bvanassche@acm.org>
To: peter.wang@mediatek.com, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
cc.chou@mediatek.com, chaotian.jing@mediatek.com,
jiajie.hao@mediatek.com, yi-fan.peng@mediatek.com,
qilin.tan@mediatek.com, lin.gui@mediatek.com,
tun-yu.yu@mediatek.com, eddie.huang@mediatek.com,
naomi.chu@mediatek.com, ed.tsai@mediatek.com
Subject: Re: [PATCH v1 02/10] ufs: host: mediatek: Add DDR_EN setting
Date: Wed, 16 Jul 2025 08:22:34 -0700 [thread overview]
Message-ID: <9aafec2c-199a-4373-bdb1-6031f574af6d@acm.org> (raw)
In-Reply-To: <20250716062830.3712487-3-peter.wang@mediatek.com>
On 7/15/25 11:25 PM, peter.wang@mediatek.com wrote:
> On MT6989 and later platforms, control of DDR_EN has been switched from
> SPM to EMI. To prevent abnormal access to DRAM, it is necessary to wait
> for 'ddren_ack' or assert 'ddren_urgent' after sending 'ddren_req'.
>
> This patch introduces the DDR_EN configuration in the UFS initialization
> flow, utilizing the assertion of 'ddren_urgent' to maintain performance.
What is SPM? What is EMI? What is DDR_EN? Please expand these acronyms.
> +/* UFS MTK ip version value */
> +enum {
> + /* UFS 3.1 */
> + IP_VER_MT6878 = 0x10420200,
> +
> + /* UFS 4.0 */
> + IP_VER_MT6897 = 0x10440000,
> + IP_VER_MT6989 = 0x10450000,
> +
> + IP_VER_NONE = 0xFFFFFFFF
> +};
How can MediaTek IP versions be related to the UFS standard? Should
"UFS" perhaps be changed into "UFSHCI" in the above comments?
Thanks,
Bart.
next prev parent reply other threads:[~2025-07-16 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 6:25 [PATCH v1 00/10] ufs: host: mediatek: Provide features and fixes in MediaTek platforms peter.wang
2025-07-16 6:25 ` [PATCH v1 01/10] ufs: host: mediatek: Change return type to bool peter.wang
2025-07-16 15:19 ` Bart Van Assche
2025-07-17 6:37 ` Peter Wang (王信友)
2025-07-17 15:35 ` Bart Van Assche
2025-07-16 6:25 ` [PATCH v1 02/10] ufs: host: mediatek: Add DDR_EN setting peter.wang
2025-07-16 15:22 ` Bart Van Assche [this message]
2025-07-17 6:40 ` Peter Wang (王信友)
2025-07-16 6:25 ` [PATCH v1 03/10] ufs: host: mediatek: Add memory barrier for ref-clk control peter.wang
2025-07-16 15:26 ` Bart Van Assche
2025-07-17 6:52 ` Peter Wang (王信友)
2025-07-16 6:25 ` [PATCH v1 04/10] ufs: host: mediatek: Change ref-clk timeout policy peter.wang
2025-07-16 6:25 ` [PATCH v1 05/10] ufs: host: mediatek: Handle broken RTC based on DTS setting peter.wang
2025-07-16 6:25 ` [PATCH v1 06/10] ufs: host: mediatek: Set IRQ affinity policy for MCQ mode peter.wang
2025-07-16 15:27 ` Bart Van Assche
2025-07-17 6:54 ` Peter Wang (王信友)
2025-07-17 15:39 ` Bart Van Assche
2025-07-16 6:25 ` [PATCH v1 07/10] ufs: host: mediatek: Add more UFSCHI hardware versions peter.wang
2025-07-16 6:25 ` [PATCH v1 08/10] ufs: host: mediatek: Add clock scaling query function peter.wang
2025-07-17 5:16 ` kernel test robot
2025-07-16 6:25 ` [PATCH v1 09/10] ufs: host: mediatek: Support clock scaling with Vcore binding peter.wang
2025-07-16 6:25 ` [PATCH v1 10/10] ufs: host: mediatek: Support FDE (AES) clock scaling peter.wang
2025-07-16 8:36 ` [PATCH v1 00/10] ufs: host: mediatek: Provide features and fixes in MediaTek platforms Chun-Hung Wu (巫駿宏)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aafec2c-199a-4373-bdb1-6031f574af6d@acm.org \
--to=bvanassche@acm.org \
--cc=alice.chao@mediatek.com \
--cc=cc.chou@mediatek.com \
--cc=chaotian.jing@mediatek.com \
--cc=chun-hung.wu@mediatek.com \
--cc=ed.tsai@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=jiajie.hao@mediatek.com \
--cc=lin.gui@mediatek.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=naomi.chu@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=qilin.tan@mediatek.com \
--cc=tun-yu.yu@mediatek.com \
--cc=wsd_upstream@mediatek.com \
--cc=yi-fan.peng@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).