Re: [PATCH 15/15] arm64: dts: mediatek: mt7981b-openwrt-one: Enable leds

Andrew Lunn
2025-10-22T12:35:57Z

On Wed, Oct 22, 2025 at 09:26:11AM +0200, Sjoerd Simons wrote:
> Hey,
>
> On Fri, 2025-10-17 at 19:35 +0200, Andrew Lunn wrote:
> > On Thu, Oct 16, 2025 at 12:08:51PM +0200, Sjoerd Simons wrote:
> > > The Openwrt One has 3 status leds at the front (red, white, green) as
> > > well as 2 software controlled leds for the LAN jack (amber, green).
> >
> > A previous patch in this series added 2 PHY LEDs. Are they connected
> > to a LAN jack? Are there multiple RJ45 connectors? Is it clear from
> > /sys/class/leds what LED is what?
>
> Yeah there are two RJ45 jacks. One referred to as WAN in the openwrt one
> documentation (2.5G), which uses phy integrated leds. One referred to as LAN,
> which for some reason is using software controlled leds rather then the phy's
> led controller, which this patch adds support for.
>
> When applying this set you'll get:
> ```
> root@openwrt-debian:/sys/class/leds# ls -1
> amber:lan
> green:lan
> green:status
> mdio-bus:0f:amber:wan
> mdio-bus:0f:green:wan
> mt76-phy0
> mt76-phy1
> red:status
> white:status
> ```
>
> Which is hopefully clear enough

You can also get to the LEDs associated to a MAC via
/sys/class/net/eth42/leds, or a subdirectory.

Please could you expand the commit message with more details of the
different RJ45 connectors, and how the different LEDs map to them.

Thanks

Andrew