From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Guillaume Ranquet <granquet@baylibre.com>,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Jonathan Hunter <jonathanh@nvidia.com>
Subject: Re: [PATCH] phy: mediatek: Avoid floating point constants
Date: Wed, 19 Apr 2023 14:29:08 +0200 [thread overview]
Message-ID: <9d1acd01-b973-2c1c-88dc-170d3c86c4dc@collabora.com> (raw)
In-Reply-To: <20230419122131.2167122-1-thierry.reding@gmail.com>
Il 19/04/23 14:21, Thierry Reding ha scritto:
> From: Thierry Reding <treding@nvidia.com>
>
> When building with old versions of GCC (6.3 in this case), the compiler
> stumbles over the floating point constants in this driver:
>
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c: In function ‘mtk_hdmi_pll_prepare’:
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:331:23: error: ‘-mgeneral-regs-only’ is incompatible with floating-point code
> } else if (pixel_clk >= 74.175 * MEGA && pixel_clk <= 300 * MEGA) {
>
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:361:12: error: ‘-mgeneral-regs-only’ is incompatible with floating-point code
> static int mtk_hdmi_pll_prepare(struct clk_hw *hw)
> ^~~~~~~~~~~~~~~~~~~~
> drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:361:12: error: ‘-mgeneral-regs-only’ is incompatible with floating-point code
>
> Fix this by switching to the KILO macro instead and multiplying the
> constants by 1000 to get rid of the floating point.
>
> Fixes: 45810d486bb4 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195")
> Reported-by: Jonathan Hunter <jonathanh@nvidia.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2023-04-19 12:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 12:21 [PATCH] phy: mediatek: Avoid floating point constants Thierry Reding
2023-04-19 12:29 ` AngeloGioacchino Del Regno [this message]
2023-04-19 13:52 ` Guillaume Ranquet
2023-05-17 11:59 ` Jon Hunter
2023-05-17 12:51 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d1acd01-b973-2c1c-88dc-170d3c86c4dc@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=granquet@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox