Re: [PATCH v8 2/2] arm64: dts: Add MediaTek SoC MT8186 dts and evaluation board and Makefile - allen-kh.cheng

From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	Chen-Yu Tsai <wenst@chromium.org>,
	Ryder Lee <ryder.lee@kernel.org>, <hsinyi@chromium.org>
Subject: Re: [PATCH v8 2/2] arm64: dts: Add MediaTek SoC MT8186 dts and evaluation board and Makefile
Date: Thu, 5 May 2022 20:21:20 +0800	[thread overview]
Message-ID: <9f0d1d279c838bc46d499aa020a6b47a8a25f6f4.camel@mediatek.com> (raw)
In-Reply-To: <20220429213907.d2lwnukugoa7owxn@notapiano>

On Fri, 2022-04-29 at 17:39 -0400, Nícolas F. R. A. Prado wrote:
> On Thu, Apr 28, 2022 at 01:27:41PM -0400, Nícolas F. R. A. Prado
> wrote:
> > Hi Allen,
> > 
> > On Thu, Apr 28, 2022 at 02:17:17PM +0800, Allen-KH Cheng wrote:
> > > +		scp: scp@10500000 {
> > > +			compatible = "mediatek,mt8186-scp";
> > > +			reg = <0 0x10500000 0 0x40000>,
> > > +			      <0 0x105c0000 0 0x19080>;
> > > +			reg-names = "sram", "cfg";
> > 
> > The mtk,scp dt-binding should be updated as it currently doesn't
> > allow l1tcm to
> > be missing. According to comments in the driver cfg is optional as
> > well, so a
> > patch to the binding making both optional would be great.
> 
> Hi Allen,
> 
> actually I've just sent a patch for this myself [1], as it was also
> required for
> mt8192-asurada. Sorry for the noise.
> 
> Thanks,
> Nícolas
> 
> [1] 
> https://lore.kernel.org/all/20220429211111.2214119-2-nfraprado@collabora.com/
> 

Hi Nícolas,

I think I can remove scp node in next version and update this in
another PATCH for [1]. 

thanks,

> > 
> > Thanks,
> > Nícolas

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek