Re: [PATCH v14 27/56] media: coda: Stop direct calls to queue num_buffers field

Andrzej Pietrasiewicz
2023-11-09T10:22:38Z

W dniu 31.10.2023 o 17:30, Benjamin Gaignard pisze:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
> This allows us to change how the number of buffers is computed in the
> future.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Reviewed-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>

> CC: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/media/platform/chips-media/coda-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/chips-media/coda-common.c b/drivers/media/platform/chips-media/coda-common.c
> index cc4892129aaf..f1d85758f6dd 100644
> --- a/drivers/media/platform/chips-media/coda-common.c
> +++ b/drivers/media/platform/chips-media/coda-common.c
> @@ -794,7 +794,7 @@ static int coda_s_fmt(struct coda_ctx *ctx, struct v4l2_format *f,
>
> if (vb2_is_busy(vq)) {
> v4l2_err(&ctx->dev->v4l2_dev, "%s: %s queue busy: %d\n",
> - __func__, v4l2_type_names[f->type], vq->num_buffers);
> + __func__, v4l2_type_names[f->type], vb2_get_num_buffers(vq));
> return -EBUSY;
> }
>