* [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
@ 2025-11-15 10:00 Chukun Pan
2025-11-15 19:54 ` Christian Marangi
2025-11-18 23:02 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Chukun Pan @ 2025-11-15 10:00 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Linus Walleij, Matthias Brugger, angelogioacchino.delregno,
Christian Marangi, Sean Wang, linux-arm-kernel, linux-mediatek,
linux-kernel, linux-gpio, Chukun Pan
The blamed commit made the following changes:
-#define PINCTRL_FUNC_DESC(id)...
- .desc = PINCTRL_PINFUNCTION(#id, ...
+#define PINCTRL_FUNC_DESC(id, table)...
+ .desc = PINCTRL_PINFUNCTION(#id, ...
- PINCTRL_FUNC_DESC(pon)...
+ PINCTRL_FUNC_DESC("pon", pon)...
It's clear that the id of funcs doesn't match the definition.
Remove redundant #string from the definition to fix this issue:
pinctrl-airoha ...: invalid function mdio in map table
Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
index bfcedc7f920b..18c952e44229 100644
--- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
+++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
@@ -35,7 +35,7 @@
#define PINCTRL_FUNC_DESC(id, table) \
{ \
- .desc = PINCTRL_PINFUNCTION(#id, table##_groups, \
+ .desc = PINCTRL_PINFUNCTION(id, table##_groups, \
ARRAY_SIZE(table##_groups)),\
.groups = table##_func_group, \
.group_size = ARRAY_SIZE(table##_func_group), \
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
2025-11-15 10:00 [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue Chukun Pan
@ 2025-11-15 19:54 ` Christian Marangi
2025-11-18 23:02 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Christian Marangi @ 2025-11-15 19:54 UTC (permalink / raw)
To: Chukun Pan
Cc: Lorenzo Bianconi, Linus Walleij, Matthias Brugger,
angelogioacchino.delregno, Sean Wang, linux-arm-kernel,
linux-mediatek, linux-kernel, linux-gpio
On Sat, Nov 15, 2025 at 06:00:00PM +0800, Chukun Pan wrote:
> The blamed commit made the following changes:
>
> -#define PINCTRL_FUNC_DESC(id)...
> - .desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> + .desc = PINCTRL_PINFUNCTION(#id, ...
>
> - PINCTRL_FUNC_DESC(pon)...
> + PINCTRL_FUNC_DESC("pon", pon)...
>
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
>
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Acked-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index bfcedc7f920b..18c952e44229 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -35,7 +35,7 @@
>
> #define PINCTRL_FUNC_DESC(id, table) \
> { \
> - .desc = PINCTRL_PINFUNCTION(#id, table##_groups, \
> + .desc = PINCTRL_PINFUNCTION(id, table##_groups, \
> ARRAY_SIZE(table##_groups)),\
> .groups = table##_func_group, \
> .group_size = ARRAY_SIZE(table##_func_group), \
> --
> 2.25.1
>
--
Ansuel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
2025-11-15 10:00 [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue Chukun Pan
2025-11-15 19:54 ` Christian Marangi
@ 2025-11-18 23:02 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2025-11-18 23:02 UTC (permalink / raw)
To: Chukun Pan
Cc: Lorenzo Bianconi, Matthias Brugger, angelogioacchino.delregno,
Christian Marangi, Sean Wang, linux-arm-kernel, linux-mediatek,
linux-kernel, linux-gpio
On Sat, Nov 15, 2025 at 11:00 AM Chukun Pan <amadeus@jmu.edu.cn> wrote:
> The blamed commit made the following changes:
>
> -#define PINCTRL_FUNC_DESC(id)...
> - .desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> + .desc = PINCTRL_PINFUNCTION(#id, ...
>
> - PINCTRL_FUNC_DESC(pon)...
> + PINCTRL_FUNC_DESC("pon", pon)...
>
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
>
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-11-18 23:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-15 10:00 [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue Chukun Pan
2025-11-15 19:54 ` Christian Marangi
2025-11-18 23:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).