From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60F15CA0EE0 for ; Fri, 15 Aug 2025 04:11:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NS1sCk2jaj6fQ+JKQ824bLbj5DJYUpkN66EHpy4E2b4=; b=opvsSMRMthAPYPWicxCpjw5u/5 ra/Y+Bb/6o9a6tYMRtwEbkMBxuoQF+4z/8SWDHbsgiakTz/AY+k2fUrMuoNZ2D9MJScHf8PMHL9Wb 9Wgqaq8g+RNZyEwis4ibQwemGwm+y2goJVXkEaopyiW6bY9BHLRzASzRQqk3fr8JXBE3Z63uCFmnU 6T1GnbRXboHFKT/9RxkPPi7yjO5Mjs8PgbG5waCWw0T1mu0zGfwn9KEYXFwcirSi6APnHpmvYpGxq xcbL1Nj4HHlMp6fLausi/o1VQ9yK1KDDe9dslFMIjCZdRmtkgbi931Bvz8HrnN1XHozO6fExfVTZb DdQhxQCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1umlma-00000001O9p-1W9n; Fri, 15 Aug 2025 04:11:12 +0000 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1umlW7-00000001LYy-2q13 for linux-mediatek@lists.infradead.org; Fri, 15 Aug 2025 03:54:12 +0000 Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-55ce526627dso1664018e87.3 for ; Thu, 14 Aug 2025 20:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755230050; x=1755834850; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NS1sCk2jaj6fQ+JKQ824bLbj5DJYUpkN66EHpy4E2b4=; b=K+xSoEWQmDs5olwAjMXyir/edSrBRobav+l2xseYB+3Y/5WHCfazfYpuZwNqbKBTsm UzmxEU47J8yzKYCvuZXnNCoegbljDYBR/UVRQAVIcWDDCBwTT2Y7ZIKzvbwwLj1qT2vc QRpHiOz/X98nW3uRjwX11CndgIdq6/ONsdLm8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755230050; x=1755834850; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NS1sCk2jaj6fQ+JKQ824bLbj5DJYUpkN66EHpy4E2b4=; b=hPIp0CJaaEEDRPamo41VSrKuNCPb7Oz4S1/Wdcdvdjqyi/SbDDWQLuZPUwwZ3zi4SB Zd2R/G9LANa4UVVsRN5ZdnMMLTOGhAOfBMYSk2pmTO4Mfv0W9TrH+DnukJpZM3Vedh0P kyg54nEx8umCkx0lVThTUNsAOB2+xXCKLpnMYBDNpIlYVrCxIOshiHDzw9+DwrgheLd2 2wdVFBN8oUPxhT8QZFon3VIJ3y6ctQ0RwoptIEK/kIfq8DC9PedEK4RCPrAUEaQ85Opi Uss9d4ToMDdELfEOQC81LsswpxB0VsaZPwv45PGaqEQMEBnDRhtVPzdHb0EihIKki90b nMKg== X-Forwarded-Encrypted: i=1; AJvYcCVZi4Es2VQY59jT9EzjIZgShUTax42HtuM+P302jGEF0N9V9ltmQfIuEAYW5jJGdFAj8iZxvnrv3cEHxWT2Rg==@lists.infradead.org X-Gm-Message-State: AOJu0YwKDZJTE6P7b6OqF+dXQDfuzm4JaLctDGaSLMIDTdU3iar8Ibbl IaHkx7kn05K0NIH3LJPeQxYsEWEhU3LTUHRZUDmdu9JrdH6O5xmEEi5S9LcBFr21uCngcnLLvM2 sIT+b9KgvZOK3FW1v8Oh5bapbL5s7WSqqsblcQRCJ X-Gm-Gg: ASbGnctf9oko8rQDBLhfFRPC4LLlBRNkmd2u2v56X3GJv+CzZIWfr7nF/6M5k83uvkv G1AO3J22Mx+pMLJhq2sdeIcWzxOxkobjRjWMip9GQ/usuaYoVUzKAgtiKhJyX78IBCMAdHEJC+7 APBNnlS1fULLAFO3JDKGZD9uXoAqWGhKW9qpdFfPdxKX/dr88Td/dvrTPKS7ggQnMrBMMOymn1f MjAlW3xq71adp33TQy/uuk0XsNj3FlaZHsI/A== X-Google-Smtp-Source: AGHT+IGIV7mvkFPQZuFUz43yWCcXkxtysXLVWZnhXnNTP1ZgJAEPVlAYJWIr84Go4WLQoos1hIvAKUr4yPJ/fc7kwL0= X-Received: by 2002:a05:6512:2256:b0:55a:2f6e:99bf with SMTP id 2adb3069b0e04-55ceeb0da8amr172578e87.37.1755230049594; Thu, 14 Aug 2025 20:54:09 -0700 (PDT) MIME-Version: 1.0 References: <20250805135447.149231-1-laura.nao@collabora.com> <20250805135447.149231-17-laura.nao@collabora.com> In-Reply-To: <20250805135447.149231-17-laura.nao@collabora.com> From: Chen-Yu Tsai Date: Fri, 15 Aug 2025 12:53:58 +0900 X-Gm-Features: Ac12FXzPhchsvkR2KgC75ucJdBbVv2BRvVoAd0vv5jb3C5Va-SRZ59TCxVHQ5SA Message-ID: Subject: Re: [PATCH v4 16/27] clk: mediatek: Add MT8196 pextpsys clock support To: Laura Nao Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, p.zabel@pengutronix.de, richardcochran@gmail.com, guangjie.song@mediatek.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, kernel@collabora.com, =?UTF-8?B?TsOtY29sYXMgRiAuIFIgLiBBIC4gUHJhZG8=?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250814_205411_711231_D3A7B173 X-CRM114-Status: GOOD ( 21.29 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Aug 5, 2025 at 10:55=E2=80=AFPM Laura Nao = wrote: > > Add support for the MT8196 pextpsys clock controller, which provides > clock gate control for PCIe. > > Reviewed-by: N=C3=ADcolas F. R. A. Prado > Co-developed-by: AngeloGioacchino Del Regno > Signed-off-by: AngeloGioacchino Del Regno > Signed-off-by: Laura Nao > --- > drivers/clk/mediatek/Kconfig | 7 ++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8196-pextp.c | 131 ++++++++++++++++++++++++ > 3 files changed, 139 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8196-pextp.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index d99c39a7f10e..c977719046a4 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -1010,6 +1010,13 @@ config COMMON_CLK_MT8196 > help > This driver supports MediaTek MT8196 basic clocks. > > +config COMMON_CLK_MT8196_PEXTPSYS > + tristate "Clock driver for MediaTek MT8196 pextpsys" > + depends on COMMON_CLK_MT8196 > + default COMMON_CLK_MT8196 > + help > + This driver supports MediaTek MT8196 pextpsys clocks. > + > config COMMON_CLK_MT8196_UFSSYS > tristate "Clock driver for MediaTek MT8196 ufssys" > depends on COMMON_CLK_MT8196 > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefil= e > index 1a497de00846..88f7d8a229c2 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -153,6 +153,7 @@ obj-$(CONFIG_COMMON_CLK_MT8195_WPESYS) +=3D clk-mt819= 5-wpe.o > obj-$(CONFIG_COMMON_CLK_MT8196) +=3D clk-mt8196-apmixedsys.o clk-mt8196-= topckgen.o \ > clk-mt8196-topckgen2.o clk-mt8196-vlpc= kgen.o \ > clk-mt8196-peri_ao.o > +obj-$(CONFIG_COMMON_CLK_MT8196_PEXTPSYS) +=3D clk-mt8196-pextp.o > obj-$(CONFIG_COMMON_CLK_MT8196_UFSSYS) +=3D clk-mt8196-ufs_ao.o > obj-$(CONFIG_COMMON_CLK_MT8365) +=3D clk-mt8365-apmixedsys.o clk-mt8365.= o > obj-$(CONFIG_COMMON_CLK_MT8365_APU) +=3D clk-mt8365-apu.o > diff --git a/drivers/clk/mediatek/clk-mt8196-pextp.c b/drivers/clk/mediat= ek/clk-mt8196-pextp.c > new file mode 100644 > index 000000000000..9a7623bf2b1c > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8196-pextp.c > @@ -0,0 +1,131 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2025 MediaTek Inc. > + * Guangjie Song > + * Copyright (c) 2025 Collabora Ltd. > + * Laura Nao > + */ > +#include > +#include Nit: empty line here for separation. > +#include > +#include > +#include > +#include > + > +#include "clk-gate.h" > +#include "clk-mtk.h" > +#include "reset.h" > + > +#define MT8196_PEXTP_RST0_SET_OFFSET 0x8 > + > +static const struct mtk_gate_regs pext_cg_regs =3D { > + .set_ofs =3D 0x18, > + .clr_ofs =3D 0x1c, > + .sta_ofs =3D 0x14, > +}; > + > +#define GATE_PEXT(_id, _name, _parent, _shift) {\ > + .id =3D _id, \ > + .name =3D _name, \ > + .parent_name =3D _parent, \ > + .regs =3D &pext_cg_regs, \ > + .shift =3D _shift, \ > + .flags =3D CLK_OPS_PARENT_ENABLE, \ Same issue as the previous patch. If one of the parents shown below needs to be enabled for register access, this is going to fail badly. If it's not needed, then this flag makes no sense here. ChenYu > + .ops =3D &mtk_clk_gate_ops_setclr,\ > + } > + > +static const struct mtk_gate pext_clks[] =3D { > + GATE_PEXT(CLK_PEXT_PEXTP_MAC_P0_TL, "pext_pm0_tl", "tl", 0), > + GATE_PEXT(CLK_PEXT_PEXTP_MAC_P0_REF, "pext_pm0_ref", "clk26m", 1)= , > + GATE_PEXT(CLK_PEXT_PEXTP_PHY_P0_MCU_BUS, "pext_pp0_mcu_bus", "clk= 26m", 6), > + GATE_PEXT(CLK_PEXT_PEXTP_PHY_P0_PEXTP_REF, "pext_pp0_pextp_ref", = "clk26m", 7), > + GATE_PEXT(CLK_PEXT_PEXTP_MAC_P0_AXI_250, "pext_pm0_axi_250", "ufs= _pexpt0_mem_sub", 12), > + GATE_PEXT(CLK_PEXT_PEXTP_MAC_P0_AHB_APB, "pext_pm0_ahb_apb", "ufs= _pextp0_axi", 13), > + GATE_PEXT(CLK_PEXT_PEXTP_MAC_P0_PL_P, "pext_pm0_pl_p", "clk26m", = 14), > + GATE_PEXT(CLK_PEXT_PEXTP_VLP_AO_P0_LP, "pext_pextp_vlp_ao_p0_lp",= "clk26m", 19), > +}; > + > +static u16 pext_rst_ofs[] =3D { MT8196_PEXTP_RST0_SET_OFFSET }; > + > +static u16 pext_rst_idx_map[] =3D { > + [MT8196_PEXTP0_RST0_PCIE0_MAC] =3D 0, > + [MT8196_PEXTP0_RST0_PCIE0_PHY] =3D 1, > +}; > + > +static const struct mtk_clk_rst_desc pext_rst_desc =3D { > + .version =3D MTK_RST_SET_CLR, > + .rst_bank_ofs =3D pext_rst_ofs, > + .rst_bank_nr =3D ARRAY_SIZE(pext_rst_ofs), > + .rst_idx_map =3D pext_rst_idx_map, > + .rst_idx_map_nr =3D ARRAY_SIZE(pext_rst_idx_map), > +}; > + > +static const struct mtk_clk_desc pext_mcd =3D { > + .clks =3D pext_clks, > + .num_clks =3D ARRAY_SIZE(pext_clks), > + .rst_desc =3D &pext_rst_desc, > +}; > + > +static const struct mtk_gate pext1_clks[] =3D { > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P1_TL, "pext1_pm1_tl", "tl_p1", 0), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P1_REF, "pext1_pm1_ref", "clk26m", = 1), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P2_TL, "pext1_pm2_tl", "tl_p2", 2), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P2_REF, "pext1_pm2_ref", "clk26m", = 3), > + GATE_PEXT(CLK_PEXT1_PEXTP_PHY_P1_MCU_BUS, "pext1_pp1_mcu_bus", "c= lk26m", 8), > + GATE_PEXT(CLK_PEXT1_PEXTP_PHY_P1_PEXTP_REF, "pext1_pp1_pextp_ref"= , "clk26m", 9), > + GATE_PEXT(CLK_PEXT1_PEXTP_PHY_P2_MCU_BUS, "pext1_pp2_mcu_bus", "c= lk26m", 10), > + GATE_PEXT(CLK_PEXT1_PEXTP_PHY_P2_PEXTP_REF, "pext1_pp2_pextp_ref"= , "clk26m", 11), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P1_AXI_250, "pext1_pm1_axi_250", > + "pextp1_usb_axi", 16), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P1_AHB_APB, "pext1_pm1_ahb_apb", > + "pextp1_usb_mem_sub", 17), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P1_PL_P, "pext1_pm1_pl_p", "clk26m"= , 18), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P2_AXI_250, "pext1_pm2_axi_250", > + "pextp1_usb_axi", 19), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P2_AHB_APB, "pext1_pm2_ahb_apb", > + "pextp1_usb_mem_sub", 20), > + GATE_PEXT(CLK_PEXT1_PEXTP_MAC_P2_PL_P, "pext1_pm2_pl_p", "clk26m"= , 21), > + GATE_PEXT(CLK_PEXT1_PEXTP_VLP_AO_P1_LP, "pext1_pextp_vlp_ao_p1_lp= ", "clk26m", 26), > + GATE_PEXT(CLK_PEXT1_PEXTP_VLP_AO_P2_LP, "pext1_pextp_vlp_ao_p2_lp= ", "clk26m", 27), > +}; > + > +static u16 pext1_rst_idx_map[] =3D { > + [MT8196_PEXTP1_RST0_PCIE1_MAC] =3D 0, > + [MT8196_PEXTP1_RST0_PCIE1_PHY] =3D 1, > + [MT8196_PEXTP1_RST0_PCIE2_MAC] =3D 8, > + [MT8196_PEXTP1_RST0_PCIE2_PHY] =3D 9, > +}; > + > +static const struct mtk_clk_rst_desc pext1_rst_desc =3D { > + .version =3D MTK_RST_SET_CLR, > + .rst_bank_ofs =3D pext_rst_ofs, > + .rst_bank_nr =3D ARRAY_SIZE(pext_rst_ofs), > + .rst_idx_map =3D pext1_rst_idx_map, > + .rst_idx_map_nr =3D ARRAY_SIZE(pext1_rst_idx_map), > +}; > + > +static const struct mtk_clk_desc pext1_mcd =3D { > + .clks =3D pext1_clks, > + .num_clks =3D ARRAY_SIZE(pext1_clks), > + .rst_desc =3D &pext1_rst_desc, > +}; > + > +static const struct of_device_id of_match_clk_mt8196_pextp[] =3D { > + { .compatible =3D "mediatek,mt8196-pextp0cfg-ao", .data =3D &pext= _mcd }, > + { .compatible =3D "mediatek,mt8196-pextp1cfg-ao", .data =3D &pext= 1_mcd }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, of_match_clk_mt8196_pextp); > + > +static struct platform_driver clk_mt8196_pextp_drv =3D { > + .probe =3D mtk_clk_simple_probe, > + .remove =3D mtk_clk_simple_remove, > + .driver =3D { > + .name =3D "clk-mt8196-pextp", > + .of_match_table =3D of_match_clk_mt8196_pextp, > + }, > +}; > + > +module_platform_driver(clk_mt8196_pextp_drv); > +MODULE_DESCRIPTION("MediaTek MT8196 PCIe transmit phy clocks driver"); > +MODULE_LICENSE("GPL"); > -- > 2.39.5 >