Linux-mediatek Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Daniel Golle" <daniel@makrotopia.org>, <Hermes.Wu@ite.com.tw>
Cc: <luca.ceresoli@bootlin.com>, <andrzej.hajda@intel.com>,
	<neil.armstrong@linaro.org>, <rfoss@kernel.org>,
	<Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
	<jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>,
	<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
	<simona@ffwll.ch>, <matthias.bgg@gmail.com>,
	<angelogioacchino.delregno@collabora.com>,
	<allen.chen@ite.com.tw>, <treapking@chromium.org>,
	<wenst@chromium.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v8 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print
Date: Thu, 19 Nov 2026 18:05:07 +0100	[thread overview]
Message-ID: <DMZCN8AD4WMD.2ZO1SYMI93O3M@bootlin.com> (raw)
In-Reply-To: <av8jL0W1vgdqPQhu@makrotopia.org>

On Thu Nov 19, 2026 at 5:26 PM CET, Daniel Golle wrote:
> On Wed, Nov 18, 2026 at 03:12:14AM +0000, Hermes.Wu@ite.com.tw wrote:
>> Hi Daniel, Luca,
>>
>> On Mon, Nov 16, 2026 at 08:56:18AM +0000, Daniel Golle wrote:
>> > On Tue, Oct 20, 2026 at 06:51:39PM +0200, Luca Ceresoli wrote:
>> > > If you could share what that register is for, it would probably answer some
>> > > of those questions.
>> >
>> > I don't have documentation for it either, and with ITE gone there is
>> > nobody left to ask.
>>
>> REG_AUDIO_INPUT_FREQ (0xBE) is a read-only input audio frequency
>> counter. The driver uses it to check whether the I2S BCLK is
>> present and changing, i.e. whether there is audio input.
>
> Great to see you are actually still around, and thank you for confirming
> that we can drop the register read there.
>
> I was afraid the bouncing emails of the former driver maintainers would
> indicate the driver has now been orphaned. It'd hence be great if you
> can enlist yourself in the MAINTAINERS file for that driver.
>
>> > As for the logging, I don't think it is worth an extra i2c read and a
>> > division in the enable path, so in v9 I'll drop the read and the
>> > print from it6505_enable_audio() instead of guarding the division.
>>
>> Fine with us, the value is only informational there.
>
> +1

Ah, great, thanks Hermes for the feedback and Daniel for the patience in
getting to the bottom of this!

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


  reply	other threads:[~2026-11-19 17:05 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27 23:49 [PATCH v8 00/14] drm/bridge: it6505: DP audio support + shared-DAI hw_params fix Daniel Golle
2026-09-27 23:49 ` [PATCH v8 01/14] drm/bridge: it6505: quiesce event sources and work on remove() Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:49 ` [PATCH v8 02/14] drm/bridge: it6505: quiesce work items before powering off Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:49 ` [PATCH v8 03/14] drm/bridge: it6505: balance and disable runtime PM on remove Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 04/14] drm/bridge: it6505: unregister DP AUX adapter on bridge detach Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:52     ` Daniel Golle
2026-09-27 23:50 ` [PATCH v8 05/14] drm/bridge: it6505: complete poweroff even if disabling regulators fails Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 06/14] drm/bridge: it6505: bail out of the IRQ handler when status reads fail Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:55     ` Daniel Golle
2026-11-19 17:08       ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 07/14] drm/bridge: it6505: avoid division by zero in pixel clock calculation Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-09-27 23:50 ` [PATCH v8 08/14] drm/bridge: it6505: avoid division by zero in audio FS debug print Daniel Golle
2026-10-20 16:51   ` Luca Ceresoli
2026-11-16  8:56     ` Daniel Golle
2026-11-18  3:12       ` Hermes.Wu
2026-11-19 16:26         ` Daniel Golle
2026-11-19 17:05           ` Luca Ceresoli [this message]
2026-09-27 23:50 ` [PATCH v8 09/14] drm/bridge: it6505: guard against zero channel count in audio infoframe Daniel Golle
2026-09-27 23:50 ` [PATCH v8 10/14] drm/bridge: it6505: hold endpoint OF node reference while parsing it Daniel Golle
2026-09-27 23:51 ` [PATCH v8 11/14] drm/bridge: it6505: reject a too short link-frequencies property Daniel Golle
2026-09-27 23:51 ` [PATCH v8 12/14] drm/bridge: it6505: don't write an error code back to the reset register Daniel Golle
2026-09-27 23:51 ` [PATCH v8 13/14] drm/bridge: it6505: Add audio support Daniel Golle
2026-09-27 23:51 ` [PATCH v8 14/14] drm/bridge: it6505: Don't reject audio hw_params without an encoder Daniel Golle
2026-11-14 12:19 ` [PATCH v8 00/14] drm/bridge: it6505: DP audio support + shared-DAI hw_params fix Daniel Golle
2026-11-16  7:22   ` Luca Ceresoli
2026-11-16  9:00     ` Daniel Golle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DMZCN8AD4WMD.2ZO1SYMI93O3M@bootlin.com \
    --to=luca.ceresoli@bootlin.com \
    --cc=Hermes.Wu@ite.com.tw \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=allen.chen@ite.com.tw \
    --cc=andrzej.hajda@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=daniel@makrotopia.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=treapking@chromium.org \
    --cc=tzimmermann@suse.de \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox