From: "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
To: DENG Qingfang <dqfext@gmail.com>,
Landen Chao <Landen.Chao@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: [PATCH RFC net-next 5/7] net: dsa: mt7530: RGMII can support 1000base-X
Date: Thu, 03 Feb 2022 17:31:38 +0000 [thread overview]
Message-ID: <E1nFfxK-006X72-Es@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <YfwRN2ObqFbrw/fF@shell.armlinux.org.uk>
When using an external PHY connected using RGMII to mt7531 port 5, the
PHY can be used to used support 1000baseX connections. Therefore, it
makes no sense to exclude this from the linkmodes permitted for mt7531
port 5, so allow 1000baseX.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/dsa/mt7530.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index cbdf4a58e507..a2fa629cccc0 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2523,9 +2523,6 @@ static void mt7531_sgmii_validate(struct mt7530_priv *priv, int port,
*/
switch (port) {
case 5:
- if (mt7531_is_rgmii_port(priv, port))
- break;
- fallthrough;
case 6:
if (interface == PHY_INTERFACE_MODE_2500BASEX) {
phylink_set(supported, 2500baseX_Full);
--
2.30.2
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-02-03 17:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 17:30 [PATCH RFC net-next 0/7] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-02-03 17:31 ` [PATCH RFC net-next 1/7] net: dsa: mt7530: populate supported_interfaces Russell King (Oracle)
2022-02-03 17:31 ` [PATCH RFC net-next 2/7] net: dsa: mt7530: remove interface checks Russell King (Oracle)
2022-02-03 17:31 ` [PATCH RFC net-next 3/7] net: dsa: mt7530: drop use of phylink_helper_basex_speed() Russell King (Oracle)
2022-02-03 17:31 ` [PATCH RFC net-next 4/7] net: dsa: mt7530: only indicate linkmodes that can be supported Russell King (Oracle)
2022-02-03 17:31 ` Russell King (Oracle) [this message]
2022-02-03 17:31 ` [PATCH RFC net-next 6/7] net: dsa: mt7530: switch to use phylink_get_linkmodes() Russell King (Oracle)
2022-02-03 17:31 ` [PATCH RFC net-next 7/7] net: dsa: mt7530: mark as non-legacy Russell King (Oracle)
2022-02-09 13:06 ` [PATCH RFC net-next 0/7] net: dsa: mt7530: updates for phylink changes Russell King (Oracle)
2022-02-09 17:33 ` Landen Chao
2022-02-09 17:47 ` Russell King (Oracle)
2022-02-09 19:15 ` Landen Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1nFfxK-006X72-Es@rmk-PC.armlinux.org.uk \
--to=rmk+kernel@armlinux.org.uk \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sean.wang@mediatek.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).