From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 223D2C4332F for ; Tue, 11 Oct 2022 16:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eHTu+jpaYBMLUQabAnLsno2Wxt1SpeKJrEe3RVshSbc=; b=WmglSZx06Sxozq/B4vW+wxNelu Zxf8dw2n2uCkUY+/voP96vSpnWD1+6p3yGYoQY0lhxsZSeSvi/SpmxoB00JKrlulfAl9F8q8nM+M7 7NQPAgHD9UGmC0O26Bo9iG5y59G/lb8OP3I7CpDw/6BrjfGXb34nVKSi1clyq2dnThN6kt1L+YcTA +PMl+P6ufCHwEmr2kmriy4tCIa/8wc2T2hLNZezO4OMPbCiguKGB0ZBUBuyqBr28zGzupuEzdWY6Q 20e5BZLWWxbRLrGn64pE6HUEYcxdBtJdBAgnJ/l1cZESDl8B19Bsav+oD/7/pE00QS4Olcm3kQ6nI P/m3E5cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiHvL-0057ja-Lc; Tue, 11 Oct 2022 16:16:07 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oiH2P-004kC1-8a; Tue, 11 Oct 2022 15:19:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665501561; x=1697037561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hq8H9GCveZZvFxxgF//YL8HEPEJFc1DXWo1WrcAUuRw=; b=T58a0a4gPHexpkLrVPVEgsI5atdoYyPzu5QxjzCl4RUx8NiY8+ghpxEb buitWT1VP8LBAJDuIZMGACoRagKDAXGnLznA9OXgTjRoAiEK62FVUAIi7 zLwCP8PK0FnbxRk34AMruYHTRyXqAADBKYZnO/hgMkbA3Kr1DWS75mFMi BK76/RPTW/3tOW0vaQapTBkDuB/HuNTGqgajS+odI5h9s9qvONdLpUt6C ALu/Q7sDQpcX7Z6gczhi3fYwm+5JWGDEfbn54Lmavkj4omWGFlSeM8Rp+ 40QZNeOLrir/maD2KRA1lv9HIj9qTac5SWrNMmWp9Jf7XlJoyoLvNYQ9h w==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="284259259" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="284259259" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 08:19:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="955372479" X-IronPort-AV: E=Sophos;i="5.95,176,1661842800"; d="scan'208";a="955372479" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP; 11 Oct 2022 08:19:15 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1oiH2H-005NYA-25; Tue, 11 Oct 2022 18:19:13 +0300 Date: Tue, 11 Oct 2022 18:19:13 +0300 From: Andy Shevchenko To: Geert Uytterhoeven Cc: Kent Gibson , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-actions@lists.infradead.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-omap@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 02/36] gpiolib: cdev: Add missed header(s) Message-ID: References: <20221010201453.77401-1-andriy.shevchenko@linux.intel.com> <20221010201453.77401-3-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221011_081921_358199_59CD7AE2 X-CRM114-Status: GOOD ( 23.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, Oct 11, 2022 at 04:39:46PM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 11, 2022 at 4:31 PM Andy Shevchenko > wrote: > > On Tue, Oct 11, 2022 at 10:13:02PM +0800, Kent Gibson wrote: > > > On Tue, Oct 11, 2022 at 04:48:17PM +0300, Andy Shevchenko wrote: > > > > On Tue, Oct 11, 2022 at 11:05:42AM +0300, Andy Shevchenko wrote: > > > > > On Tue, Oct 11, 2022 at 3:02 AM Kent Gibson wrote: > > > > > > On Mon, Oct 10, 2022 at 11:14:18PM +0300, Andy Shevchenko wrote: ... > > > > > > > -#include > > > > > > > #include > > > > > > > +#include > > > > > > > +#include > > > > > > > > > > > > Ok with the hte re-order. > > > > > > > > > > > > But moving the gpio subsystem header after the gpio/driver is not > > > > > > alphabetical ('.' precedes '/') and it read better and made more sense > > > > > > to me the way it was. > > > > > > > > > > I see, I guess this is vim sort vs shell sort. Strange, they should > > > > > follow the locale settings... > > > > > > > > I have checked, the shell and vim sort gave the same result as in this patch. > > > > > > > > > > The original order (sans hte.h) was done by VSCode Sort Lines Ascending, > > > and that still returns the same result. That matches what I would > > > expect to see given the content of the text. > > > > > > And for me vim also gives the original order. > > > > > > Just to confirm - is '.' 0x2e and '/' 0x2f in your universe? > > > > $ LC_COLLATE=C sort test1.txt > > #include > > #include > > > > $ LC_COLLATE= sort test1.txt > > #include > > #include > > > > I guess this explains the difference. Currently I have en_US.UTF-8. > > Throwing my can of paint into the mix... > > I think it is more logical to first include the general , > followed by whatever and , > irrespective of (language-specific or phonebook) sort order. > > Yeah, it sucks that this requires some manual work after running sort... It seems that kind of issue is in this patch only. -- With Best Regards, Andy Shevchenko