Re: [PATCH v4 2/9] dt-bindings: rtc: mediatek: convert MT6397 rtc documentation

Alexandre Belloni
2022-11-14T22:57:36Z

On 10/11/2022 15:14:01+0100, Krzysztof Kozlowski wrote:
> On 09/11/2022 23:57, Alexandre Belloni wrote:
> > On 09/11/2022 16:29:16-0600, Rob Herring wrote:
> >> On Tue, Nov 08, 2022 at 07:43:37PM +0100, Alexandre Mergnat wrote:
> >>> - Convert rtc/rtc-mt6397.txt to rtc/mt6397-rtc.yaml
> >>> - Add mediatek,mt6357-rtc compatible.
> >>> - Add maintainer
> >>> - Remove the .txt binding file
> >>>
> >>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> >>> ---
> >>> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 +-
> >>> .../bindings/rtc/mediatek,mt6397-rtc.yaml | 40 ++++++++++++++++++++++
> >>> .../devicetree/bindings/rtc/rtc-mt6397.txt | 31 -----------------
> >>> 3 files changed, 41 insertions(+), 32 deletions(-)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> index 0088442efca1..79aaf21af8e9 100644
> >>> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt
> >>> @@ -33,7 +33,7 @@ Optional subnodes:
> >>> - compatible: "mediatek,mt6331-rtc"
> >>> - compatible: "mediatek,mt6358-rtc"
> >>> - compatible: "mediatek,mt6397-rtc"
> >>> - For details, see ../rtc/rtc-mt6397.txt
> >>> + For details, see ../rtc/mediatek,mt6397-rtc.yaml
> >>> - regulators
> >>> Required properties:
> >>> - compatible: "mediatek,mt6323-regulator"
> >>> diff --git a/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> >>> new file mode 100644
> >>> index 000000000000..bb48c0150f95
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/rtc/mediatek,mt6397-rtc.yaml
> >>> @@ -0,0 +1,40 @@
> >>> + # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/rtc/mediatek,mt6397-rtc.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: MediaTek MT6397/MT6366/MT6358/MT6357/MT6323 RTC
> >>> +
> >>> +maintainers:
> >>> + - Alexandre Mergnat <amergnat@baylibre.com>
> >>> +
> >>> +description: |
> >>> + MediaTek PMIC based RTC is an independent function of MediaTek PMIC that works
> >>> + as a type of multi-function device (MFD). The RTC can be configured and set up
> >>> + with PMIC wrapper bus which is a common resource shared with the other
> >>> + functions found on the same PMIC.
> >>> +
> >>> +properties:
> >>> + compatible:
> >>> + enum:
> >>> + - mediatek,mt6323-rtc
> >>> + - mediatek,mt6357-rtc
> >>> + - mediatek,mt6358-rtc
> >>> + - mediatek,mt6366-rtc
> >>> + - mediatek,mt6397-rtc
> >>
> >> As this is only a compatible string, just fold this into the MFD schema
> >> doc.
> >
> > Actually, it probably also supports the start-year property
>

I checked and it doesn't support it but this needs to be fixed.

> What about rest of rtc.yaml schema?
>

wakeup-source would make sense but the driver doesn't support it yet.

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering