From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE292C46467 for ; Mon, 16 Jan 2023 16:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gFuyelicB2QFX6LrQoE6wpQRJWFtNcb69z+Tk9PIWPc=; b=1yWSLtmLL84kWG84YO3OP0elSV Tt0ZQCBFWminNnLrS/rPFVo2KBGKfqX51W2cuuN3OuSu1jj6TRHRkFlbQSJ/d2n8xxUdFI6VTwZ+i 2P0PR2MUiI52TuTl9tCOzuX4mmIRwnUnQezBf/kOLLTSkMdRrWP9c9/MsCVKOmVcTnhzPotw4ISLR H6ZodQMcAFdpZGWCWE3euGnBXX1haYz/3DxCQmqefRxsqTZwMgroFX6iEO4evdlpvR0tNNxekQbWG mZsnfRtp74pAUqoevFMLFDgmP1ssEs/+O2Ehrvr/crO+TytDsNhokikrMVhSxCUL0HvgUo0Zbu9ch H+NrIRow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHSaC-00BRCu-FU; Mon, 16 Jan 2023 16:43:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHSa9-00BR9A-AE; Mon, 16 Jan 2023 16:43:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gFuyelicB2QFX6LrQoE6wpQRJWFtNcb69z+Tk9PIWPc=; b=RDZdnm0nIbvuFgz3GKJ/cdtdS0 he7c3RzhKJPfipw1gAHWAMTZfzt8GXsgPd3o9jpcr2eLLorRcO9btRUbLlYy4mjQ7sduzF6TEo1Hx tn39KTtJ2LNc5HpYym0zTdAkxu3I8kNLyzLM++kFs+B2pjCx3ENhLM6QNcBSTLcBwoZqHXZyRJwwP Xdr0cqR6uOQakXpVnJoJDVkrYJ0xa+TJCxBcIFVUEQllmDSyPdn6V3AsL1fVZQp15Bt9l6Q3bIA+b sg0cX7CdCRDG/Uyg/Asw3oSQmD+N11GQavK8H4G18E3dNGWT3V54JyJLgHskHQTStSckFAX+vajYv om6G1E0g==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36134) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pHSZx-0005RP-Gn; Mon, 16 Jan 2023 16:43:25 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pHSZq-0006AQ-29; Mon, 16 Jan 2023 16:43:18 +0000 Date: Mon, 16 Jan 2023 16:43:18 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <87o7qy39v5.fsf@miraculix.mork.no> <87h6wq35dn.fsf@miraculix.mork.no> <87bkmy33ph.fsf@miraculix.mork.no> <875yd630cu.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <875yd630cu.fsf@miraculix.mork.no> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_084337_376671_578DC2D0 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Sean Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Eric Dumazet , Alexander Couzens , John Crispin , Matthias Brugger , linux-mediatek@lists.infradead.org, Frank Wunderlich , Paolo Abeni , Mark Lee , linux-arm-kernel@lists.infradead.org, Felix Fietkau Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 05:33:53PM +0100, Bjørn Mork wrote: > "Russell King (Oracle)" writes: > > > On Mon, Jan 16, 2023 at 04:21:30PM +0100, Bjørn Mork wrote: > >> [ 54.539438] mtk_soc_eth 15100000.ethernet wan: Link is Down > >> [ 56.619937] mtk_sgmii_select_pcs: id=1 > >> [ 56.623690] mtk_pcs_config: interface=4 > >> [ 56.627511] offset:0 0x140 > >> [ 56.627513] offset:4 0x4d544950 > >> [ 56.630215] offset:8 0x20 > >> [ 56.633340] forcing AN > >> [ 56.638292] mtk_pcs_config: rgc3=0x0, advertise=0x1 (changed), link_timer=1600000, sgm_mode=0x103, bmcr=0x1000, use_an=1 > >> [ 56.649226] mtk_pcs_link_up: interface=4 > >> [ 56.653135] offset:0 0x81140 > >> [ 56.653137] offset:4 0x4d544950 > >> [ 56.656001] offset:8 0x1 > >> [ 56.659137] mtk_soc_eth 15100000.ethernet wan: Link is Up - 1Gbps/Full - flow control rx/tx > > > > Thanks - there seems to be something weird with the bmcr value printed > > above in the mtk_pcs_config line. > > > > You have bmcr=0x1000, but the code sets two bits - SGMII_AN_RESTART and > > SGMII_AN_ENABLE which are bits 9 and 12, so bmcr should be 0x1200, not > > 0x1000. Any ideas why? > > No, not really > > > Can you also hint at what the bits in the PHY register you quote mean > > please? > > This could very well be a red herring. It's the only difference I've > been able to spot, but I have no idea what it means. > > This is an attempt at reformatting the pdf tables for email. Hope it's > readable: I found the document for the PHY at: https://assets.maxlinear.com/web/documents/617792_gpy212b1vc_gpy212c0vc_ds_rev1.3.pdf It seems as I suspected, the PHY has not completed SGMII AN. Please can you read register 8 when operating at 1G speeds as well (VSPEC1_SGMII_CTRL)? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!