Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer

From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	Liviu Dudau <liviu.dudau@arm.com>,
	dri-devel@lists.freedesktop.org,
	Russell King <linux@armlinux.org.uk>,
	Paul Cercueil <paul@crapouillou.net>,
	Thierry Reding <thierry.reding@gmail.com>,
	Gerd Hoffmann <kraxel@redhat.com>,
	Anitha Chrisanthus <anitha.chrisanthus@intel.com>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Jerome Brunet <jbrunet@baylibre.com>, Marek Vasut <marex@denx.de>,
	linux-renesas-soc@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	linux-rockchip@lists.infradead.org,
	Alexey Brodkin <abrodkin@synopsys.com>,
	Michal Simek <michal.simek@xilinx.com>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Roland Scheidegger <sroland@vmware.com>,
	Xinliang Liu <xinliang.liu@linaro.org>,
	Chen-Yu Tsai <wens@csie.org>,
	VMware Graphics <linux-graphics-maintainer@vmware.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Chen Feng <puck.chen@hisilicon.com>,
	Dave Airlie <airlied@redhat.com>,
	Xinwei Kong <kong.kongxinwei@hisilicon.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-arm-msm@vger.kernel.org,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Alison Wang <alison.wang@nxp.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	linux-mips@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
	linux-tegra@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-mediatek@lists.infradead, Hyun Kwon <hyun.kwon@xilinx.com>,
	Philippe Cornu <philippe.cornu@st.com>,
	Sandy Huang <hjc@rock-chips.com>,
	Yannick Fertre <yannick.fertre@st.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	freedreno@lists.freedesktop.org
Subject: Re: [PATCH v2 10/11] drm: Use state helper instead of the plane state pointer
Date: Tue, 26 Jan 2021 15:24:35 +0200	[thread overview]
Message-ID: <YBAYE4YH4bgURmuf@intel.com> (raw)
In-Reply-To: <20210121163537.1466118-10-maxime@cerno.tech>

On Thu, Jan 21, 2021 at 05:35:35PM +0100, Maxime Ripard wrote:
> Many drivers reference the plane->state pointer in order to get the
> current plane state in their atomic_update or atomic_disable hooks,
> which would be the new plane state in the global atomic state since
> _swap_state happened when those hooks are run.
> 
> Use the drm_atomic_get_new_plane_state helper to get that state to make it
> more obvious.
> 
> This was made using the coccinelle script below:
> 
> @ plane_atomic_func @
> identifier helpers;
> identifier func;
> @@
> 
> (
>  static const struct drm_plane_helper_funcs helpers = {
>  	...,
>  	.atomic_disable = func,
> 	...,
>  };
> |
>  static const struct drm_plane_helper_funcs helpers = {
>  	...,
>  	.atomic_update = func,
> 	...,
>  };
> )
> 
> @ adds_new_state @
> identifier plane_atomic_func.func;
> identifier plane, state;
> identifier new_state;
> @@
> 
>  func(struct drm_plane *plane, struct drm_atomic_state *state)
>  {
>  	...
> -	struct drm_plane_state *new_state = plane->state;
> +	struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane);
> 	...
>  }
> 
> @ include depends on adds_new_state @
> @@
> 
>  #include <drm/drm_atomic.h>
> 
> @ no_include depends on !include && adds_new_state @
> @@
> 
> + #include <drm/drm_atomic.h>
>   #include <drm/...>
> 
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>

Looks great.

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

-- 
Ville Syrjälä
Intel

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek