From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Tinghan Shen <tinghan.shen@mediatek.com>
Subject: Re: [PATCH] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP
Date: Wed, 17 Mar 2021 20:33:50 -0500 [thread overview]
Message-ID: <YFKt/mGha/IQRDz4@builder.lan> (raw)
In-Reply-To: <CA+Px+wWnB0ZigyVsOHhEnNDCEToOEF6JZSGQFNq1SZE3TyxH2Q@mail.gmail.com>
On Wed 17 Mar 20:27 CDT 2021, Tzung-Bi Shih wrote:
> On Thu, Mar 18, 2021 at 3:14 AM Bjorn Andersson
> <bjorn.andersson@linaro.org> wrote:
> >
> > On Tue 16 Mar 22:43 CDT 2021, Tzung-Bi Shih wrote:
> >
> > > DEVAPC (device access permission control) is a MPU (memory protection
> > > unit) in MT8192.
> > >
> > > To restrict SCP accesses to a specific memory range, sets SCP to DEVAPC
> > > domain 3. ATF (Arm trusted firmware) should setup memory range for the
> > > domain.
> > >
> > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> >
> > As written here Tinghan is the author of the commit, but the author of
> > the patch is Tzung-Bi. Please resolve this.
>
> Tinghan is the co-author of the patch. Added "Co-developed-by" tag in v2[1].
>
Perfect, thank you!
> [1]: https://patchwork.kernel.org/project/linux-remoteproc/patch/20210318012416.2816574-1-tzungbi@google.com/
>
> >
> > Regards,
> > Bjorn
> >
> > > Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> > > ---
> > > drivers/remoteproc/mtk_common.h | 2 ++
> > > drivers/remoteproc/mtk_scp.c | 3 +++
> > > 2 files changed, 5 insertions(+)
> > >
> > > diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h
> > > index 61901f5efa05..2aa9fdf5e59b 100644
> > > --- a/drivers/remoteproc/mtk_common.h
> > > +++ b/drivers/remoteproc/mtk_common.h
> > > @@ -51,6 +51,8 @@
> > > #define MT8192_CORE0_WDT_IRQ 0x10030
> > > #define MT8192_CORE0_WDT_CFG 0x10034
> > >
> > > +#define MT8192_SCP_DEVAPC_DOMAIN 0x85080
> > > +
> > > #define SCP_FW_VER_LEN 32
> > > #define SCP_SHARE_BUFFER_SIZE 288
> > >
> > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> > > index 9679cc26895e..50bdec5a97e3 100644
> > > --- a/drivers/remoteproc/mtk_scp.c
> > > +++ b/drivers/remoteproc/mtk_scp.c
> > > @@ -374,6 +374,9 @@ static int mt8192_scp_before_load(struct mtk_scp *scp)
> > > /* enable MPU for all memory regions */
> > > writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
> > >
> > > + /* set to DEVAPC (device access permission control) domain 3 */
> > > + writel(3, scp->reg_base + MT8192_SCP_DEVAPC_DOMAIN);
> > > +
> > > return 0;
> > > }
> > >
> > > --
> > > 2.31.0.rc2.261.g7f71774620-goog
> > >
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2021-03-18 1:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 3:43 [PATCH] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP Tzung-Bi Shih
2021-03-17 19:14 ` Bjorn Andersson
2021-03-18 1:27 ` Tzung-Bi Shih
2021-03-18 1:33 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFKt/mGha/IQRDz4@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ohad@wizery.com \
--cc=tinghan.shen@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox