From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4351EC433ED for ; Wed, 19 May 2021 05:31:11 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B823B61355 for ; Wed, 19 May 2021 05:31:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B823B61355 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0zPVP/RpAKnxsJaeMzDOGE+bYPWoNH9Dopt3xgYzPoo=; b=rcFJxtHmPITnFuGERkxuX87Mf Dg5sp6KwTYTjdwT7xF2DYsPEwokPQZrmlvxYdcI82Ewvtat/MKVZ53xR7W/BB5B4DaS+e19gkKVrW OYHivGrvVqZiDby3go/HqPjiW9Tft3LqMHJgQUSUaaU4MHiWL9uPCZnrGUiWIbY08Zxj+7LbjoHBx UTc+89JWQXxcolFu7zPAQ/bHVtmNqZpZnacuq9WU7b4rP9NQt6hTqTrFkiS1NPTDCei+G8oHoRVF4 J1BlMGmkxYzrdwvdPwhcX2rUGEw+hoejfXBQdqGQViP/ALZKp/du4Oy+/ccj26FUKnSwZ8HJEgHTJ VGS65ZftA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljEnG-002sY5-MI; Wed, 19 May 2021 05:30:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljEnE-002sXv-Mk for linux-mediatek@desiato.infradead.org; Wed, 19 May 2021 05:30:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yMOXpEPCzqu8BR1wQV3U2+zxRYEt0f2l5JWRczxbpNg=; b=pAkcyFqWdDN4fK6IXyTAb1CYuw Ed5rV3FIu9haxbwLZ68AYNTXlmCAOYhz7/CNTgAMEg2i8Bitl3PuTMCz1X1FaO+KkkUn5KiZT3UTU 2B/4b7BbVxpLimB1q1U/Q6ymsagcPesv1aQ1L8ySse4bwnh83zOtZCIMIcS4ZNmXsNp9IqOQQC1pM LmV2pI5uAqXWWHwJbo/+dACSIiw79jOmSmDl178L9k/UiGisdcF2nc0b2OPgaUL7BUjVYpzVgxZxT 2id2XPgsZhRlEuebAjLN4bKFTlko7LWH+FAifu9Xl7G2YAWoyL2u0ytiyo+8Zz4v40LGvlsFfEC4w 8q83EAMw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljEnB-00F9Bo-Tz for linux-mediatek@lists.infradead.org; Wed, 19 May 2021 05:30:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D4F5F601FA; Wed, 19 May 2021 05:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621402249; bh=IZ/BLZX4Aqvv1ZFlV/eqHFMjFdJgSCv+rA+ZFJYNjs0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Doil9XnFeNKB1QI5kjiI1Krk8iFioUEtHdeLQ7tWr6DmzSX4yNPy7VRCLkHe+12R7 KIcyK7NbKfkSpUyGeik8vejXCuUnmNlNEuhFa0zTF/XxcJ379bqsmj2OwsnLZ3nyJV jovzsMYWV9KQDeATEXXvXY2jSg3b72uDztGES5lUtXbAU/NDrHBfCD+JQYAxi/CC31 WYIyGfdZIZYT2M8OvUo/esnO75zQF/wfp+vwQToUJftH6TchDN1cihi66WkPGMSVf4 9uQ5QmEUDYvph1EWcN7VlKLJOf5Z1TEuFuppST7v0HF864Zaq1hE2ehROvacTtw/HE qL5sqKdjGe25w== Date: Wed, 19 May 2021 08:30:40 +0300 From: Mike Rapoport To: Miles Chen Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com, Catalin Marinas , Will Deacon , Mark Rutland Subject: Re: [PATCH] mm/sparse: fix check_usemap_section_nr warnings Message-ID: References: <20210511093114.15123-1-miles.chen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210511093114.15123-1-miles.chen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_223050_045651_9EE780A4 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org (add arm64 people) On Tue, May 11, 2021 at 05:31:14PM +0800, Miles Chen wrote: > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > node_data is allocated by kzmalloc. If CONFIG_NEED_MULTIPLE_NODES=n, The node structures are allocated from memblock rather than kzmalloc, so I'd suggest to use "dynamically allocated": ... node_data is dynamically allocated > we use a global variable named "contig_page_data". > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both kzalloc and ^ coma And here as well, rather then mention kzalloc ... __pa() can handle both dynamic allocation and symbol cases. > symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, we will have the > "virt_to_phys used for non-linear address" warning when booting. > > To fix it, create a small function to handle both translation. More generally, I wonder how other architectures than support DEBUG_VIRTUAL cope with this? Maybe such lack of consistency between debug and no-debug version of arm64::virt_to_phys() is what needs to be fixed at the first place? > Warning message: > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > [ 0.000000] Modules linked in: > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > [ 0.000000] Hardware name: linux,dummy-virt (DT) > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > [ 0.000000] sp : ffff800011833e70 > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > [ 0.000000] Call trace: > [ 0.000000] __virt_to_phys+0x58/0x68 > [ 0.000000] check_usemap_section_nr+0x50/0xfc > [ 0.000000] sparse_init_nid+0x1ac/0x28c > [ 0.000000] sparse_init+0x1c4/0x1e0 > [ 0.000000] bootmem_init+0x60/0x90 > [ 0.000000] setup_arch+0x184/0x1f0 > [ 0.000000] start_kernel+0x78/0x488 > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > Signed-off-by: Miles Chen > --- > mm/sparse.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/mm/sparse.c b/mm/sparse.c > index b2ada9dc00cb..55c18aff3e42 100644 > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -344,6 +344,15 @@ size_t mem_section_usage_size(void) > return sizeof(struct mem_section_usage) + usemap_size(); > } > > +static inline phys_addr_t pgdat_to_phys(struct pglist_data *pgdat) > +{ > +#ifndef CONFIG_NEED_MULTIPLE_NODES > + return __pa_symbol(pgdat); > +#else > + return __pa(pgdat); > +#endif > +} > + > #ifdef CONFIG_MEMORY_HOTREMOVE > static struct mem_section_usage * __init > sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > @@ -362,7 +371,7 @@ sparse_early_usemaps_alloc_pgdat_section(struct pglist_data *pgdat, > * from the same section as the pgdat where possible to avoid > * this problem. > */ > - goal = __pa(pgdat) & (PAGE_SECTION_MASK << PAGE_SHIFT); > + goal = pgdat_to_phys(pgdat) & (PAGE_SECTION_MASK << PAGE_SHIFT); > limit = goal + (1UL << PA_SECTION_SHIFT); > nid = early_pfn_to_nid(goal >> PAGE_SHIFT); > again: > @@ -390,7 +399,7 @@ static void __init check_usemap_section_nr(int nid, > } > > usemap_snr = pfn_to_section_nr(__pa(usage) >> PAGE_SHIFT); > - pgdat_snr = pfn_to_section_nr(__pa(pgdat) >> PAGE_SHIFT); > + pgdat_snr = pfn_to_section_nr(pgdat_to_phys(pgdat) >> PAGE_SHIFT); > if (usemap_snr == pgdat_snr) > return; > > -- > 2.18.0 -- Sincerely yours, Mike. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek