From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287CEC4338F for ; Tue, 27 Jul 2021 08:35:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC46A60FEE for ; Tue, 27 Jul 2021 08:35:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC46A60FEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P7pOAyDdQC5wz8Y8HrQQA0y9abJ+lhDXKp0SRG4IWec=; b=Do+OyWhLy4uP3T pgPTx7TPLrfwOb7jxZ5suc2UEyeWENiBFMy9EXlkrKHII8iQvDanS12ezDXq9oeSHw+bc+z1Zmttt avS2EPm2ana+BrCBUkq/rkj6Q5KwxO0Z1eWr98XnTY7tun9o3HKQEtaRA4wI8Tc1ESu6O+7IBPHxO 9nBFCNoQ2evgGd6W2yfetHclz0XDBnQbE83hUtnYnMAghquXvpegxj7xIEXfKEViyXXUoydgXRwVy 1+pEGeHQKfsQ0LyHYz09x/WJu5JIBUndRydT2ro8AlycaCCDiiHwsJuu9hzTFOB8SPEOVefAYFFoG xDyVArawaN8d0YVt/6IA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8IYc-00E5XR-MH; Tue, 27 Jul 2021 08:35:22 +0000 Received: from mx2.smtp.larsendata.com ([91.221.196.228]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8IYM-00E5Px-8q for linux-mediatek@lists.infradead.org; Tue, 27 Jul 2021 08:35:08 +0000 Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx2.smtp.larsendata.com (Halon) with ESMTPS id 934bb57b-eeb5-11eb-8d1a-0050568cd888; Tue, 27 Jul 2021 08:35:19 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id CD4A0194B9B; Tue, 27 Jul 2021 10:35:19 +0200 (CEST) Date: Tue, 27 Jul 2021 10:34:57 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Nicolas Boichat Cc: Neil Armstrong , David Airlie , Viresh Kumar , dri-devel@lists.freedesktop.org, Jordan Crouse , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Andrzej Hajda , Joonyoung Shim , Jonathan Marek , Krzysztof Kozlowski , Jernej Skrabec , Tzung-Bi Shih , Adrien Grassein , Chun-Kuang Hu , Jonas Karlman , linux-arm-msm@vger.kernel.org, Yangtao Li , Abhinav Kumar , linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, Pi-Hsun Shih , Hsin-Yi Wang , Matthias Brugger , Sean Paul , Xin Ji , linux-arm-kernel@lists.infradead.org, Rajendra Nayak , Thomas Zimmermann , Seung-Woo Kim , linux-kernel@vger.kernel.org, Robert Foss , Kyungmin Park , Yu Jiahua , Dmitry Baryshkov , freedreno@lists.freedesktop.org Subject: Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features Message-ID: References: <20210727094435.v3.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210727094435.v3.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210727_013506_538757_1896A6AB X-CRM114-Status: GOOD ( 14.15 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Nicolas, On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote: > Many of the DSI flags have names opposite to their actual effects, > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > be disabled. Fix this by including _NO_ in the flag names, e.g. > MIPI_DSI_MODE_NO_EOT_PACKET. > > Signed-off-by: Nicolas Boichat > Reviewed-by: Linus Walleij > Reviewed-by: Robert Foss > Reviewed-by: Laurent Pinchart > Reviewed-by: Andrzej Hajda > Reviewed-by: Xin Ji # anx7625.c > Reviewed-by: Abhinav Kumar # msm/dsi > --- > I considered adding _DISABLE_ instead, but that'd make the > flag names a big too long. > > Generated with: > flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HFP/" {} > flag=MIPI_DSI_MODE_VIDEO_HBP; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HBP/" {} > flag=MIPI_DSI_MODE_VIDEO_HSA; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HSA/" {} > flag=MIPI_DSI_MODE_EOT_PACKET; git grep $flag | cut -f1 -d':' | \ > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_NO_EOT_PACKET/" {} > (then minor format changes) > > Changes in v3: > - Added all R-b tags from v1 and v2 (hopefully didn't miss any). > > Changes in v2: > - Rebased on latest linux-next, after some of the flags got fixed > (Linus Walleij). Thanks for the update, applied to drm-misc-next. Sam _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek