From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7B4CC433F5 for ; Tue, 7 Sep 2021 15:18:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF66C6112E for ; Tue, 7 Sep 2021 15:18:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AF66C6112E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ReOvUSr4BChnOmZDFX8jQ4ltmG5EKMNVItspA0eJffo=; b=a1p2b8Ypjpe21Y pVbPFAZzUiBsfHlpva7HzkI5dXU6oUcChJya5K0wR1zASZm8PD1psS5zXcTPXSu173Py+aAqBYbCY Q0TnvtcBD9PaSB/mZz1gX9rniCquLmJ4UV6g9MlnGDhmVLdZUTsKnrXcC5JfY4yILzywHwBi7PUx8 l5mjOCwRm/WIxa/kNImqD9B2hjghSA0COttSRByVhHDnOUl77n1BllZz8D3z0ExJiMei5KkonvPAn PTKhiO8Nh8t1oxObL5/dyWk1MwM2q9+vRE4EDdXR9lvUBwGRyJ0g79LdEzIpH5rTTcNkRSUNybD4L qHWGMjmdFxkXtQ0ADhPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNcro-0041Dk-RO; Tue, 07 Sep 2021 15:18:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNcrX-00417b-Nn; Tue, 07 Sep 2021 15:18:17 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7EF88610D0; Tue, 7 Sep 2021 15:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631027895; bh=/97m/i74To/vQunmhZyAuwwUMsBBuG+szwVCniQt64A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pqofC4GztYvtJ7O/7E1CiSCDAktqLeJ/I06RGKJsi8i87pRdcWf2hq3o5YN0oRyiF UWfot5qtizBHxuJM5Wj04clC4HTGEpKpyssISmbiZCIE/V49g7YQ7vJ/ZxCX+mLx1c hSyskT5QoGiUQL+2xUnAXJVYObzNjsaKGokGil3w= Date: Tue, 7 Sep 2021 17:18:12 +0200 From: Greg KH To: DENG Qingfang Cc: Sasha Levin , stable@vger.kernel.org, Sean Wang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Matthias Brugger , "open list:MEDIATEK SWITCH DRIVER" , open list , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Subject: Re: [PATCH 4.19.y] net: dsa: mt7530: disable learning on standalone ports Message-ID: References: <20210824055509.1316124-1-dqfext@gmail.com> <20210902053619.1824464-1-dqfext@gmail.com> <20210903091430.2209627-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210903091430.2209627-1-dqfext@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_081815_851218_CEEBA2CD X-CRM114-Status: GOOD ( 29.68 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Sep 03, 2021 at 05:14:30PM +0800, DENG Qingfang wrote: > On Thu, Sep 02, 2021 at 07:58:37AM +0200, Greg KH wrote: > > On Thu, Sep 02, 2021 at 01:36:19PM +0800, DENG Qingfang wrote: > > > On Fri, Aug 27, 2021 at 12:19:23PM +0200, Greg KH wrote: > > > > On Tue, Aug 24, 2021 at 11:57:53PM +0800, DENG Qingfang wrote: > > > > > Standalone ports should have address learning disabled, according to > > > > > the documentation: > > > > > https://www.kernel.org/doc/html/v5.14-rc7/networking/dsa/dsa.html#bridge-layer > > > > > dsa_switch_ops on 5.10 or earlier does not have .port_bridge_flags > > > > > function so it has to be done differently. > > > > > > > > > > I've identified an issue related to this. > > > > > > > > What issue is that? Where was it reported? > > > > > > See Florian's message here > > > https://lore.kernel.org/stable/20210317003549.3964522-2-f.fainelli@gmail.com/ > > > > THat is just the patch changelog text, or is it unique to this > > stable-only patch? It is not obvious at all. > > The issue is with all DSA drivers that do not disable address learning > on standalone ports. > > "With learning enabled we would end up with the switch having > incorrectly learned the address of the CPU port which typically results > in a complete break down of network connectivity until the address > learned ages out and gets re-learned, from the correct port this time." > > > > > > > > > 2. A partial backport of this patch? > > > > > > > > > > The other part does not actually fix anything. > > > > > > > > Then why is it not ok to just take the whole thing? > > > > > > > > When backporting not-identical-patches, something almost always goes > > > > wrong, so we prefer to take the original commit when ever possible. > > > > > > Okay. MDB and tag ops can be backported as is, and broadcast/multicast > > > flooding can be implemented in .port_egress_floods. > > > > So what are we supposed to do here? > > Function port_egress_floods is refactored to port_bridge_flags in commit > a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags"). I can > backport the mt7530_port_bridge_flags function as port_egress_floods. I am sorry, I still do not understand what to do here. Ideally we want to take the original patches as get merged into Linus's tree. If that is not possible for some reason, we need to have it documented very well why that is so, and to get everyone to agree with the different patch that is submitted. thanks, greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek