From: Mark Brown <broonie@kernel.org>
To: Jiaxin Yu <jiaxin.yu@mediatek.com>
Cc: lgirdwood@gmail.com, tiwai@suse.com, robh+dt@kernel.org,
matthias.bgg@gmail.com, perex@perex.cz, p.zabel@pengutronix.de,
geert+renesas@glider.be, trevor.wu@mediatek.com,
tzungbi@google.com, zhangqilong3@huawei.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/15] ASoC: mediatek: mt8186: support hw gain in platform driver
Date: Fri, 11 Feb 2022 15:15:13 +0000 [thread overview]
Message-ID: <YgZ9gadN8RksWeWN@sirena.org.uk> (raw)
In-Reply-To: <20220211103818.8266-6-jiaxin.yu@mediatek.com>
[-- Attachment #1.1: Type: text/plain, Size: 889 bytes --]
On Fri, Feb 11, 2022 at 06:38:08PM +0800, Jiaxin Yu wrote:
Again, mostly looks good just some minor issues (I've not repeated some
that applied to the prior code):
> +static const struct snd_kcontrol_new mtk_hw_gain2_in_ch1_mix[] = {
> + SOC_DAPM_SINGLE_AUTODISABLE("ADDA_UL_CH1", AFE_CONN15,
> + I_ADDA_UL_CH1, 1, 0),
> +};
These end up as regular user visible controls so should have standard
control names - in this case ending in Switch since it's a simple
on/off. A similar issue was there in the earlier patches.
> +static const struct snd_kcontrol_new mtk_hw_gain_controls[] = {
> + SOC_SINGLE("HW Gain 1", AFE_GAIN1_CON1,
> + GAIN1_TARGET_SFT, GAIN1_TARGET_MASK, 0),
> + SOC_SINGLE("HW Gain 2", AFE_GAIN2_CON1,
> + GAIN2_TARGET_SFT, GAIN2_TARGET_MASK, 0),
These should have standard names like "HW 1 Volume" so userspace has a
better idea how to display them.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2022-02-11 15:17 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 10:38 [PATCH 00/15] ASoC: mediatek: Add support for MT8186 SoC Jiaxin Yu
2022-02-11 10:38 ` [PATCH 01/15] ASoC: mediatek: mt6366: add codec driver Jiaxin Yu
2022-02-11 14:54 ` Mark Brown
2022-02-11 10:38 ` [PATCH 02/15] ASoC: mediatek: mt8186: support audsys clock control Jiaxin Yu
2022-02-11 10:38 ` [PATCH 03/15] ASoC: mediatek: mt8186: support adda in platform driver Jiaxin Yu
2022-02-11 15:10 ` Mark Brown
2022-02-11 10:38 ` [PATCH 04/15] ASoC: mediatek: mt8186: support hostless " Jiaxin Yu
2022-02-11 10:38 ` [PATCH 05/15] ASoC: mediatek: mt8186: support hw gain " Jiaxin Yu
2022-02-11 15:15 ` Mark Brown [this message]
2022-02-17 14:05 ` Jiaxin Yu
2022-02-11 10:38 ` [PATCH 06/15] ASoC: mediatek: mt8186: support i2s " Jiaxin Yu
2022-02-11 10:38 ` [PATCH 07/15] ASoC: mediatek: mt8186: support pcm " Jiaxin Yu
2022-02-11 10:38 ` [PATCH 08/15] ASoC: mediatek: mt8186: support src " Jiaxin Yu
2022-02-11 10:38 ` [PATCH 09/15] ASoC: mediatek: mt8186: support tdm " Jiaxin Yu
2022-02-11 15:24 ` Mark Brown
2022-02-17 13:59 ` Jiaxin Yu
2022-02-11 10:38 ` [PATCH 10/15] ASoC: mediatek: mt8186: add " Jiaxin Yu
2022-02-11 16:12 ` Mark Brown
2022-02-17 13:51 ` Jiaxin Yu
2022-02-11 10:38 ` [PATCH 11/15] dt-bindings: mediatek: mt8186: add audio afe document Jiaxin Yu
2022-02-11 12:12 ` Rob Herring
2022-02-11 10:38 ` [PATCH 12/15] ASoC: mediatek: mt8186: add machine driver with mt6366, da7219 and max98357 Jiaxin Yu
2022-02-11 10:38 ` [PATCH 13/15] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document Jiaxin Yu
2022-02-11 10:38 ` [PATCH 14/15] ASoC: mediatek: mt8186: add machine driver with mt6366, rt1019 and rt5682 Jiaxin Yu
2022-02-11 10:38 ` [PATCH 15/15] dt-bindings: mediatek: mt8186: add mt8186-mt6366-rt1019-rt5682 document Jiaxin Yu
2022-02-11 16:14 ` [PATCH 00/15] ASoC: mediatek: Add support for MT8186 SoC Mark Brown
2022-02-12 7:18 ` Jiaxin Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgZ9gadN8RksWeWN@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=tzungbi@google.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox