* [RESEND v17 0/2] mtk: add ADSP mailbox controller for MT8195 @ 2022-02-24 13:30 Allen-KH Cheng 2022-02-24 13:30 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk, adsp-mbox: add mtk adsp-mbox document Allen-KH Cheng 2022-02-24 13:30 ` [PATCH v17 2/2] mailbox: mediatek: add support for adsp mailbox controller Allen-KH Cheng 0 siblings, 2 replies; 5+ messages in thread From: Allen-KH Cheng @ 2022-02-24 13:30 UTC (permalink / raw) To: Jassi Brar, Rob Herring, Matthias Brugger Cc: Jassi Brar, Linux-ALSA, tzungbi, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai, Chen-Yu Tsai, Kevin Hilman, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware, Allen-KH Cheng Mediatek ADSP IPC is used to send notification or short message between processors with dsp. It will place the message to the share buffer and will access the ADSP mailbox registers to kick dsp. Two mailboxes used to send notification or short message between processors with dsp. This patchset was tested and confirmed on MT8195 cherry board. Based on tag: next-20220223, linux-next/master changes since v16: - fix WARNING: modpost: missing MODULE_LICENSE() in drivers/mailbox /mtk-adsp-mailbox.o. Add MODULE_LICENSE in the last line. - Due to WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 in checkpatch, we don't remove SPDX-License in line 1. changes since v15: - add paragraphs to describe the config symbols fully changes since v14: - add inline for get_mtk_adsp_mbox_priv changes since v13: - rebase on v5.16-rc8 - add back ptr check from of_device_get_match_data changes since v12: - remove of_device_get_match_data ptr check: of_device_get_match_data(dev) will never going to return NULL. driver probe with compatible mediatek,mt8195-adsp-mbox. changes since v11: - remove useless MODULE_LICENSE changes since v10: - split up v9 into two separate submissions changes since v9: - rename adsp_mbox_chan_ops to mtk_adsp_mbox_chan_ops changes since v8: - remove struct adsp_mbox_ch_info - add get_mtk_adsp_mbox_priv - use mtk_adsp_mbox_priv va_mboxreg address in adsp mbox driver - add struct mtk_adsp_mbox_cfg for DSP mbox register offset - remove adsp mbox register offset hard code define - remove mtk-adsp-ipc.h reference in adsp mbox driver changes since v7: - add mtk prefix for adsp ipc functions - rename adsp_mbox_ch_info to mtk_adsp_mbox_ch_info - remove incorrect reviewers in commit message changes since v6: - dt-bindings: change example dtsi node. - rename config MTK_ADSP_IPC_MBOX to MTK_ADSP_MBOX - remove unused variable - add reviewers changes since v5: - remove some redundant code changes since v4: - use switch ... case in adsp_ipc_recv - add error handling path for chan_name pointer - refine some code to be concise changes since v3: - reorder MTK_ADSP_IPC_MBOX config - remove some redundant code - remove lock in mtk-adsp-mailbox changes since v2: - separate adsp_mailbox into two instances changes since v1: - fix dt_binding_check error Allen-KH Cheng (2): dt-bindings: mailbox: mtk,adsp-mbox: add mtk adsp-mbox document mailbox: mediatek: add support for adsp mailbox controller .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 ++++++ drivers/mailbox/Kconfig | 9 + drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-adsp-mailbox.c | 176 ++++++++++++++++++ 4 files changed, 239 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v17 1/2] dt-bindings: mailbox: mtk, adsp-mbox: add mtk adsp-mbox document 2022-02-24 13:30 [RESEND v17 0/2] mtk: add ADSP mailbox controller for MT8195 Allen-KH Cheng @ 2022-02-24 13:30 ` Allen-KH Cheng 2022-02-24 16:12 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: " Rob Herring 2022-02-24 13:30 ` [PATCH v17 2/2] mailbox: mediatek: add support for adsp mailbox controller Allen-KH Cheng 1 sibling, 1 reply; 5+ messages in thread From: Allen-KH Cheng @ 2022-02-24 13:30 UTC (permalink / raw) To: Jassi Brar, Rob Herring, Matthias Brugger Cc: Jassi Brar, Linux-ALSA, tzungbi, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai, Chen-Yu Tsai, Kevin Hilman, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware, Allen-KH Cheng, Allen-KH Cheng From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> This patch adds document for mediatek adsp mbox Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 +++++++++++++++++++ 1 file changed, 52 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml diff --git a/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml new file mode 100644 index 000000000000..25756837797f --- /dev/null +++ b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mailbox/mtk,adsp-mbox.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek ADSP mailbox + +maintainers: + - Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> + +description: | + The MTK ADSP mailbox Inter-Processor Communication (IPC) enables the SoC + to ommunicate with ADSP by passing messages through two mailbox channels. + The MTK ADSP mailbox IPC also provides the ability for one processor to + signal the other processor using interrupts. + +properties: + compatible: + items: + - const: mediatek,mt8195-adsp-mbox + + "#mbox-cells": + const: 0 + + reg: + description: + Physical address base for dsp mbox registers. + + interrupts: + description: + adsp mbox interrupt + +required: + - compatible + - "#mbox-cells" + - reg + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + adsp_mailbox0:mailbox@10816000 { + compatible = "mediatek,mt8195-adsp-mbox"; + #mbox-cells = <0>; + reg = <0x10816000 0x1000>; + interrupts = <GIC_SPI 702 IRQ_TYPE_LEVEL_HIGH 0>; + }; -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: add mtk adsp-mbox document 2022-02-24 13:30 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk, adsp-mbox: add mtk adsp-mbox document Allen-KH Cheng @ 2022-02-24 16:12 ` Rob Herring 2022-02-25 13:16 ` allen-kh.cheng 0 siblings, 1 reply; 5+ messages in thread From: Rob Herring @ 2022-02-24 16:12 UTC (permalink / raw) To: Allen-KH Cheng Cc: Jassi Brar, Matthias Brugger, Jassi Brar, Linux-ALSA, tzungbi, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai, Chen-Yu Tsai, Kevin Hilman, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Thu, Feb 24, 2022 at 09:30:44PM +0800, Allen-KH Cheng wrote: > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > This patch adds document for mediatek adsp mbox > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 +++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > new file mode 100644 > index 000000000000..25756837797f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > @@ -0,0 +1,52 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mailbox/mtk,adsp-mbox.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Mediatek ADSP mailbox > + > +maintainers: > + - Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > + > +description: | > + The MTK ADSP mailbox Inter-Processor Communication (IPC) enables the SoC > + to ommunicate with ADSP by passing messages through two mailbox channels. > + The MTK ADSP mailbox IPC also provides the ability for one processor to > + signal the other processor using interrupts. > + > +properties: > + compatible: > + items: > + - const: mediatek,mt8195-adsp-mbox > + > + "#mbox-cells": > + const: 0 > + > + reg: > + description: > + Physical address base for dsp mbox registers. That's fairly obvious. Drop. You need to define how many: 'maxItems: 1' > + > + interrupts: > + description: > + adsp mbox interrupt Same here. > + > +required: > + - compatible > + - "#mbox-cells" > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + adsp_mailbox0:mailbox@10816000 { > + compatible = "mediatek,mt8195-adsp-mbox"; > + #mbox-cells = <0>; > + reg = <0x10816000 0x1000>; > + interrupts = <GIC_SPI 702 IRQ_TYPE_LEVEL_HIGH 0>; > + }; > -- > 2.18.0 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: add mtk adsp-mbox document 2022-02-24 16:12 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: " Rob Herring @ 2022-02-25 13:16 ` allen-kh.cheng 0 siblings, 0 replies; 5+ messages in thread From: allen-kh.cheng @ 2022-02-25 13:16 UTC (permalink / raw) To: Rob Herring Cc: Jassi Brar, Matthias Brugger, Jassi Brar, Linux-ALSA, tzungbi, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai, Chen-Yu Tsai, Kevin Hilman, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware On Thu, 2022-02-24 at 10:12 -0600, Rob Herring wrote: > On Thu, Feb 24, 2022 at 09:30:44PM +0800, Allen-KH Cheng wrote: > > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > > > This patch adds document for mediatek adsp mbox > > > > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/mailbox/mtk,adsp-mbox.yaml | 52 > > +++++++++++++++++++ > > 1 file changed, 52 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > > > > diff --git a/Documentation/devicetree/bindings/mailbox/mtk,adsp- > > mbox.yaml b/Documentation/devicetree/bindings/mailbox/mtk,adsp- > > mbox.yaml > > new file mode 100644 > > index 000000000000..25756837797f > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mailbox/mtk,adsp-mbox.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: > > https://urldefense.com/v3/__http://devicetree.org/schemas/mailbox/mtk,adsp-mbox.yaml*__;Iw!!CTRNKA9wMg0ARbw!1-w9zcYC59nNwgZh8GRqYCSfHVTtj2nHfLuwGaqiLdOeCxlBGUkwqcW50EVBYejpHXulQA$ > > > > +$schema: > > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!1-w9zcYC59nNwgZh8GRqYCSfHVTtj2nHfLuwGaqiLdOeCxlBGUkwqcW50EVBYejjdYjzJw$ > > > > + > > +title: Mediatek ADSP mailbox > > + > > +maintainers: > > + - Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> > > + > > +description: | > > + The MTK ADSP mailbox Inter-Processor Communication (IPC) enables > > the SoC > > + to ommunicate with ADSP by passing messages through two mailbox > > channels. > > + The MTK ADSP mailbox IPC also provides the ability for one > > processor to > > + signal the other processor using interrupts. > > + > > +properties: > > + compatible: > > + items: > > + - const: mediatek,mt8195-adsp-mbox > > + > > + "#mbox-cells": > > + const: 0 > > + > > + reg: > > + description: > > + Physical address base for dsp mbox registers. > > That's fairly obvious. Drop. > > You need to define how many: 'maxItems: 1' > Hi Rob, thanks for your suggestions and comments. I will add the number information for reg and interrupts. Best Regards, Allen > > + > > + interrupts: > > + description: > > + adsp mbox interrupt > > Same here. > > > + > > +required: > > + - compatible > > + - "#mbox-cells" > > + - reg > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/arm-gic.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + > > + adsp_mailbox0:mailbox@10816000 { > > + compatible = "mediatek,mt8195-adsp-mbox"; > > + #mbox-cells = <0>; > > + reg = <0x10816000 0x1000>; > > + interrupts = <GIC_SPI 702 IRQ_TYPE_LEVEL_HIGH 0>; > > + }; > > -- > > 2.18.0 > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v17 2/2] mailbox: mediatek: add support for adsp mailbox controller 2022-02-24 13:30 [RESEND v17 0/2] mtk: add ADSP mailbox controller for MT8195 Allen-KH Cheng 2022-02-24 13:30 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk, adsp-mbox: add mtk adsp-mbox document Allen-KH Cheng @ 2022-02-24 13:30 ` Allen-KH Cheng 1 sibling, 0 replies; 5+ messages in thread From: Allen-KH Cheng @ 2022-02-24 13:30 UTC (permalink / raw) To: Jassi Brar, Rob Herring, Matthias Brugger Cc: Jassi Brar, Linux-ALSA, tzungbi, cujomalainey, Pierre-Louis Bossart, Liam Girdwood, Ranjani Sridharan, Kai Vehmanen, Daniel Baluta, Mark Brown, Jaroslav Kysela, Takashi Iwai, Chen-Yu Tsai, Kevin Hilman, Project_Global_Chrome_Upstream_Group, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, sound-open-firmware, Allen-KH Cheng, Allen-KH Cheng From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com> This patch is to for MediaTek ADSP IPC mailbox controller driver It is used to send short messages between processors with adsp Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@google.com> Reviewed-by: YC Hung <yc.hung@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- drivers/mailbox/Kconfig | 9 ++ drivers/mailbox/Makefile | 2 + drivers/mailbox/mtk-adsp-mailbox.c | 176 +++++++++++++++++++++++++++++ 3 files changed, 187 insertions(+) create mode 100644 drivers/mailbox/mtk-adsp-mailbox.c diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig index d9cd3606040e..05d6fae800e3 100644 --- a/drivers/mailbox/Kconfig +++ b/drivers/mailbox/Kconfig @@ -238,6 +238,15 @@ config STM32_IPCC with hardware for Inter-Processor Communication Controller (IPCC) between processors. Say Y here if you want to have this support. +config MTK_ADSP_MBOX + tristate "MediaTek ADSP Mailbox Controller" + depends on ARCH_MEDIATEK || COMPILE_TEST + help + Say yes here to add support for "MediaTek ADSP Mailbox Controller. + This mailbox driver is used to send notification or short message + between processors with ADSP. It will place the message to share + buffer and will access the ipc control. + config MTK_CMDQ_MBOX tristate "MediaTek CMDQ Mailbox Support" depends on ARCH_MEDIATEK || COMPILE_TEST diff --git a/drivers/mailbox/Makefile b/drivers/mailbox/Makefile index 338cc05e5431..fc9376117111 100644 --- a/drivers/mailbox/Makefile +++ b/drivers/mailbox/Makefile @@ -49,6 +49,8 @@ obj-$(CONFIG_TEGRA_HSP_MBOX) += tegra-hsp.o obj-$(CONFIG_STM32_IPCC) += stm32-ipcc.o +obj-$(CONFIG_MTK_ADSP_MBOX) += mtk-adsp-mailbox.o + obj-$(CONFIG_MTK_CMDQ_MBOX) += mtk-cmdq-mailbox.o obj-$(CONFIG_ZYNQMP_IPI_MBOX) += zynqmp-ipi-mailbox.o diff --git a/drivers/mailbox/mtk-adsp-mailbox.c b/drivers/mailbox/mtk-adsp-mailbox.c new file mode 100644 index 000000000000..5e7378090c7b --- /dev/null +++ b/drivers/mailbox/mtk-adsp-mailbox.c @@ -0,0 +1,176 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2022 MediaTek Corporation. All rights reserved. + * Author: Allen-KH Cheng <allen-kh.cheng@mediatek.com> + */ + +#include <linux/interrupt.h> +#include <linux/io.h> +#include <linux/iopoll.h> +#include <linux/kernel.h> +#include <linux/mailbox_controller.h> +#include <linux/module.h> +#include <linux/of_device.h> +#include <linux/slab.h> + +struct mtk_adsp_mbox_priv { + struct device *dev; + struct mbox_controller mbox; + void __iomem *va_mboxreg; + const struct mtk_adsp_mbox_cfg *cfg; +}; + +struct mtk_adsp_mbox_cfg { + u32 set_in; + u32 set_out; + u32 clr_in; + u32 clr_out; +}; + +static inline struct mtk_adsp_mbox_priv *get_mtk_adsp_mbox_priv(struct mbox_controller *mbox) +{ + return container_of(mbox, struct mtk_adsp_mbox_priv, mbox); +} + +static irqreturn_t mtk_adsp_mbox_irq(int irq, void *data) +{ + struct mbox_chan *chan = data; + struct mtk_adsp_mbox_priv *priv = get_mtk_adsp_mbox_priv(chan->mbox); + u32 op = readl(priv->va_mboxreg + priv->cfg->set_out); + + writel(op, priv->va_mboxreg + priv->cfg->clr_out); + + return IRQ_WAKE_THREAD; +} + +static irqreturn_t mtk_adsp_mbox_isr(int irq, void *data) +{ + struct mbox_chan *chan = data; + + mbox_chan_received_data(chan, NULL); + + return IRQ_HANDLED; +} + +static struct mbox_chan *mtk_adsp_mbox_xlate(struct mbox_controller *mbox, + const struct of_phandle_args *sp) +{ + return mbox->chans; +} + +static int mtk_adsp_mbox_startup(struct mbox_chan *chan) +{ + struct mtk_adsp_mbox_priv *priv = get_mtk_adsp_mbox_priv(chan->mbox); + + /* Clear ADSP mbox command */ + writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_in); + writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_out); + + return 0; +} + +static void mtk_adsp_mbox_shutdown(struct mbox_chan *chan) +{ + struct mtk_adsp_mbox_priv *priv = get_mtk_adsp_mbox_priv(chan->mbox); + + /* Clear ADSP mbox command */ + writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_in); + writel(0xFFFFFFFF, priv->va_mboxreg + priv->cfg->clr_out); +} + +static int mtk_adsp_mbox_send_data(struct mbox_chan *chan, void *data) +{ + struct mtk_adsp_mbox_priv *priv = get_mtk_adsp_mbox_priv(chan->mbox); + u32 *msg = data; + + writel(*msg, priv->va_mboxreg + priv->cfg->set_in); + + return 0; +} + +static bool mtk_adsp_mbox_last_tx_done(struct mbox_chan *chan) +{ + struct mtk_adsp_mbox_priv *priv = get_mtk_adsp_mbox_priv(chan->mbox); + + return readl(priv->va_mboxreg + priv->cfg->set_in) == 0; +} + +static const struct mbox_chan_ops mtk_adsp_mbox_chan_ops = { + .send_data = mtk_adsp_mbox_send_data, + .startup = mtk_adsp_mbox_startup, + .shutdown = mtk_adsp_mbox_shutdown, + .last_tx_done = mtk_adsp_mbox_last_tx_done, +}; + +static int mtk_adsp_mbox_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct mtk_adsp_mbox_priv *priv; + const struct mtk_adsp_mbox_cfg *cfg; + struct mbox_controller *mbox; + int ret, irq; + + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + mbox = &priv->mbox; + mbox->dev = dev; + mbox->ops = &mtk_adsp_mbox_chan_ops; + mbox->txdone_irq = false; + mbox->txdone_poll = true; + mbox->of_xlate = mtk_adsp_mbox_xlate; + mbox->num_chans = 1; + mbox->chans = devm_kzalloc(dev, sizeof(*mbox->chans), GFP_KERNEL); + if (!mbox->chans) + return -ENOMEM; + + priv->va_mboxreg = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(priv->va_mboxreg)) + return PTR_ERR(priv->va_mboxreg); + + cfg = of_device_get_match_data(dev); + if (!cfg) + return -EINVAL; + priv->cfg = cfg; + + irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + + ret = devm_request_threaded_irq(dev, irq, mtk_adsp_mbox_irq, + mtk_adsp_mbox_isr, IRQF_TRIGGER_NONE, + dev_name(dev), mbox->chans); + if (ret < 0) + return ret; + + platform_set_drvdata(pdev, priv); + + return devm_mbox_controller_register(dev, &priv->mbox); +} + +static const struct mtk_adsp_mbox_cfg mt8195_adsp_mbox_cfg = { + .set_in = 0x00, + .set_out = 0x1c, + .clr_in = 0x04, + .clr_out = 0x20, +}; + +static const struct of_device_id mtk_adsp_mbox_of_match[] = { + { .compatible = "mediatek,mt8195-adsp-mbox", .data = &mt8195_adsp_mbox_cfg }, + {}, +}; +MODULE_DEVICE_TABLE(of, mtk_adsp_mbox_of_match); + +static struct platform_driver mtk_adsp_mbox_driver = { + .probe = mtk_adsp_mbox_probe, + .driver = { + .name = "mtk_adsp_mbox", + .of_match_table = mtk_adsp_mbox_of_match, + }, +}; +module_platform_driver(mtk_adsp_mbox_driver); + +MODULE_AUTHOR("Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>"); +MODULE_DESCRIPTION("MTK ADSP Mailbox Controller"); +MODULE_LICENSE("GPL v2"); -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-25 13:20 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-02-24 13:30 [RESEND v17 0/2] mtk: add ADSP mailbox controller for MT8195 Allen-KH Cheng 2022-02-24 13:30 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk, adsp-mbox: add mtk adsp-mbox document Allen-KH Cheng 2022-02-24 16:12 ` [PATCH v17 1/2] dt-bindings: mailbox: mtk,adsp-mbox: " Rob Herring 2022-02-25 13:16 ` allen-kh.cheng 2022-02-24 13:30 ` [PATCH v17 2/2] mailbox: mediatek: add support for adsp mailbox controller Allen-KH Cheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).