Re: [PATCH v9 01/22] dt-bindings: mediatek,dpi: Add DP_INTF compatible

Matthias Brugger
2022-03-29T10:43:02Z

On 28/03/2022 00:39, Guillaume Ranquet wrote:
> From: Markus Schneider-Pargmann <msp@baylibre.com>
>
> DP_INTF is similar to DPI but does not have the exact same feature set
> or register layouts.
>
> DP_INTF is the sink of the display pipeline that is connected to the
> DisplayPort controller and encoder unit. It takes the same clocks as
> DPI.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
> .../bindings/display/mediatek/mediatek,dpi.yaml | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> index dd2896a40ff0..2dba80ad3b18 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml
> @@ -4,16 +4,16 @@
> $id: http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: mediatek DPI Controller Device Tree Bindings
> +title: mediatek DPI/DP_INTF Controller
>
> maintainers:
> - CK Hu <ck.hu@mediatek.com>
> - Jitao shi <jitao.shi@mediatek.com>
>
> description: |
> - The Mediatek DPI function block is a sink of the display subsystem and
> - provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a parallel
> - output bus.
> + The Mediatek DPI and DP_INTF function blocks are a sink of the display
> + subsystem and provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on a
> + parallel output bus.
>
> properties:
> compatible:
> @@ -23,6 +23,7 @@ properties:
> - mediatek,mt8173-dpi
> - mediatek,mt8183-dpi
> - mediatek,mt8192-dpi
> + - mediatek,mt8195-dpintf
>
> reg:
> maxItems: 1
> @@ -54,7 +55,7 @@ properties:
> $ref: /schemas/graph.yaml#/properties/port
> description:
> Output port node. This port should be connected to the input port of an
> - attached HDMI or LVDS encoder chip.
> + attached HDMI, LVDS or DisplayPort encoder chip.
>
> required:
> - compatible