From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mark Brown <broonie@kernel.org>, Chuanhong Guo <gch981213@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Chuanhong Guo <gch981213@gmail.com>,
linux-spi@vger.kernel.org, linux-mediatek@lists.infradead.org,
kernel-janitors@vger.kernel.org
Subject: [PATCH] spi: mtk-snfi: preserve dma_mapping_error() error codes
Date: Fri, 29 Apr 2022 20:41:37 +0300 [thread overview]
Message-ID: <YmwjUcTKyQNrrn2g@kili> (raw)
Return -ENOMEM of there is a dma mapping error. Do not return success.
Fixes: 764f1b748164 ("spi: add driver for MTK SPI NAND Flash Interface")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/spi/spi-mtk-snfi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi-mtk-snfi.c b/drivers/spi/spi-mtk-snfi.c
index 2c556e304673..d66bf9762557 100644
--- a/drivers/spi/spi-mtk-snfi.c
+++ b/drivers/spi/spi-mtk-snfi.c
@@ -903,7 +903,8 @@ static int mtk_snand_read_page_cache(struct mtk_snand *snf,
nfi_write32(snf, NFI_CON, (snf->nfi_cfg.nsectors << CON_SEC_NUM_S));
buf_dma = dma_map_single(snf->dev, buf, dma_len, DMA_FROM_DEVICE);
- if (dma_mapping_error(snf->dev, buf_dma)) {
+ ret = dma_mapping_error(snf->dev, buf_dma);
+ if (ret) {
dev_err(snf->dev, "DMA mapping failed.\n");
goto cleanup;
}
@@ -1092,7 +1093,8 @@ static int mtk_snand_write_page_cache(struct mtk_snand *snf,
nfi_write32(snf, NFI_CON, (snf->nfi_cfg.nsectors << CON_SEC_NUM_S));
buf_dma = dma_map_single(snf->dev, snf->buf, dma_len, DMA_TO_DEVICE);
- if (dma_mapping_error(snf->dev, buf_dma)) {
+ ret = dma_mapping_error(snf->dev, buf_dma);
+ if (ret) {
dev_err(snf->dev, "DMA mapping failed.\n");
goto cleanup;
}
--
2.35.1
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next reply other threads:[~2022-04-29 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 17:41 Dan Carpenter [this message]
2022-05-02 9:43 ` [PATCH] spi: mtk-snfi: preserve dma_mapping_error() error codes Chuanhong Guo
2022-05-03 15:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmwjUcTKyQNrrn2g@kili \
--to=dan.carpenter@oracle.com \
--cc=broonie@kernel.org \
--cc=gch981213@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox